From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: npostavs@users.sourceforge.net Newsgroups: gmane.emacs.bugs Subject: bug#21072: Brave new mark-defun (and a testing tool) Date: Tue, 09 May 2017 22:53:40 -0400 Message-ID: <87pofhjubv.fsf@users.sourceforge.net> References: <87o9ydrzkr.fsf@mbork.pl> <87efyze00g.fsf@jane> <87bmu2eoji.fsf@jane> <87wpcpw61w.fsf@jane> <83o9xdghmc.fsf@gnu.org> <87o9wkoald.fsf@jane> <87a881ofsu.fsf@jane> <87k272wh8x.fsf@users.sourceforge.net> <871st4aal7.fsf@jane> <87tw5l7v26.fsf@jane> <877f2hs1nw.fsf@users.sourceforge.net> <87zifa9ce5.fsf@jane> <87shl0pbcg.fsf@users.sourceforge.net> <87shky9ez8.fsf@jane> <8737cyotmt.fsf@users.sourceforge.net> <87h919yf5g.fsf@jane> <87efvygq6q.fsf@jane> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1494384800 24239 195.159.176.226 (10 May 2017 02:53:20 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 10 May 2017 02:53:20 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) Cc: 21072@debbugs.gnu.org, Stefan Monnier To: Marcin Borkowski Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed May 10 04:53:15 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d8HkY-00066G-Rm for geb-bug-gnu-emacs@m.gmane.org; Wed, 10 May 2017 04:53:15 +0200 Original-Received: from localhost ([::1]:40173 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d8Hka-0004Dd-Tj for geb-bug-gnu-emacs@m.gmane.org; Tue, 09 May 2017 22:53:16 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:60935) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d8HkQ-0004DT-2o for bug-gnu-emacs@gnu.org; Tue, 09 May 2017 22:53:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d8HkN-00054i-04 for bug-gnu-emacs@gnu.org; Tue, 09 May 2017 22:53:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:60388) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1d8HkM-00054R-Rl for bug-gnu-emacs@gnu.org; Tue, 09 May 2017 22:53:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1d8HkM-0004dm-Dm for bug-gnu-emacs@gnu.org; Tue, 09 May 2017 22:53:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: npostavs@users.sourceforge.net Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 10 May 2017 02:53:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21072 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 21072-submit@debbugs.gnu.org id=B21072.149438473617778 (code B ref 21072); Wed, 10 May 2017 02:53:02 +0000 Original-Received: (at 21072) by debbugs.gnu.org; 10 May 2017 02:52:16 +0000 Original-Received: from localhost ([127.0.0.1]:34832 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d8Hjb-0004cg-Ps for submit@debbugs.gnu.org; Tue, 09 May 2017 22:52:15 -0400 Original-Received: from mail-it0-f43.google.com ([209.85.214.43]:38419) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d8HjZ-0004cS-G9 for 21072@debbugs.gnu.org; Tue, 09 May 2017 22:52:14 -0400 Original-Received: by mail-it0-f43.google.com with SMTP id e65so12925465ita.1 for <21072@debbugs.gnu.org>; Tue, 09 May 2017 19:52:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=Jav+FTwWyv2pVT+pMKk6kxJo2JHL1jrooRCKk8FG9PU=; b=IZTTbRAvHoiavS+8icNFLr7DgofYb4r5lSsP/JDPvLlwk8sNsM0rlV4o8n722PcWWm CwzsSvt4xrKaBjDafIXTQNEvrHfhiOpkoZJZ9lJ8Dx7y7XAA8UcPzsjJkvkjcFQ03Agv 2Tds7GC41BnAq43duV4R9V1WN6bYmk7OQMjVZ+WkL91KB80Gh5MBShY5ql1QAxM6bQlU WTy/9R13RFFTHpuB6ENE+u9uPA0fxlb6gu9CfCLUeZ5ba7Mdu+MauCEZoH8gy3UaBj3s eaz7vssrc9H+5EiUR5N7vpmmXOaoFrWXczc/tA+iHv5udMl9wVOBiJNRfs32mYbWCKz9 /C2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=Jav+FTwWyv2pVT+pMKk6kxJo2JHL1jrooRCKk8FG9PU=; b=Ud9F5++k1SCtBWsTq+moza6iIDa+Suc/5UEVHwIjOGuJvPotItp6JVPWQTbOVI3Sih qXaAflPtwkqZWFHI1nAHbB9b4HQut6miAHi+fCRq6UdXXdt/y5bhSwp9kJczacHC0G1w UN6ze7kXV76rsAQySe/eetmPq8Cdu/wc49S0+Gd8e+c54SjaXFSYYat7riiJf7kOzurp S+jsYKn+DJ9SANovCWeX54CXT2jg3Pe7jp9NuAC84vNZ4mmdARmXHtqqzSRp4V7wc1+k +8dYbBqv3ZolrUUOMoDg2w7g8a6nUHFf2pTMx8LS0lRXxKbHshr/0c4o70z+SvJzD2rh M5uw== X-Gm-Message-State: AODbwcBsTCzvMm58EpH25g+g5rgPQmqr6WTngXUyzvsAO7SmPuqag03X ARzz25Mkw0DUlw== X-Received: by 10.36.193.66 with SMTP id e63mr4293635itg.86.1494384727876; Tue, 09 May 2017 19:52:07 -0700 (PDT) Original-Received: from zony ([45.2.7.65]) by smtp.googlemail.com with ESMTPSA id r16sm502789ioi.8.2017.05.09.19.52.06 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 09 May 2017 19:52:07 -0700 (PDT) In-Reply-To: <87efvygq6q.fsf@jane> (Marcin Borkowski's message of "Tue, 09 May 2017 14:39:09 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:132414 Archived-At: Marcin Borkowski writes: > I finally found some time to make the branch nicer, deleted it from the > server and pushed the new one. Could you look at it one more time and > merge it to master (or greenlight me to do it)? [[c1c3403cf2]] > Fix Bug#21072 and rework `mark-defun' > > * test/lisp/progmodes/elisp-mode-tests.el (mark-defun-test-buffer): > New variable > (mark-defun-no-arg-region-inactive) > (mark-defun-no-arg-region-active) > (mark-defun-arg-region-active) > (mark-defun-pos-arg-region-inactive) There should be a colon after the close paren on each of those lines. > (mark-defun-neg-arg-region-inactive, mark-defun-bob): Add tests for > the new `mark-defun' > > * lisp/emacs-lisp/lisp.el (beginning-of-defun--in-emptyish-line-p): > New function > (beginning-of-defun-comments): New function > (mark-defun): Fix bug#21072, also rewrite large parts of `mark-defun' > to accept a numerical prefix argument There should be a period at the end of each entry. [[aeed45da]] > * lisp/emacs-lisp/lisp.el (mark-defun): simplify moving the point Missing capitalization and period (if you're not just squashing this). [[b8fd2c2ca1]] > * Fix elisp-tests-with-temp-buffer compilation [...] Please add to this the patch from https://debbugs.gnu.org/cgi/bugreport.cgi?bug=21072#254. [[7efd2f2ea1]] > Modify `beginning-of-defun-comments' If you are keeping this one, I would add to the commit message: * lisp/emacs-lisp/lisp.el (beginning-of-defun-comments): Try not to stop in the middle of a multiline comment.