unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: npostavs@users.sourceforge.net
To: Pierre Neidhardt <ambrevar@gmail.com>
Cc: 27407@debbugs.gnu.org
Subject: bug#27407: 25.2; SGR reset is ignored if it terminates Eshell's output
Date: Sun, 18 Jun 2017 13:50:20 -0400	[thread overview]
Message-ID: <87poe1qj6r.fsf@users.sourceforge.net> (raw)
In-Reply-To: <20170618064917.GB3761@gmail.com> (Pierre Neidhardt's message of "Sun, 18 Jun 2017 07:49:17 +0100")

Pierre Neidhardt <ambrevar@gmail.com> writes:

> On 17-06-17 14:19:54, npostavs@users.sourceforge.net wrote:
>
> I haven't tried your patch, but in the general case Eshell should not extend the
> ANSI coloring to the prompt, SGR reset or not. I.e. the following should not
> color the prompt:
>
> 	(insert "echo \"\e[33mhello")

My patch does not solve this scenario, but on the other hand, when I try
this experiment in a terminal with bash, not putting a reset does give a
coloured prompt, i.e., in the following the 2nd "~/src$" is in yellow:

    ~/src$ echo $'\e[33mhello'
    hello
    ~/src$ 

So should eshell really be any different?





  reply	other threads:[~2017-06-18 17:50 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-17 11:31 bug#27407: 25.2; SGR reset is ignored if it terminates Eshell's output Pierre Neidhardt
2017-06-17 18:19 ` npostavs
2017-06-18  6:49   ` Pierre Neidhardt
2017-06-18 17:50     ` npostavs [this message]
2017-06-18 18:07       ` Pierre Neidhardt
2017-06-18 19:34         ` npostavs
2017-07-03 14:12           ` npostavs

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87poe1qj6r.fsf@users.sourceforge.net \
    --to=npostavs@users.sourceforge.net \
    --cc=27407@debbugs.gnu.org \
    --cc=ambrevar@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).