From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#18951: eshell-pcomplete removes asterisk when attempting completion Date: Thu, 02 Nov 2017 07:32:13 -0400 Message-ID: <87po909arm.fsf@users.sourceforge.net> References: <86tx2ei4b4.fsf@yandex.ru> <871slid45i.fsf@kraus.my> <87efpi9neq.fsf@users.sourceforge.net> <877ev9p3m7.fsf@kraus.my> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1509622407 2487 195.159.176.226 (2 Nov 2017 11:33:27 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 2 Nov 2017 11:33:27 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux) Cc: 18951@debbugs.gnu.org To: Daniel Kraus Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Nov 02 12:33:20 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eADkJ-00083a-B8 for geb-bug-gnu-emacs@m.gmane.org; Thu, 02 Nov 2017 12:33:15 +0100 Original-Received: from localhost ([::1]:59737 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eADkQ-00074W-Gl for geb-bug-gnu-emacs@m.gmane.org; Thu, 02 Nov 2017 07:33:22 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43590) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eADkB-000707-4Y for bug-gnu-emacs@gnu.org; Thu, 02 Nov 2017 07:33:12 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eADk6-0007Tm-3v for bug-gnu-emacs@gnu.org; Thu, 02 Nov 2017 07:33:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:38279) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eADk6-0007Td-0R for bug-gnu-emacs@gnu.org; Thu, 02 Nov 2017 07:33:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eADk5-0000oY-Q2 for bug-gnu-emacs@gnu.org; Thu, 02 Nov 2017 07:33:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 02 Nov 2017 11:33:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 18951 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 18951-submit@debbugs.gnu.org id=B18951.15096223453084 (code B ref 18951); Thu, 02 Nov 2017 11:33:01 +0000 Original-Received: (at 18951) by debbugs.gnu.org; 2 Nov 2017 11:32:25 +0000 Original-Received: from localhost ([127.0.0.1]:46960 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eADjU-0000nd-3f for submit@debbugs.gnu.org; Thu, 02 Nov 2017 07:32:25 -0400 Original-Received: from mail-io0-f179.google.com ([209.85.223.179]:56178) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eADjR-0000nP-UQ for 18951@debbugs.gnu.org; Thu, 02 Nov 2017 07:32:22 -0400 Original-Received: by mail-io0-f179.google.com with SMTP id p186so13141292ioe.12 for <18951@debbugs.gnu.org>; Thu, 02 Nov 2017 04:32:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=aYz1T/pilocvA9J/ZqUDSpu3iFEeZ4RUUqrnMOsoiAk=; b=BJBpnbhSgHJsH+CCbRcgY5o4pruqW0TzUaw2OjsOC7jnwYH7iodD4bvR9WbXPFn5kg DbKMo4lUdCEC3elP2tdDNPuHVPoQlt/8fQUz3Yq3urBMqYW8jkQVrU3AjxVi28pVGrxB tm3TsLHSS+qcHFvOpneSeTLJ1RUSHuxj1Z/8XyBOz/ibUVvvoBLM0fl93I1oh+sEJ34w c+htLGu4qDhA/5z3PcyNqHWf+9icd3N4EV1LtWTQPzOGT91iVGkKG6ufRnLaQTA1KfWR z5Kr9ua+v4q89sAP/Odcv7k2Vk+epIwnsLnihqOrotT1e287TycurLrPCO8Elb1al33Y ooTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=aYz1T/pilocvA9J/ZqUDSpu3iFEeZ4RUUqrnMOsoiAk=; b=O/hvY2T7ThynfyqJiB9VGzejkfLyhMPpe1XxwiE227MPujFypSKkiO8XOZ4a3V9I6Q 671DLeV/eKaEhhO9PYzVLbnp1AvUULnJcjzoL9cSmSsIk+JRhX4Y4uhPXyotJa3mlvxG aArlgQk7WJEd5MdbK2DkjWjJIglgOdDydAlhvUz2zPWwfFVdypnyhJEltnwWNg1QI2bH QUAYvYKIgaTNHwz4Fi9B1CKGI6K/YOeoHK7yAl7dpBiLUUW41u1iCpqcdjG8Gm5j5VVQ ksi1SUc/vr9K04T4zdMydcURV6vYeJQeZTR8MO8aoBFGsqFbWB+AXWIi7RtSlJL0q0Ad rpjQ== X-Gm-Message-State: AMCzsaU63cTif5gXwM0aarMY19Ajo1r69YoTKfc74yBATrPNVk6QmMD2 HrBvEr28/Q1sdqKtwLh0qVW+fw== X-Google-Smtp-Source: ABhQp+SS3jICYabky3sgQwGFOiObW+WWoHqmU++B54QQjHaZdssRwtpXM+nEh6IuVlXo0iJsI9oEDQ== X-Received: by 10.36.108.67 with SMTP id w64mr1989134itb.126.1509622335875; Thu, 02 Nov 2017 04:32:15 -0700 (PDT) Original-Received: from zebian ([45.2.119.34]) by smtp.googlemail.com with ESMTPSA id q191sm1037093itb.1.2017.11.02.04.32.13 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 02 Nov 2017 04:32:14 -0700 (PDT) In-Reply-To: <877ev9p3m7.fsf@kraus.my> (Daniel Kraus's message of "Thu, 02 Nov 2017 15:00:00 +0800") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:139358 Archived-At: Daniel Kraus writes: > Noam Postavsky writes: > >> A good start would be to step through eshell-pcomplete with edebug and >> find the piece of code which deletes the asterisk. > > It's in `pcomplete-parse-arguments` (in pcomplete.el) > Line 776 on master: > ``` > (when (and begin (not pcomplete-show-list)) > (delete-region begin (point)) > (pcomplete-insert-entry "" pcomplete-stub)) > ``` Hmm, does this do the right thing? --- i/lisp/pcomplete.el +++ w/lisp/pcomplete.el @@ -772,7 +772,7 @@ pcomplete-parse-arguments (setq c (cdr c))) (setq pcomplete-stub (substring common-stub 0 len) pcomplete-autolist t) - (when (and begin (not pcomplete-show-list)) + (when (and begin (> len 0) (not pcomplete-show-list)) (delete-region begin (point)) (pcomplete-insert-entry "" pcomplete-stub)) (throw 'pcomplete-completions completions))