From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eric Abrahamsen Newsgroups: gmane.emacs.bugs Subject: bug#28587: 26.0.60; Don't write object name strings in object-write method Date: Fri, 10 Nov 2017 17:39:35 -0800 Message-ID: <87po8pzj8o.fsf@ericabrahamsen.net> References: <87efqvg5tw.fsf@ericabrahamsen.net> <87o9octu8m.fsf@ericabrahamsen.net> <87d14sscwh.fsf@ericabrahamsen.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1510364420 6234 195.159.176.226 (11 Nov 2017 01:40:20 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 11 Nov 2017 01:40:20 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 28587@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Nov 11 02:40:12 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eDKmJ-00010w-0G for geb-bug-gnu-emacs@m.gmane.org; Sat, 11 Nov 2017 02:40:11 +0100 Original-Received: from localhost ([::1]:44109 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eDKmL-000333-Gk for geb-bug-gnu-emacs@m.gmane.org; Fri, 10 Nov 2017 20:40:13 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:49644) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eDKmE-00032x-RU for bug-gnu-emacs@gnu.org; Fri, 10 Nov 2017 20:40:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eDKmA-0006O4-D3 for bug-gnu-emacs@gnu.org; Fri, 10 Nov 2017 20:40:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:54080) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eDKmA-0006Nz-7W for bug-gnu-emacs@gnu.org; Fri, 10 Nov 2017 20:40:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eDKm9-00049h-QV for bug-gnu-emacs@gnu.org; Fri, 10 Nov 2017 20:40:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eric Abrahamsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 11 Nov 2017 01:40:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28587 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 28587-submit@debbugs.gnu.org id=B28587.151036438115945 (code B ref 28587); Sat, 11 Nov 2017 01:40:01 +0000 Original-Received: (at 28587) by debbugs.gnu.org; 11 Nov 2017 01:39:41 +0000 Original-Received: from localhost ([127.0.0.1]:34528 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eDKlp-000497-HK for submit@debbugs.gnu.org; Fri, 10 Nov 2017 20:39:41 -0500 Original-Received: from mail.ericabrahamsen.net ([50.56.99.223]:57372) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eDKln-000491-UF for 28587@debbugs.gnu.org; Fri, 10 Nov 2017 20:39:40 -0500 Original-Received: from localhost (71-212-22-173.tukw.qwest.net [71.212.22.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id AE147BF9C8; Sat, 11 Nov 2017 01:39:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mail.ericabrahamsen.net; s=mail; t=1510364376; bh=clSqRfNZyLWe1CgxkA1JezZhzBcKU24Zbsfmir4BYV0=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=CsR1qwmPLdhBDcSuenUTKR5yTHnVeup/Uv7+QDcW/drNKVfFh7cn32jlHx7FNjAqw Sm0rv9/k/fYD8qBb6VeF9XBU3n7VAzazrq9JA8qdqvzX25HGuvHT2zqpJ/oZhG445+ F6TAJ3RPHuT9UN1D+Wk8s4AHNTTtG3dPhCJYpDC4= In-Reply-To: (Stefan Monnier's message of "Wed, 08 Nov 2017 17:05:45 -0500") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:139741 Archived-At: On 11/08/17 17:05 PM, Stefan Monnier wrote: >>> AFAIK names are deprecated in calls to EIEIO constructors since >>> Emacs-25 (rather 24.4), and it's only since Emacs-26 that they are >>> optional in "eieio-presistent" written representations. >> Okay I see, I got a little confused there. I checked the emacs 25 branch >> and it ignores an object name string (emacs 24 requires it), so maybe >> the only important thing is to say: >> "Note that prior to Emacs version 25 the object name is required." > > I think the only important part is that Emacs<26 requires it (tho only > Emacs<25 makes actual use of it, and even then, this use is mostly > irrelevant, except maybe in corner cases in the course of debugging). Okay, there it goes, with a modified docstring. Tests are passing here; if no one complains in the next couple days, I'll close this bug report. Eric