From: Eric Abrahamsen <eric@ericabrahamsen.net>
To: Stefan Monnier <monnier@IRO.UMontreal.CA>
Cc: 28587@debbugs.gnu.org
Subject: bug#28587: 26.0.60; Don't write object name strings in object-write method
Date: Fri, 10 Nov 2017 17:39:35 -0800 [thread overview]
Message-ID: <87po8pzj8o.fsf@ericabrahamsen.net> (raw)
In-Reply-To: <jwv7ev05syn.fsf-monnier+Inbox@gnu.org> (Stefan Monnier's message of "Wed, 08 Nov 2017 17:05:45 -0500")
On 11/08/17 17:05 PM, Stefan Monnier wrote:
>>> AFAIK names are deprecated in calls to EIEIO constructors since
>>> Emacs-25 (rather 24.4), and it's only since Emacs-26 that they are
>>> optional in "eieio-presistent" written representations.
>> Okay I see, I got a little confused there. I checked the emacs 25 branch
>> and it ignores an object name string (emacs 24 requires it), so maybe
>> the only important thing is to say:
>> "Note that prior to Emacs version 25 the object name is required."
>
> I think the only important part is that Emacs<26 requires it (tho only
> Emacs<25 makes actual use of it, and even then, this use is mostly
> irrelevant, except maybe in corner cases in the course of debugging).
Okay, there it goes, with a modified docstring. Tests are passing here;
if no one complains in the next couple days, I'll close this bug report.
Eric
next prev parent reply other threads:[~2017-11-11 1:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-24 21:11 bug#28587: 26.0.60; Don't write object name strings in object-write method Eric Abrahamsen
2017-10-22 3:29 ` Stefan Monnier
2017-11-08 20:01 ` Eric Abrahamsen
2017-11-08 20:31 ` Stefan Monnier
2017-11-08 21:01 ` Eric Abrahamsen
2017-11-08 22:05 ` Stefan Monnier
2017-11-08 22:08 ` Eric Abrahamsen
2017-11-11 1:39 ` Eric Abrahamsen [this message]
2017-11-22 22:30 ` Eric Abrahamsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87po8pzj8o.fsf@ericabrahamsen.net \
--to=eric@ericabrahamsen.net \
--cc=28587@debbugs.gnu.org \
--cc=monnier@IRO.UMontreal.CA \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).