From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.bugs Subject: bug#21559: 25.0.50; auto-revert-mode breaks git rebase Date: Tue, 20 Feb 2018 12:53:40 +0100 Message-ID: <87po4z512z.fsf@gmx.de> References: <5d7808ef-d61f-534d-53b3-bc1227b4c3b1@yandex.ru> <87fu5w2jnh.fsf@gmx.de> <40817863-9c34-9745-6fff-4357d623de20@yandex.ru> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1519127533 1848 195.159.176.226 (20 Feb 2018 11:52:13 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 20 Feb 2018 11:52:13 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.91 (gnu/linux) Cc: 21559@debbugs.gnu.org, Alexei Khlebnikov To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Feb 20 12:52:08 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eo6Su-0008WR-89 for geb-bug-gnu-emacs@m.gmane.org; Tue, 20 Feb 2018 12:52:08 +0100 Original-Received: from localhost ([::1]:54835 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eo6Uw-0006GF-BJ for geb-bug-gnu-emacs@m.gmane.org; Tue, 20 Feb 2018 06:54:14 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:46101) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eo6Un-0006G4-Gv for bug-gnu-emacs@gnu.org; Tue, 20 Feb 2018 06:54:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eo6Uk-0000f0-FM for bug-gnu-emacs@gnu.org; Tue, 20 Feb 2018 06:54:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:44299) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eo6Uk-0000et-C5 for bug-gnu-emacs@gnu.org; Tue, 20 Feb 2018 06:54:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eo6Uk-0002gn-5M for bug-gnu-emacs@gnu.org; Tue, 20 Feb 2018 06:54:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 20 Feb 2018 11:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21559 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 21559-submit@debbugs.gnu.org id=B21559.151912762910311 (code B ref 21559); Tue, 20 Feb 2018 11:54:02 +0000 Original-Received: (at 21559) by debbugs.gnu.org; 20 Feb 2018 11:53:49 +0000 Original-Received: from localhost ([127.0.0.1]:52196 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eo6UX-0002gE-41 for submit@debbugs.gnu.org; Tue, 20 Feb 2018 06:53:49 -0500 Original-Received: from mout.gmx.net ([212.227.15.15]:33425) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eo6UV-0002fu-TY for 21559@debbugs.gnu.org; Tue, 20 Feb 2018 06:53:48 -0500 Original-Received: from detlef.gmx.de ([212.86.54.29]) by mail.gmx.com (mrgmx001 [212.227.17.190]) with ESMTPSA (Nemesis) id 0MgbTj-1f9ubK2aFr-00Nxd4; Tue, 20 Feb 2018 12:53:41 +0100 In-Reply-To: <40817863-9c34-9745-6fff-4357d623de20@yandex.ru> (Dmitry Gutov's message of "Tue, 20 Feb 2018 13:37:18 +0200") X-Provags-ID: V03:K0:miskIA10IBJ8TXJSJK/qOUZEFNllttaKFZvvRed6XDk9e0tu4wp O+dHGlzm0dNJeVd2ZZG/MyvVVHUP9r0h/QbqUy/xHw9Btx36kcAfodcfGcljNS2cgqBifwy 25aTqx7mJYJ7W1J9ZYtxFtR33DBxDZb/rhr962BkoXnJfe4zXGJO+qOm7PgVHMGZcznvBDf vYRwS1OtfjHNkTQzwNrog== X-UI-Out-Filterresults: notjunk:1;V01:K0:5ySo6EdrElo=:1RRmEA6e2/eK1JmyNpmcr1 wvIh6ylLyTvMi0W9vvVyrqb9UKr+TDFMgf7Sy8rZp//OIrrKtRj2ezHAyRHao2Z30/5bQK/cO lqq5WovrcpH1rE+idyWXYStqq3rDBu/992UaBrsd2hEpSzEXlZj5wA7DmP75F0OGRD+9TQPgf yMZ++WypB5hrs/C3wZJMsvg3AH0lyHa9Pi2h3QPQzt//WuONyCqNTMoMJOP2+s0RecjhERWuq XpGxpBfGylqLAsk2cVsCIIc8itoX3+RXY+L6Pr+jeIaeakYgTHNjQ51W2+zPYuDLAkUQh8kZS jskZSZUO1FIiCgTv9UW3tvp34WHRIqaEe3FdsfjlwIUb4qvsLML3T7FhB23ZUkFqNlHm6X/LM Lpyj/dcU09x92NgfN28IHMGNxWC1tV7RNFKUk8Xvo8iJcwZYw9RdO2+OSH/TWzlc8UgeW6jcR izJCOXO68DVCHoeB4cMX57/9o2dhEtLE81nmIJPmPtlAofLwnN8mkFIpK8Q81PPUt8jLAK0Ax DWF2eYu4vaTZY04XuXmw3KhObbRATbmStOwF65OcPZBk5n29ZMF+5bTbAURv4jln7ySxlyuBb ST9LUNZJhFLjRAXf5LwkR7/4ne8zUa0868qY+UlFA7GegAUfizPILUoZVowfToYj5lEjAmBZE cMyyDlCKatbl2OnrKXDngV0MZqVEtS9XRB0xJg5ybbjqJz924XG++Q5+AuO+bZJuh88O/6LZG 2IXM/rpXBvua20GUue77y9ew0X2zKK1/53yy1EhGgWzGMxl4q4zuofRcwCuFC3BR/yzmi5AC X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:143488 Archived-At: Dmitry Gutov writes: Hi Dmitry, >> I'm not so happy seeing git specific code in autorevert.el (yes, I know, >> it's just an environment variable). All git specifics shall be kept in >> vc-git.el. Otherwise, we would go into a dependency nightmare, soon. > > But this way the patch is much smaller, isn't it? That has > maintainability benefits too. A dependency nightmare counts much more, IMHO. > And using a variable would make more sense if we determine that other > facilities, not just autorevert, make VC calls that we want to > consider "background". autorevert wouldn't care who uses this variable. In a broader sense, it could let-bind it for the whole auto-revert-handler body. >> If this variable hurts for standard operation of vc-git, we could set it >> depending whether (auto)revert is running, or not. There is the variable >> `revert-buffer-in-progress-p', which is non-nil if reverting is in >> progress. I could set it also before calling `vc-refresh-state' in >> `auto-revert-handler'. And in vc-git.el, `process-environment' could be >> extended or not, depending on the value of `revert-buffer-in-progress-p'. > > In which part of vc-git.el? Changing the implementation of two > commands, like the original patch proposed, makes for a bigger change. > > We could do that in vc-git-command, I suppose... Perhaps. autorevert shouldn't know anything about vc-git, it should just let-bind the variable, and let other packages decide whether they use it. FWIW, I'm also not so enthusiastic, that aut-revert-handler calls vc-refresh-state directly. This would be better organized by a hook. Best regards, Michael.