From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#20489: 25.0.50; next-error-find-buffer chooses non-current buffer without good reason Date: Fri, 02 Mar 2018 00:58:10 +0200 Organization: LINKOV.NET Message-ID: <87po4ne72v.fsf@mail.linkov.net> References: <86wq0q602w.fsf@yandex.ru> <877ev36pmr.fsf@mail.linkov.net> <87sha1nbjy.fsf@mail.linkov.net> <23fd061a-9b83-742a-6083-6d2f090b8f22@yandex.ru> <81d36dbe-f563-187a-ec16-df4b051ae204@yandex.ru> <87efl6smxb.fsf@mail.linkov.net> <87efl46c41.fsf@mail.linkov.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1519945574 23988 195.159.176.226 (1 Mar 2018 23:06:14 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 1 Mar 2018 23:06:14 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) Cc: 20489@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Mar 02 00:06:09 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1erXH7-0005sh-EJ for geb-bug-gnu-emacs@m.gmane.org; Fri, 02 Mar 2018 00:06:09 +0100 Original-Received: from localhost ([::1]:59699 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1erXJ9-0001mX-Mf for geb-bug-gnu-emacs@m.gmane.org; Thu, 01 Mar 2018 18:08:15 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:39847) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1erXJ0-0001l1-31 for bug-gnu-emacs@gnu.org; Thu, 01 Mar 2018 18:08:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1erXIw-0006Td-2d for bug-gnu-emacs@gnu.org; Thu, 01 Mar 2018 18:08:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:60180) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1erXIv-0006TQ-UH for bug-gnu-emacs@gnu.org; Thu, 01 Mar 2018 18:08:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1erXIv-0004F0-Kn for bug-gnu-emacs@gnu.org; Thu, 01 Mar 2018 18:08:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 01 Mar 2018 23:08:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20489 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 20489-submit@debbugs.gnu.org id=B20489.151994565816258 (code B ref 20489); Thu, 01 Mar 2018 23:08:01 +0000 Original-Received: (at 20489) by debbugs.gnu.org; 1 Mar 2018 23:07:38 +0000 Original-Received: from localhost ([127.0.0.1]:39840 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1erXIY-0004E9-72 for submit@debbugs.gnu.org; Thu, 01 Mar 2018 18:07:38 -0500 Original-Received: from sub3.mail.dreamhost.com ([69.163.253.7]:48326 helo=homiemail-a18.g.dreamhost.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1erXIW-0004E2-Gg for 20489@debbugs.gnu.org; Thu, 01 Mar 2018 18:07:36 -0500 Original-Received: from homiemail-a18.g.dreamhost.com (localhost [127.0.0.1]) by homiemail-a18.g.dreamhost.com (Postfix) with ESMTP id A4814258067; Thu, 1 Mar 2018 15:07:35 -0800 (PST) Original-Received: from localhost.linkov.net (m91-129-98-215.cust.tele2.ee [91.129.98.215]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by homiemail-a18.g.dreamhost.com (Postfix) with ESMTPSA id BEDDD258066; Thu, 1 Mar 2018 15:07:34 -0800 (PST) In-Reply-To: <87efl46c41.fsf@mail.linkov.net> (Juri Linkov's message of "Wed, 28 Feb 2018 23:25:02 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:143809 Archived-At: > But this requires a feature that is not yet implemented, namely > a customization like =E2=80=98display-buffer-from-alist=E2=80=99 to mat= ch the source > buffer name (that was the current buffer before navigation) instead > of the target buffer (the buffer to display) like =E2=80=98display-buff= er-alist=E2=80=99 > currently specifies. Actually no new feature is needed, =E2=80=98display-buffer-alist=E2=80=99= is powerful enough, and this can be easily implemented with a few lines of code: 1. next-error for *xref* to reuse the same window: (push '(display-buffer-condition-next-error display-buffer-same-window) display-buffer-alist) (defun display-buffer-condition-next-error (_buffer-name _action) (memq this-command '(next-error previous-error))) 2. with e.g. two *grep* windows, typing RET to select the right locus win= dow: (push '(display-buffer-condition-from-next-error-buffer display-buffer-in-next-error-last-window (inhibit-same-window . t)) display-buffer-alist) (defun display-buffer-condition-from-next-error-buffer (_buffer-name _act= ion) (string-match-p "\\`\\*\\(compilation\\|grep\\|Occur\\)\\*\\(\\|<[0-9]+= >\\)\\'" (buffer-name (current-buffer)))) (defun display-buffer-in-next-error-last-window (buffer alist) "Return a window used to display the last next-error buffer." (let* ((window (car (delq nil (mapcar (lambda (w) (when (and (local-variable-p 'next-error-la= st-buffer (window-buffer= w)) (eq (current-buffer) (buffer-local-value 'next-error-last-buffer (window-buffer w)))) w)) (window-list-1 nil 'nomini)))))) (when (window-live-p window) window (prog1 (window--display-buffer buffer window 'reuse alist) (unless (cdr (assq 'inhibit-switch-frame alist)) (window--maybe-raise-frame (window-frame window)))))))