* bug#30900: 26.0.91; auth-source-pass-enable results in customization type mismatch for auth-sources
@ 2018-03-21 22:32 Alex Branham
2018-03-21 23:52 ` Glenn Morris
0 siblings, 1 reply; 16+ messages in thread
From: Alex Branham @ 2018-03-21 22:32 UTC (permalink / raw)
To: 30900
Using the new (26.0.91) auth-source-pass-enable function modifies the
auth-sources variable to something isn't specified in :type, resulting
in a type mismatch when looking at the customize-variable buffer for
auth-sources.
Alex
^ permalink raw reply [flat|nested] 16+ messages in thread
* bug#30900: 26.0.91; auth-source-pass-enable results in customization type mismatch for auth-sources
2018-03-21 22:32 bug#30900: 26.0.91; auth-source-pass-enable results in customization type mismatch for auth-sources Alex Branham
@ 2018-03-21 23:52 ` Glenn Morris
2018-03-22 7:36 ` Eli Zaretskii
0 siblings, 1 reply; 16+ messages in thread
From: Glenn Morris @ 2018-03-21 23:52 UTC (permalink / raw)
To: Alex Branham; +Cc: 30900
Alex Branham wrote:
> Using the new (26.0.91) auth-source-pass-enable function modifies the
> auth-sources variable to something isn't specified in :type, resulting
> in a type mismatch when looking at the customize-variable buffer for
> auth-sources.
Presumably this auth-sources setting also doesn't work in the next Emacs
instance, unless one manually loads the auth-source-pass library?
Also, there doesn't seem to be any NEWS entry about auth-source-pass.el.
^ permalink raw reply [flat|nested] 16+ messages in thread
* bug#30900: 26.0.91; auth-source-pass-enable results in customization type mismatch for auth-sources
2018-03-21 23:52 ` Glenn Morris
@ 2018-03-22 7:36 ` Eli Zaretskii
2018-03-22 10:12 ` Nicolas Petton
2018-03-23 8:39 ` Damien Cassou
0 siblings, 2 replies; 16+ messages in thread
From: Eli Zaretskii @ 2018-03-22 7:36 UTC (permalink / raw)
To: Damien Cassou, Nicolas Petton; +Cc: alex.branham, 30900
> From: Glenn Morris <rgm@gnu.org>
> Date: Wed, 21 Mar 2018 19:52:26 -0400
> Cc: 30900@debbugs.gnu.org
>
> Alex Branham wrote:
>
> > Using the new (26.0.91) auth-source-pass-enable function modifies the
> > auth-sources variable to something isn't specified in :type, resulting
> > in a type mismatch when looking at the customize-variable buffer for
> > auth-sources.
>
> Presumably this auth-sources setting also doesn't work in the next Emacs
> instance, unless one manually loads the auth-source-pass library?
>
> Also, there doesn't seem to be any NEWS entry about auth-source-pass.el.
Damien, Nicolas: could you please look into fixing these issues ASAP?
We are about to make RC1 of Emacs 26.1 very soon.
Thanks.
^ permalink raw reply [flat|nested] 16+ messages in thread
* bug#30900: 26.0.91; auth-source-pass-enable results in customization type mismatch for auth-sources
2018-03-22 7:36 ` Eli Zaretskii
@ 2018-03-22 10:12 ` Nicolas Petton
2018-03-23 8:39 ` Damien Cassou
1 sibling, 0 replies; 16+ messages in thread
From: Nicolas Petton @ 2018-03-22 10:12 UTC (permalink / raw)
To: Eli Zaretskii, Damien Cassou; +Cc: alex.branham, 30900
[-- Attachment #1: Type: text/plain, Size: 191 bytes --]
Eli Zaretskii <eliz@gnu.org> writes:
> Damien, Nicolas: could you please look into fixing these issues ASAP?
> We are about to make RC1 of Emacs 26.1 very soon.
Yes, we will.
Cheers,
Nico
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]
^ permalink raw reply [flat|nested] 16+ messages in thread
* bug#30900: 26.0.91; auth-source-pass-enable results in customization type mismatch for auth-sources
2018-03-22 7:36 ` Eli Zaretskii
2018-03-22 10:12 ` Nicolas Petton
@ 2018-03-23 8:39 ` Damien Cassou
2018-04-01 9:11 ` Eli Zaretskii
2018-04-02 12:56 ` Ted Zlatanov
1 sibling, 2 replies; 16+ messages in thread
From: Damien Cassou @ 2018-03-23 8:39 UTC (permalink / raw)
To: Eli Zaretskii, Nicolas Petton; +Cc: Ted Zlatanov, alex.branham, 30900
Eli Zaretskii <eliz@gnu.org> writes:
>> > Using the new (26.0.91) auth-source-pass-enable function modifies the
>> > auth-sources variable to something isn't specified in :type, resulting
>> > in a type mismatch when looking at the customize-variable buffer for
>> > auth-sources.
>>
>> Presumably this auth-sources setting also doesn't work in the next Emacs
>> instance, unless one manually loads the auth-source-pass library?
I think we should sync with Ted, in CC, so that auth-sources
customization type allows external providers. What do you think Ted?
--
Damien Cassou
http://damiencassou.seasidehosting.st
"Success is the ability to go from one failure to another without
losing enthusiasm." --Winston Churchill
^ permalink raw reply [flat|nested] 16+ messages in thread
* bug#30900: 26.0.91; auth-source-pass-enable results in customization type mismatch for auth-sources
2018-03-23 8:39 ` Damien Cassou
@ 2018-04-01 9:11 ` Eli Zaretskii
2018-04-02 12:56 ` Ted Zlatanov
1 sibling, 0 replies; 16+ messages in thread
From: Eli Zaretskii @ 2018-04-01 9:11 UTC (permalink / raw)
To: Damien Cassou; +Cc: alex.branham, tzz, nicolas, 30900
Ping!
> From: Damien Cassou <damien@cassou.me>
> Cc: Glenn Morris <rgm@gnu.org>, alex.branham@gmail.com, 30900@debbugs.gnu.org, Ted Zlatanov <tzz@lifelogs.com>
> Date: Fri, 23 Mar 2018 09:39:25 +0100
>
> Eli Zaretskii <eliz@gnu.org> writes:
> >> > Using the new (26.0.91) auth-source-pass-enable function modifies the
> >> > auth-sources variable to something isn't specified in :type, resulting
> >> > in a type mismatch when looking at the customize-variable buffer for
> >> > auth-sources.
> >>
> >> Presumably this auth-sources setting also doesn't work in the next Emacs
> >> instance, unless one manually loads the auth-source-pass library?
>
> I think we should sync with Ted, in CC, so that auth-sources
> customization type allows external providers. What do you think Ted?
^ permalink raw reply [flat|nested] 16+ messages in thread
* bug#30900: 26.0.91; auth-source-pass-enable results in customization type mismatch for auth-sources
2018-03-23 8:39 ` Damien Cassou
2018-04-01 9:11 ` Eli Zaretskii
@ 2018-04-02 12:56 ` Ted Zlatanov
2018-04-03 13:34 ` Damien Cassou
1 sibling, 1 reply; 16+ messages in thread
From: Ted Zlatanov @ 2018-04-02 12:56 UTC (permalink / raw)
To: Damien Cassou; +Cc: alex.branham, Nicolas Petton, 30900
On Fri, 23 Mar 2018 09:39:25 +0100 Damien Cassou <damien@cassou.me> wrote:
DC> Eli Zaretskii <eliz@gnu.org> writes:
>>> > Using the new (26.0.91) auth-source-pass-enable function modifies the
>>> > auth-sources variable to something isn't specified in :type, resulting
>>> > in a type mismatch when looking at the customize-variable buffer for
>>> > auth-sources.
>>>
>>> Presumably this auth-sources setting also doesn't work in the next Emacs
>>> instance, unless one manually loads the auth-source-pass library?
DC> I think we should sync with Ted, in CC, so that auth-sources
DC> customization type allows external providers. What do you think Ted?
IIUC, we have external providers for the auth-source backends but the
customization types of `auth-sources' are not extensible by the
providers.
I can think of two approaches. We can either allow a typeless
configuration (in addition to the built-ins) to make it easier to
customize any way the user wants, or we can make the :type extensible.
I'm not sure if there's a standard way of doing this in Emacs but if
there is, I'd use it. If not, the typeless approach is probably easier
to support and less surprising.
Ted
^ permalink raw reply [flat|nested] 16+ messages in thread
* bug#30900: 26.0.91; auth-source-pass-enable results in customization type mismatch for auth-sources
2018-04-02 12:56 ` Ted Zlatanov
@ 2018-04-03 13:34 ` Damien Cassou
2018-04-04 18:16 ` Ted Zlatanov
0 siblings, 1 reply; 16+ messages in thread
From: Damien Cassou @ 2018-04-03 13:34 UTC (permalink / raw)
To: Ted Zlatanov; +Cc: alex.branham, Nicolas Petton, 30900
Ted Zlatanov <tzz@lifelogs.com> writes:
> IIUC, we have external providers for the auth-source backends but the
> customization types of `auth-sources' are not extensible by the
> providers.
yes
> I can think of two approaches. We can either allow a typeless
> configuration (in addition to the built-ins) to make it easier to
> customize any way the user wants
this should work and is probably the simplest.
--
Damien Cassou
http://damiencassou.seasidehosting.st
"Success is the ability to go from one failure to another without
losing enthusiasm." --Winston Churchill
^ permalink raw reply [flat|nested] 16+ messages in thread
* bug#30900: 26.0.91; auth-source-pass-enable results in customization type mismatch for auth-sources
2018-04-03 13:34 ` Damien Cassou
@ 2018-04-04 18:16 ` Ted Zlatanov
2018-04-04 19:17 ` Eli Zaretskii
0 siblings, 1 reply; 16+ messages in thread
From: Ted Zlatanov @ 2018-04-04 18:16 UTC (permalink / raw)
To: Damien Cassou; +Cc: alex.branham, Nicolas Petton, 30900
On Tue, 03 Apr 2018 15:34:15 +0200 Damien Cassou <damien@cassou.me> wrote:
DC> Ted Zlatanov <tzz@lifelogs.com> writes:
>> IIUC, we have external providers for the auth-source backends but the
>> customization types of `auth-sources' are not extensible by the
>> providers.
DC> yes
>> I can think of two approaches. We can either allow a typeless
>> configuration (in addition to the built-ins) to make it easier to
>> customize any way the user wants
DC> this should work and is probably the simplest.
OK. Since there were no objections:
commit 447da5b0d49b7aa14fa5d6969015770fdf9b9f92
Author: Ted Zlatanov <tzz@lifelogs.com>
* lisp/auth-source.el (auth-sources): Allow sexp customization type
HTH
Ted
^ permalink raw reply [flat|nested] 16+ messages in thread* bug#30900: 26.0.91; auth-source-pass-enable results in customization type mismatch for auth-sources
2018-04-04 18:16 ` Ted Zlatanov
@ 2018-04-04 19:17 ` Eli Zaretskii
2018-04-04 21:32 ` Ted Zlatanov
2018-04-05 10:03 ` Glenn Morris
0 siblings, 2 replies; 16+ messages in thread
From: Eli Zaretskii @ 2018-04-04 19:17 UTC (permalink / raw)
To: Ted Zlatanov; +Cc: damien, nicolas, alex.branham, 30900-done
> From: Ted Zlatanov <tzz@lifelogs.com>
> Cc: Eli Zaretskii <eliz@gnu.org>, Nicolas Petton <nicolas@petton.fr>, Glenn Morris <rgm@gnu.org>, alex.branham@gmail.com, 30900@debbugs.gnu.org
> Date: Wed, 04 Apr 2018 14:16:19 -0400
>
> OK. Since there were no objections:
>
> commit 447da5b0d49b7aa14fa5d6969015770fdf9b9f92
> Author: Ted Zlatanov <tzz@lifelogs.com>
>
> * lisp/auth-source.el (auth-sources): Allow sexp customization type
Thanks, but that should have been done on the release branch, and the
:version tag should have been updated. I fixed that.
^ permalink raw reply [flat|nested] 16+ messages in thread
* bug#30900: 26.0.91; auth-source-pass-enable results in customization type mismatch for auth-sources
2018-04-04 19:17 ` Eli Zaretskii
@ 2018-04-04 21:32 ` Ted Zlatanov
2018-04-04 22:00 ` Glenn Morris
2018-04-05 6:06 ` Eli Zaretskii
2018-04-05 10:03 ` Glenn Morris
1 sibling, 2 replies; 16+ messages in thread
From: Ted Zlatanov @ 2018-04-04 21:32 UTC (permalink / raw)
To: 30900; +Cc: alex.branham
On Wed, 04 Apr 2018 22:17:31 +0300 Eli Zaretskii <eliz@gnu.org> wrote:
>> From: Ted Zlatanov <tzz@lifelogs.com>
>> Cc: Eli Zaretskii <eliz@gnu.org>, Nicolas Petton <nicolas@petton.fr>, Glenn Morris <rgm@gnu.org>, alex.branham@gmail.com, 30900@debbugs.gnu.org
>> Date: Wed, 04 Apr 2018 14:16:19 -0400
>>
>> OK. Since there were no objections:
>>
>> commit 447da5b0d49b7aa14fa5d6969015770fdf9b9f92
>> Author: Ted Zlatanov <tzz@lifelogs.com>
>>
>> * lisp/auth-source.el (auth-sources): Allow sexp customization type
EZ> Thanks, but that should have been done on the release branch, and the
EZ> :version tag should have been updated. I fixed that.
Thank you for your kind help. Does that close the issue?
Ted
^ permalink raw reply [flat|nested] 16+ messages in thread
* bug#30900: 26.0.91; auth-source-pass-enable results in customization type mismatch for auth-sources
2018-04-04 21:32 ` Ted Zlatanov
@ 2018-04-04 22:00 ` Glenn Morris
2022-04-17 10:39 ` Lars Ingebrigtsen
2018-04-05 6:06 ` Eli Zaretskii
1 sibling, 1 reply; 16+ messages in thread
From: Glenn Morris @ 2018-04-04 22:00 UTC (permalink / raw)
To: 30900; +Cc: alex.branham
Ted Zlatanov wrote:
> Thank you for your kind help. Does that close the issue?
Changing the :type doesn't help with this:
Presumably this auth-sources setting also doesn't work in the next Emacs
instance, unless one manually loads the auth-source-pass library?
Ie the procedure documented in the manual doesn't suffice:
(setq auth-sources '(password-store))
because auth-source won't know how to handle that mechanism, or any
other external one.
^ permalink raw reply [flat|nested] 16+ messages in thread
* bug#30900: 26.0.91; auth-source-pass-enable results in customization type mismatch for auth-sources
2018-04-04 22:00 ` Glenn Morris
@ 2022-04-17 10:39 ` Lars Ingebrigtsen
0 siblings, 0 replies; 16+ messages in thread
From: Lars Ingebrigtsen @ 2022-04-17 10:39 UTC (permalink / raw)
To: Glenn Morris; +Cc: alex.branham, 30900
Glenn Morris <rgm@gnu.org> writes:
> Changing the :type doesn't help with this:
>
> Presumably this auth-sources setting also doesn't work in the next Emacs
> instance, unless one manually loads the auth-source-pass library?
>
> Ie the procedure documented in the manual doesn't suffice:
>
> (setq auth-sources '(password-store))
>
> because auth-source won't know how to handle that mechanism, or any
> other external one.
I've now updated the manual to refer to the correct function.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 16+ messages in thread
* bug#30900: 26.0.91; auth-source-pass-enable results in customization type mismatch for auth-sources
2018-04-04 21:32 ` Ted Zlatanov
2018-04-04 22:00 ` Glenn Morris
@ 2018-04-05 6:06 ` Eli Zaretskii
1 sibling, 0 replies; 16+ messages in thread
From: Eli Zaretskii @ 2018-04-05 6:06 UTC (permalink / raw)
To: Ted Zlatanov; +Cc: alex.branham, 30900
> From: Ted Zlatanov <tzz@lifelogs.com>
> Cc: eliz@gnu.org, alex.branham@gmail.com
> Date: Wed, 04 Apr 2018 17:32:21 -0400
>
> EZ> Thanks, but that should have been done on the release branch, and the
> EZ> :version tag should have been updated. I fixed that.
>
> Thank you for your kind help. Does that close the issue?
Sounds like it doesn't, see Glenn's followup.
^ permalink raw reply [flat|nested] 16+ messages in thread
* bug#30900: 26.0.91; auth-source-pass-enable results in customization type mismatch for auth-sources
2018-04-04 19:17 ` Eli Zaretskii
2018-04-04 21:32 ` Ted Zlatanov
@ 2018-04-05 10:03 ` Glenn Morris
2018-04-05 10:21 ` Eli Zaretskii
1 sibling, 1 reply; 16+ messages in thread
From: Glenn Morris @ 2018-04-05 10:03 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: damien, Ted Zlatanov, alex.branham, nicolas, 30900-done
Eli Zaretskii wrote:
> :version tag should have been updated. I fixed that.
It's not new, nor has the default value changed, so I don't see why
:version should be changed. Anyway, the "No Gnus" comment is now incorrect.
^ permalink raw reply [flat|nested] 16+ messages in thread
* bug#30900: 26.0.91; auth-source-pass-enable results in customization type mismatch for auth-sources
2018-04-05 10:03 ` Glenn Morris
@ 2018-04-05 10:21 ` Eli Zaretskii
0 siblings, 0 replies; 16+ messages in thread
From: Eli Zaretskii @ 2018-04-05 10:21 UTC (permalink / raw)
To: Glenn Morris; +Cc: damien, tzz, nicolas, 30900, alex.branham
> From: Glenn Morris <rgm@gnu.org>
> Cc: Ted Zlatanov <tzz@lifelogs.com>, damien@cassou.me, nicolas@petton.fr, alex.branham@gmail.com, 30900-done@debbugs.gnu.org
> Date: Thu, 05 Apr 2018 06:03:24 -0400
>
> Eli Zaretskii wrote:
>
> > :version tag should have been updated. I fixed that.
>
> It's not new, nor has the default value changed, so I don't see why
> :version should be changed.
It depends on the POV, I guess. I thought it should change.
> Anyway, the "No Gnus" comment is now incorrect.
Feel free to fix that, and thanks.
^ permalink raw reply [flat|nested] 16+ messages in thread
end of thread, other threads:[~2022-04-17 10:39 UTC | newest]
Thread overview: 16+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-03-21 22:32 bug#30900: 26.0.91; auth-source-pass-enable results in customization type mismatch for auth-sources Alex Branham
2018-03-21 23:52 ` Glenn Morris
2018-03-22 7:36 ` Eli Zaretskii
2018-03-22 10:12 ` Nicolas Petton
2018-03-23 8:39 ` Damien Cassou
2018-04-01 9:11 ` Eli Zaretskii
2018-04-02 12:56 ` Ted Zlatanov
2018-04-03 13:34 ` Damien Cassou
2018-04-04 18:16 ` Ted Zlatanov
2018-04-04 19:17 ` Eli Zaretskii
2018-04-04 21:32 ` Ted Zlatanov
2018-04-04 22:00 ` Glenn Morris
2022-04-17 10:39 ` Lars Ingebrigtsen
2018-04-05 6:06 ` Eli Zaretskii
2018-04-05 10:03 ` Glenn Morris
2018-04-05 10:21 ` Eli Zaretskii
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).