From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#31557: 27.0.50; SES hangs on save when 'delete-trailing-whitespace' is in 'before-save-hook' Date: Sun, 03 Jun 2018 12:05:34 -0400 Message-ID: <87po1797ox.fsf@gmail.com> References: <83muwbdge6.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1528041847 9379 195.159.176.226 (3 Jun 2018 16:04:07 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 3 Jun 2018 16:04:07 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) Cc: Filipp Gunbin , 31557@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Jun 03 18:04:03 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fPVUA-0002Ls-SJ for geb-bug-gnu-emacs@m.gmane.org; Sun, 03 Jun 2018 18:04:03 +0200 Original-Received: from localhost ([::1]:35828 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fPVWI-00088O-3j for geb-bug-gnu-emacs@m.gmane.org; Sun, 03 Jun 2018 12:06:14 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37867) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fPVWB-00088J-RQ for bug-gnu-emacs@gnu.org; Sun, 03 Jun 2018 12:06:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fPVW6-0004nh-SC for bug-gnu-emacs@gnu.org; Sun, 03 Jun 2018 12:06:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:52553) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fPVW6-0004nS-O0 for bug-gnu-emacs@gnu.org; Sun, 03 Jun 2018 12:06:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fPVW6-0001Dl-85 for bug-gnu-emacs@gnu.org; Sun, 03 Jun 2018 12:06:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 03 Jun 2018 16:06:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31557 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 31557-submit@debbugs.gnu.org id=B31557.15280419464663 (code B ref 31557); Sun, 03 Jun 2018 16:06:02 +0000 Original-Received: (at 31557) by debbugs.gnu.org; 3 Jun 2018 16:05:46 +0000 Original-Received: from localhost ([127.0.0.1]:60450 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fPVVq-0001D9-6L for submit@debbugs.gnu.org; Sun, 03 Jun 2018 12:05:46 -0400 Original-Received: from mail-it0-f43.google.com ([209.85.214.43]:38576) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fPVVl-0001Cs-Ue for 31557@debbugs.gnu.org; Sun, 03 Jun 2018 12:05:42 -0400 Original-Received: by mail-it0-f43.google.com with SMTP id v83-v6so7358498itc.3 for <31557@debbugs.gnu.org>; Sun, 03 Jun 2018 09:05:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=g9JcgCSaDnJW1yTf2cuZc5w/Xvj9QcK52VBBIrrFHqI=; b=ZKuT4ajKEcVMwpcfolZVElZes7zxNpZWEtfQqAH0U6d82thbx/Nqg7HdjS7clNbzIx 6b0KFVMsKeD7QWifAEO2aFFRmuEbTNk8ZolpEfFlF91f614U81iUQhc7dj+HIp1AtBN1 H+FFoIzTDYVDp/P8JIpwrwO5I9Rx6T2r4ZCi/leEUK7cqQOpHILKfpDCiLc8q60cjHa4 uyk8exxqKRUfTB+bjp9RVAkTsURI7p+SsX7NeRxYbAzGYNhn9B9z0AwT0FP3+ylP0w+X 2YF85/WHtGhD1IqDAMTPAiRGYOjYEccxMXG0BOSGsetwCCRf/zu+pbgPoGeLaAIggdHO /CSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=g9JcgCSaDnJW1yTf2cuZc5w/Xvj9QcK52VBBIrrFHqI=; b=I89Gynl5LQArzw99i51bQWuEZ3c4BY4kGa76B/9FqsnKr3/QQEo8WctYchuu6A+2hV d3/wgAAbGavTo96YW8LGOSk5Jqn3iSK5WSOpsN39p1Mbe2qBVXPLxNmMVlLdFwExGNl5 sus0yARWhrTzay38yD3ZW1XomEgYboRynwYyzQQONjZlRXzOot61SBsDUA0Bl5/Q6hIa TmnMwi9JuUyjghcMAAJVzYYWQKLYK7/Y4+b6sj5edS3LD0N7XwsBuqzw8wxVnrhc8YrM 97Xo3QL7ylPaL9J4dy0TgI3EygdMt6YuO/o5L2S+FxBfz4e4ExGQtCqyzxDp590hU8yt 6Psw== X-Gm-Message-State: ALKqPwc21R5l7kDsFP2jBQzuRGN/76azMG+m5r9ypoKzix3kUlfxkRkP +X7B5drWHkanflsmw3c/bXHSwQ== X-Google-Smtp-Source: ADUXVKLaKWJ81FiikpwBgoYzq5gEWvOXDwYKbdVszFRpcKnTbxqs737QHioANuSUx7OUHkLFIahj+A== X-Received: by 2002:a24:490:: with SMTP id 138-v6mr12084281itb.95.1528041936411; Sun, 03 Jun 2018 09:05:36 -0700 (PDT) Original-Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id g6-v6sm3072424iti.0.2018.06.03.09.05.35 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 03 Jun 2018 09:05:35 -0700 (PDT) In-Reply-To: <83muwbdge6.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 03 Jun 2018 18:44:01 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:146912 Archived-At: Eli Zaretskii writes: > If my reading of the code is correct, it should infloop for every use > case where region-modifiable-p returns nil. Yes, agreed. > Does the patch below look right? > > --- lisp/simple.el~0 2018-03-14 06:40:04.000000000 +0200 > +++ lisp/simple.el 2018-06-03 17:51:37.213490900 +0300 > @@ -667,8 +667,9 @@ > (while (re-search-forward "\\s-$" end-marker t) > (skip-syntax-backward "-" (line-beginning-position)) > (let ((b (point)) (e (match-end 0))) > - (when (region-modifiable-p b e) > - (delete-region b e))))) > + (if (region-modifiable-p b e) > + (delete-region b e) > + (goto-char e))))) Looks good to me.