From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#32475: 27.0.50; Multiple log-view-mode buffers Date: Mon, 20 Aug 2018 00:31:50 +0300 Organization: LINKOV.NET Message-ID: <87pnye9gpt.fsf@mail.linkov.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: blaine.gmane.org 1534715294 4107 195.159.176.226 (19 Aug 2018 21:48:14 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 19 Aug 2018 21:48:14 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) To: 32475@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Aug 19 23:48:10 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1frVYQ-0000wz-5E for geb-bug-gnu-emacs@m.gmane.org; Sun, 19 Aug 2018 23:48:10 +0200 Original-Received: from localhost ([::1]:44211 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1frVaW-0002bd-KX for geb-bug-gnu-emacs@m.gmane.org; Sun, 19 Aug 2018 17:50:20 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:35149) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1frVaG-0002Uj-Rw for bug-gnu-emacs@gnu.org; Sun, 19 Aug 2018 17:50:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1frVaG-0002Ky-4J for bug-gnu-emacs@gnu.org; Sun, 19 Aug 2018 17:50:04 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:49862) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1frVaG-0002Km-05 for bug-gnu-emacs@gnu.org; Sun, 19 Aug 2018 17:50:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1frVaF-0003zz-TS for bug-gnu-emacs@gnu.org; Sun, 19 Aug 2018 17:50:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 19 Aug 2018 21:50:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 32475 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.153471537215304 (code B ref -1); Sun, 19 Aug 2018 21:50:03 +0000 Original-Received: (at submit) by debbugs.gnu.org; 19 Aug 2018 21:49:32 +0000 Original-Received: from localhost ([127.0.0.1]:54878 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1frVZj-0003yi-QU for submit@debbugs.gnu.org; Sun, 19 Aug 2018 17:49:32 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:42137) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1frVZh-0003yN-KN for submit@debbugs.gnu.org; Sun, 19 Aug 2018 17:49:30 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1frVZb-00027n-SU for submit@debbugs.gnu.org; Sun, 19 Aug 2018 17:49:24 -0400 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:59283) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1frVZb-00027i-Pk for submit@debbugs.gnu.org; Sun, 19 Aug 2018 17:49:23 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:34885) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1frVZb-00023e-20 for bug-gnu-emacs@gnu.org; Sun, 19 Aug 2018 17:49:23 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1frVZa-00026k-3x for bug-gnu-emacs@gnu.org; Sun, 19 Aug 2018 17:49:23 -0400 Original-Received: from homie-sub3.mail.dreamhost.com ([69.163.253.7]:46242 helo=homiemail-a22.g.dreamhost.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1frVZZ-00026J-UO for bug-gnu-emacs@gnu.org; Sun, 19 Aug 2018 17:49:22 -0400 Original-Received: from homiemail-a22.g.dreamhost.com (localhost [127.0.0.1]) by homiemail-a22.g.dreamhost.com (Postfix) with ESMTP id DCD7F114066 for ; Sun, 19 Aug 2018 14:49:20 -0700 (PDT) Original-Received: from localhost.linkov.net (m91-129-110-6.cust.tele2.ee [91.129.110.6]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by homiemail-a22.g.dreamhost.com (Postfix) with ESMTPSA id 41977114065 for ; Sun, 19 Aug 2018 14:49:20 -0700 (PDT) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x (no timestamps) [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:149602 Archived-At: --=-=-= Content-Type: text/plain To support the ability to create multiple *vc-change-log* buffers with customization like (add-hook 'log-view-mode-hook 'rename-uniquely) vc-log-internal-common needs an improvement to remember and reuse the buffer object, instead of searching the same buffer by name: --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=vc-log-internal-common.1.patch diff --git a/lisp/vc/vc.el b/lisp/vc/vc.el index b2bedfae93..487594b2d5 100644 --- a/lisp/vc/vc.el +++ b/lisp/vc/vc.el @@ -2268,11 +2268,11 @@ vc-log-internal-common setup-buttons-func goto-location-func rev-buff-func) - (let (retval) - (with-current-buffer (get-buffer-create buffer-name) + (let (retval (buffer (get-buffer-create buffer-name))) + (with-current-buffer buffer (set (make-local-variable 'vc-log-view-type) type)) (setq retval (funcall backend-func backend buffer-name type files)) - (with-current-buffer (get-buffer buffer-name) + (with-current-buffer buffer (let ((inhibit-read-only t)) ;; log-view-mode used to be called with inhibit-read-only bound ;; to t, so let's keep doing it, just in case. @@ -2283,7 +2283,7 @@ vc-log-internal-common rev-buff-func))) ;; Display after setting up major-mode, so display-buffer-alist can know ;; the major-mode. - (pop-to-buffer buffer-name) + (pop-to-buffer buffer) (vc-run-delayed (let ((inhibit-read-only t)) (funcall setup-buttons-func backend files retval) --=-=-=--