From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#33870: 27.0.50; xref-goto-xref not configurable Date: Fri, 04 Jan 2019 02:07:10 +0200 Organization: LINKOV.NET Message-ID: <87pntdxp3l.fsf@mail.linkov.net> References: <87a7ktqqx7.fsf@mail.linkov.net> <9215183d-0a44-88b5-5b3c-d0da31f749ad@yandex.ru> <878t02egph.fsf@mail.linkov.net> <878t011lch.fsf@mail.linkov.net> <87va35z95v.fsf@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1546560914 26218 195.159.176.226 (4 Jan 2019 00:15:14 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 4 Jan 2019 00:15:14 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) Cc: 33870@debbugs.gnu.org, Dmitry Gutov To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Jan 04 01:15:10 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gfD8m-0006iJ-P1 for geb-bug-gnu-emacs@m.gmane.org; Fri, 04 Jan 2019 01:15:09 +0100 Original-Received: from localhost ([127.0.0.1]:58929 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gfDAt-0000sT-FG for geb-bug-gnu-emacs@m.gmane.org; Thu, 03 Jan 2019 19:17:19 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:46393) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gfDAf-0000s1-V0 for bug-gnu-emacs@gnu.org; Thu, 03 Jan 2019 19:17:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gfDAc-00036l-Qb for bug-gnu-emacs@gnu.org; Thu, 03 Jan 2019 19:17:05 -0500 Original-Received: from debbugsout.gnu.org ([209.51.188.43]:35268) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gfDAc-00034B-H2 for bug-gnu-emacs@gnu.org; Thu, 03 Jan 2019 19:17:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gfDAc-00075u-2q for bug-gnu-emacs@gnu.org; Thu, 03 Jan 2019 19:17:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 04 Jan 2019 00:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33870 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 33870-submit@debbugs.gnu.org id=B33870.154656101627240 (code B ref 33870); Fri, 04 Jan 2019 00:17:02 +0000 Original-Received: (at 33870) by debbugs.gnu.org; 4 Jan 2019 00:16:56 +0000 Original-Received: from localhost ([127.0.0.1]:46088 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gfDAW-00075I-DJ for submit@debbugs.gnu.org; Thu, 03 Jan 2019 19:16:56 -0500 Original-Received: from palegreen.birch.relay.mailchannels.net ([23.83.209.140]:39298) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gfDAU-000759-9h for 33870@debbugs.gnu.org; Thu, 03 Jan 2019 19:16:55 -0500 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Original-Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id C5D9F682FE9; Fri, 4 Jan 2019 00:16:52 +0000 (UTC) Original-Received: from pdx1-sub0-mail-a35.g.dreamhost.com (unknown [100.96.29.126]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 79309683002; Fri, 4 Jan 2019 00:16:52 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Original-Received: from pdx1-sub0-mail-a35.g.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.16.2); Fri, 04 Jan 2019 00:16:52 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Wide-Eyed-Irritate: 7587e153440608c3_1546561012658_1285475885 X-MC-Loop-Signature: 1546561012658:1581459542 X-MC-Ingress-Time: 1546561012657 Original-Received: from pdx1-sub0-mail-a35.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a35.g.dreamhost.com (Postfix) with ESMTP id 69042811B8; Thu, 3 Jan 2019 16:16:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=linkov.net; bh=jGcvgxcmU1XZIKDdeTQ6j2zoMWQ=; b= ngxYEqpeNkIaG/LYmOqYdXwQRqRf+ssVocufSiDud+njjs5tyBCgZJ1CuGEZ2E5d oegPhIKJqsn+QnXRFR+Hyr2tVPVLSXARr1VCVdwXtv2/SH26SnLyAw9l5q+wr4yf Ulnc9bQA2OzkeObDwYu1BH7xrIGH7oFhWlM+OVDdpJg= Original-Received: from mail.jurta.org (m91-129-109-141.cust.tele2.ee [91.129.109.141]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a35.g.dreamhost.com (Postfix) with ESMTPSA id EED82811B6; Thu, 3 Jan 2019 16:16:49 -0800 (PST) X-DH-BACKEND: pdx1-sub0-mail-a35 In-Reply-To: <87va35z95v.fsf@gmail.com> ("=?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?="'s message of "Thu, 03 Jan 2019 22:08:28 +0000") X-VR-OUT-STATUS: OK X-VR-OUT-SCORE: -100 X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedtledrvddtgddvtdcutefuodetggdotefrodftvfcurfhrohhfihhlvgemucggtfgfnhhsuhgsshgtrhhisggvpdfftffgtefojffquffvnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvffuohhfffgjkfgfgggtsehttdertddtredtnecuhfhrohhmpefluhhrihcunfhinhhkohhvuceojhhurhhisehlihhnkhhovhdrnhgvtheqnecukfhppeeluddruddvledruddtledrudegudenucfrrghrrghmpehmohguvgepshhmthhppdhhvghlohepmhgrihhlrdhjuhhrthgrrdhorhhgpdhinhgvthepledurdduvdelrddutdelrddugedupdhrvghtuhhrnhdqphgrthhhpefluhhrihcunfhinhhkohhvuceojhhurhhisehlihhnkhhovhdrnhgvtheqpdhmrghilhhfrhhomhepjhhurhhisehlihhnkhhovhdrnhgvthdpnhhrtghpthhtohepjhhorghothgrvhhorhgrsehgmhgrihhlrdgtohhmnecuvehluhhsthgvrhfuihiivgeptd X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:154118 Archived-At: >>>> 2. makes the xref buffer non-obtrusive like *Completions* >>>> in xref--show-xref-buffer; >> What do you think about allowing only xref-find-definitions >> to display a narrow xref window below the original window? > > I don't know. Can I get back the original behaviour easily? If so, > how? This should be easy using a new display action. > I ask because the assumption that xref-find-definitions produces a small > number of lines is really quite brittle. Generic functions can have > many, many methods. In Emacs, cl-print-object has 10 definitions lines, > but that could/should easily grow as anyone who devises a new type of > object can write a cl-print-object for it. In a Common Lisp system > CL:PRINT-OBJECT usually has a ton of methods (and I'm trying to write a > CL IDE that uses xref.el) In my experience 10 lines is an exception. Even with more lines the completions-like xref window remain pretty usable. > If it's part of the API, it should really be named > window-display-buffer. I'm just making sure it isn't an implementation > detail for which Martin reserve the to change at any time. I agree, window--display-buffer is more public towards other packages and could be renamed. >>> Perhaps you want window.el to export a function that encapsulates >>> all/some of this cruft to pass as ACTION. >> Yes, creating a composite display action would be a good thing to do. > > And can you create one such composite display action that brings exactly > the current *xref* behaviour? Or does one such thing already exist? It's as easy as moving components of the particular display action from the recent patch into a separate function. >>> Or maybe put that function in xref.el. But as I said above, I think we >>> also need a function that brings back the current default. >> I propose to use the new function only for xref-find-definitions. > > OK, but I would say this is a separate request: > > * This bug is about making the xref.el window-popping behaviour > configurable using display-buffer-alist&friends while keeping the UI. > That goal is now apparently within reach; > > * The goal of changing the default UI for a certain part of xref-* > commands is a different one, which I don't necessarily oppose, but it > should be discussed and implemented separately. Actually the request was about making xref windows more configurable. I could rename the subject if necessary, or create a separate request for more discussion.