From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.bugs Subject: bug#35238: 27.0.50; Clarify eventp behaviour with booleans Date: Thu, 11 Apr 2019 23:42:30 +0100 Message-ID: <87pnpsp3jd.fsf@tcd.ie> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="205336"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: Stefan Monnier To: 35238@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Apr 12 00:43:11 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hEiPX-000rI3-ML for geb-bug-gnu-emacs@m.gmane.org; Fri, 12 Apr 2019 00:43:11 +0200 Original-Received: from localhost ([127.0.0.1]:55890 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hEiPW-0003xA-Lj for geb-bug-gnu-emacs@m.gmane.org; Thu, 11 Apr 2019 18:43:10 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:40987) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hEiPQ-0003wo-El for bug-gnu-emacs@gnu.org; Thu, 11 Apr 2019 18:43:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hEiPP-0007zT-C2 for bug-gnu-emacs@gnu.org; Thu, 11 Apr 2019 18:43:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:41735) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hEiPP-0007zM-6b for bug-gnu-emacs@gnu.org; Thu, 11 Apr 2019 18:43:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hEiPO-00017l-La; Thu, 11 Apr 2019 18:43:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "Basil L. Contovounesios" Original-Sender: "Debbugs-submit" Resent-CC: monnier@iro.umontreal.ca, bug-gnu-emacs@gnu.org Resent-Date: Thu, 11 Apr 2019 22:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 35238 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org X-Debbugs-Original-Xcc: Stefan Monnier Original-Received: via spool by submit@debbugs.gnu.org id=B.15550225754308 (code B ref -1); Thu, 11 Apr 2019 22:43:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 11 Apr 2019 22:42:55 +0000 Original-Received: from localhost ([127.0.0.1]:55278 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hEiPH-00017Q-FN for submit@debbugs.gnu.org; Thu, 11 Apr 2019 18:42:55 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:54806) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hEiPF-00017D-Pc for submit@debbugs.gnu.org; Thu, 11 Apr 2019 18:42:54 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:53855) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hEiP9-0007t2-5I for submit@debbugs.gnu.org; Thu, 11 Apr 2019 18:42:48 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:40947) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hEiP8-0003wW-3o for bug-gnu-emacs@gnu.org; Thu, 11 Apr 2019 18:42:47 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hEiP6-0007rz-5E for bug-gnu-emacs@gnu.org; Thu, 11 Apr 2019 18:42:45 -0400 Original-Received: from mail-ed1-x532.google.com ([2a00:1450:4864:20::532]:35836) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hEiP2-0007pf-9q for bug-gnu-emacs@gnu.org; Thu, 11 Apr 2019 18:42:42 -0400 Original-Received: by mail-ed1-x532.google.com with SMTP id s39so6670782edb.2 for ; Thu, 11 Apr 2019 15:42:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:subject:date:message-id:user-agent:mime-version; bh=+P9JNvzqCjBZZA8J+BUYB9GbTrbcOb/a+NqGG6qnfaU=; b=YY/4mXoxK9JVpSiV6DajvLJWuR6odxA2geWs107SNEo97Th4y5pvf/AZmjF8/klXZF HP+fSbMw2mJqLVJhPp2OnfQ0H/h++1+dhhj3JpJ8YmyGU/7857T0VT0d8HHu3cVZ1EdG CTTfICLvYXPmGXC++uZorztXA8wEOjtugU8jLMIEgFHizuTDHnTO1s3zLyRPt6BJT0Ul dRy76G1GWHbdrVHRjJ1hExPtY1fAyDgsS54vpnzt+G1YzB8qG2aYatNIUVde4DGFklF1 egCyeq+L4Fbsbcvmj2z6+bOmifc9EHh3u04CTgTc0hUWAbR3Z4uQFRWZdgLNfnaSmWtM EaSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:user-agent :mime-version; bh=+P9JNvzqCjBZZA8J+BUYB9GbTrbcOb/a+NqGG6qnfaU=; b=CAbJF6+PRuWsu294YQrC8DcsNg7yHPnrrCexByKj1rGZgsoMYCROMC2d0AsiBcJa8G KyG4SEou4qaXa2zuUmrwXF7XBHfQ33f/pNP5NWNpzG2Xv8MQ38BMeHMirn9DMF9m5EZD 9xWDbx2/4J1KIiexEDtUb0UHizrMpqciuFH1Qrk80KZVqHYxC6Ti6mmdP9Vmir8gKfgz 4nFDVdwjNeBDWSnbue1hs0KFySGwsIK20IKYMaTxsttzj4T98cMn2UYt+aIGVQpvkjdz ChJt7igCXnKH2vOou4XWsdo008rFMnzIhjwV2emJqayxR8LtMU71nEJmzFmiKkBgRPN4 cErg== X-Gm-Message-State: APjAAAXDqf2xCHvEj+HbMzv3aS6XO7reiEyjOsMQEHhd2+lM+jRLCrxt uK3NHFuoteOT4GcU8pVM97wkArQCn9dtzkB0 X-Google-Smtp-Source: APXvYqzTBquLTfizOpNvV1b3WqEeoXRup2tllt43s3fMZ/TYWD70CiDms0Y01V6f6EKnwEudQU20dg== X-Received: by 2002:aa7:c6c6:: with SMTP id b6mr32478236eds.69.1555022557036; Thu, 11 Apr 2019 15:42:37 -0700 (PDT) Original-Received: from localhost ([2a02:8084:20e2:c380:f786:805d:f4ab:1006]) by smtp.gmail.com with ESMTPSA id i91sm3814952edd.72.2019.04.11.15.42.35 for (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Thu, 11 Apr 2019 15:42:35 -0700 (PDT) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:157524 Archived-At: --=-=-= Content-Type: text/plain Severity: minor Tags: patch As mentioned in a past commit[1], nil is not an event. Since the car of a mouse click event is considered its type, shouldn't (nil) also be rejected as an event? (eventp '(nil)) ; => t Should t be counted as an event? (eventp t) ; => t (eventp '(t)) ; => t If not, would the following change be welcome? --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=eventp.diff diff --git a/lisp/subr.el b/lisp/subr.el index bdf98979c4..8c4df5bc6c 100644 --- a/lisp/subr.el +++ b/lisp/subr.el @@ -1227,12 +1227,14 @@ listify-key-sequence c))) key))) -(defun eventp (obj) - "True if the argument is an event object." - (when obj - (or (integerp obj) - (and (symbolp obj) obj (not (keywordp obj))) - (and (consp obj) (symbolp (car obj)))))) +(defun eventp (object) + "Return non-nil if OBJECT is an input event or event object." + (or (integerp object) + (and (symbolp (if (consp object) + (setq object (car object)) + object)) + (not (booleanp object)) + (not (keywordp object))))) (defun event-modifiers (event) "Return a list of symbols representing the modifier keys in event EVENT. --=-=-= Content-Type: text/plain [1: e18941095a]: * lisp/term/x-win.el (x-menu-bar-open): ... 2012-08-10 10:47:12 -0400 https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=e18941095a56075d6eb908a65aafcd1697fea2ae Thanks, -- Basil In GNU Emacs 27.0.50 (build 9, x86_64-pc-linux-gnu, X toolkit, Xaw3d scroll bars) of 2019-04-11 built on thunk Repository revision: 0627a8d7bc6ffa29d7a503fd36e760778ecb9fa1 Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.12003000 System Description: Debian GNU/Linux buster/sid --=-=-=--