From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#30309: Surprising behaviour of insert-kbd-macro Date: Mon, 15 Apr 2019 20:23:19 -0400 Message-ID: <87pnpmztl4.fsf@gmail.com> References: <87inbit2nm.fsf@gmail.com> <87vafbdj6i.fsf@users.sourceforge.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="211650"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) Cc: 30309@debbugs.gnu.org To: Noam Postavsky Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Apr 16 02:24:21 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hGBta-000ssn-MF for geb-bug-gnu-emacs@m.gmane.org; Tue, 16 Apr 2019 02:24:18 +0200 Original-Received: from localhost ([127.0.0.1]:57189 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hGBtT-0005Wi-HS for geb-bug-gnu-emacs@m.gmane.org; Mon, 15 Apr 2019 20:24:11 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:33453) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hGBtL-0005Vg-BU for bug-gnu-emacs@gnu.org; Mon, 15 Apr 2019 20:24:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hGBtK-0001au-Hk for bug-gnu-emacs@gnu.org; Mon, 15 Apr 2019 20:24:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:50554) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hGBtK-0001ah-B1 for bug-gnu-emacs@gnu.org; Mon, 15 Apr 2019 20:24:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hGBtK-0003OW-6w for bug-gnu-emacs@gnu.org; Mon, 15 Apr 2019 20:24:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 16 Apr 2019 00:24:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30309 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed easy Original-Received: via spool by 30309-submit@debbugs.gnu.org id=B30309.155537420913007 (code B ref 30309); Tue, 16 Apr 2019 00:24:02 +0000 Original-Received: (at 30309) by debbugs.gnu.org; 16 Apr 2019 00:23:29 +0000 Original-Received: from localhost ([127.0.0.1]:35863 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hGBsn-0003Nj-5z for submit@debbugs.gnu.org; Mon, 15 Apr 2019 20:23:29 -0400 Original-Received: from mail-qk1-f170.google.com ([209.85.222.170]:35970) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hGBsk-0003NV-WD for 30309@debbugs.gnu.org; Mon, 15 Apr 2019 20:23:27 -0400 Original-Received: by mail-qk1-f170.google.com with SMTP id k130so11100707qke.3 for <30309@debbugs.gnu.org>; Mon, 15 Apr 2019 17:23:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=/dYAUBnufrgsOeAocjSmSqwC1KBpQu/ydIsSOHSUQSs=; b=J/hrTFxmbBBjbUocYQ/qK8StvIu7NdrmmPMpafeITmtG+UJ/iTLE9xpO3FA676s0u7 8qXnorsOTfbkDDZaXQppNyI8T0/vnOmn+Yr0WUmxJXxvwzZ6EuyncTQrOgE4BPQ5Nape ACzf/MiIylwdx0qYW/wEDYGTnpdewv86m9dfp3PJOMv4cdC3ShKi1007pEqMwfPOBgV6 ZzUD1QhDUpRboe0EbEYHk55cQZeQMh61kMZwRRuoIq1Z0wTm/ekyGxLRA7FbrdbAb81n BYOpZr1OeEL5f+TCD10XesnjIKD/Av8E/B93VWHb15OZAxNhh5xao19NElFMUQAohhL7 wr2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=/dYAUBnufrgsOeAocjSmSqwC1KBpQu/ydIsSOHSUQSs=; b=AxQnDOvGFHa0eOStn8pzNipMqpVA/YlY0ovT6U5JZZALOsVJQXj9hYSH3q9c6LX6fR K8SrLr1atWx94LmvJyyGWMbEIfMuFuQY35DkYR+9JxalMnzZOSodX5sHPmKdng52NS8+ qRxVtYfZHRfhJyKWFaef6MfpipznSgph08FZgT7r+qraU8V8KlXTAP490t/7vE7vtVo4 sSuWH24oWtNu9KXQK/gFdloIB3GRvuveXHpaDsGv5DqB61J3yTggYgv305/bHPoiHNrx qD+5AYXPHWJMjLkT4fhAajOK4XUz1DTNkVe2tBEYylPE+9FNMWlIOm/KTFBOfvwRBotn wLqQ== X-Gm-Message-State: APjAAAXcSFNbxmvm24oApKFMhITrSkECDVV+QZtGIcD6IY+zdftXHpvf A+5cJROcaGfADMiVVVXIieK8K2wr X-Google-Smtp-Source: APXvYqyS+jHcaPraxEGHFE6oNi4MBOydNFCjloRL/CNgYJTiTIBs6zuZBfVSmCjYEzn6bXVTwbqbLw== X-Received: by 2002:a05:620a:15c4:: with SMTP id o4mr57966495qkm.175.1555374201454; Mon, 15 Apr 2019 17:23:21 -0700 (PDT) Original-Received: from minid (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id b7sm28516075qkc.47.2019.04.15.17.23.20 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 15 Apr 2019 17:23:20 -0700 (PDT) In-Reply-To: (Robert Pluim's message of "Fri, 29 Mar 2019 16:06:44 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:157686 Archived-At: Robert Pluim writes: > That would work as well. Something like this (utterly untested beyond > 'insert-kbd-macro'): > DEFUN ("where-is-internal", Fwhere_is_internal, Swhere_is_internal, 1, 5, 0, > doc: /* Return list of keys that invoke DEFINITION. > +If DEFINITION is nil, return nil. > + if (NILP (definition)) > + return Qnil; > + Hmm, on the one hand no keys invoke 'nil', so returning nil in that situation is already covered by the current docstring (and doing something else could be considered a plain bug). On the other hand, I see it returns keys for which (define-key global-map KEY nil) was called, which is potentially useful. I don't know if anything uses that, but I hesitate to remove the capability. By the way, I noticed the diff below also fixes this bug, although I don't quite understand why. --- i/lisp/macros.el +++ w/lisp/macros.el @@ -127,7 +127,7 @@ (defun insert-kbd-macro (macroname &optional keys) (insert ")\n") (if keys (let ((keys (or (where-is-internal (symbol-function macroname) - '(keymap)) + '(keymap) nil t) (where-is-internal macroname '(keymap))))) (while keys (insert "(global-set-key ")