From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#33959: 26.1.90; python.el font-lock buffer wreaks havoc when company is enabled Date: Tue, 16 Apr 2019 18:04:01 -0400 Message-ID: <87pnply5da.fsf@gmail.com> References: <87zhp5ch5n.fsf_-_@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="185697"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) Cc: 33959@debbugs.gnu.org To: Carlos Pita Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Apr 17 00:05:17 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hGWCY-000m9I-CP for geb-bug-gnu-emacs@m.gmane.org; Wed, 17 Apr 2019 00:05:14 +0200 Original-Received: from localhost ([127.0.0.1]:43428 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hGWCX-0003eb-DW for geb-bug-gnu-emacs@m.gmane.org; Tue, 16 Apr 2019 18:05:13 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:44062) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hGWCO-0003eT-4M for bug-gnu-emacs@gnu.org; Tue, 16 Apr 2019 18:05:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hGWCM-00062K-Am for bug-gnu-emacs@gnu.org; Tue, 16 Apr 2019 18:05:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:53341) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hGWCL-00062E-UD for bug-gnu-emacs@gnu.org; Tue, 16 Apr 2019 18:05:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hGWCL-0006rB-NB for bug-gnu-emacs@gnu.org; Tue, 16 Apr 2019 18:05:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 16 Apr 2019 22:05:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33959 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 33959-submit@debbugs.gnu.org id=B33959.155545225026285 (code B ref 33959); Tue, 16 Apr 2019 22:05:01 +0000 Original-Received: (at 33959) by debbugs.gnu.org; 16 Apr 2019 22:04:10 +0000 Original-Received: from localhost ([127.0.0.1]:38650 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hGWBW-0006ps-A3 for submit@debbugs.gnu.org; Tue, 16 Apr 2019 18:04:10 -0400 Original-Received: from mail-qt1-f171.google.com ([209.85.160.171]:32850) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hGWBV-0006pf-5w for 33959@debbugs.gnu.org; Tue, 16 Apr 2019 18:04:09 -0400 Original-Received: by mail-qt1-f171.google.com with SMTP id k14so25237565qtb.0 for <33959@debbugs.gnu.org>; Tue, 16 Apr 2019 15:04:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=ZHlh2SNi9x73Y2f6iNPeo9sLwYmwin+pkeP7kjS3K8g=; b=OzxftIshY3J97Kd6C2oQRJtSvp5SOQhlQ+7v610gAPC79W9HTtMS24wmC5W7aIdzxF QtSLIv17lVc2V1b7mW/li9KWdmzT/VOh0mzVkeRskfFxs2SIPR5jdYp0vUTWin3FA8Gd LrfRuTxjJj5u+JucLxulvG9+b4Fj703uB5uZAuCCxvFJUYCnLtREAI0vtlmIeGS6LSZx weceocej8erfir1U/EmFrg50ctMF5upxTYAeaN9HQ2KIMpc/3RTjPALaHb0merElzSiH P58lFlHqahQRclL9pByAFZXn9InEkPNM4QQ+yrYpHQaY4Pf+1W+av4WEeUrjIs10/UPP h+Qw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=ZHlh2SNi9x73Y2f6iNPeo9sLwYmwin+pkeP7kjS3K8g=; b=Pf7AV3IfyclU5lWSFrSdiByrdICzRHywkhELcT4fFvGcl37lr7WUOoHeHx7zaqFXaC eztUPQTIv1Gu9bRfUoXXC8KuKFl236Xc5yjSHcL3DZNDGN0FpGrzVW1hbmkRl91+LsUB twKs/sKrjjeikgMfoplBGrzkdCWgb8cTjcC5zhLldKZP3wD/P8xz7ITRXxZCoOUOnahM +iwT0f8dV6gz88zlW+ia4/RUEa8rVUOzT1eESvxGOmkLwAgFkZ5VzXrzSs5bBsAvlvB7 xu60s86uCDRQJNpkXBBnq6rW3Cy8sRO0RePUsFMu+56EKPjFHSxjt5iRJeSYvTp7gSfI N6mg== X-Gm-Message-State: APjAAAVrJtvF6qGoWdoPFO+9T5asuynU1b9pIOsnHQGf8QLQt6y5LBvx tbptmxqFZq20VdqzSdUnj74jopaM X-Google-Smtp-Source: APXvYqwgBlMDkbSCnEzhrxWUbFAOgUExkGbLGx0s1J27h+pCd6/ch7gXsZ1yMn1wSi1N+wcy4QnTsw== X-Received: by 2002:ac8:38f8:: with SMTP id g53mr68778006qtc.221.1555452243611; Tue, 16 Apr 2019 15:04:03 -0700 (PDT) Original-Received: from minid (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id h22sm42835907qth.68.2019.04.16.15.04.02 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 16 Apr 2019 15:04:02 -0700 (PDT) In-Reply-To: (Carlos Pita's message of "Tue, 16 Apr 2019 18:47:19 -0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:157746 Archived-At: Carlos Pita writes: > Hi Noam, > >> And my " *Python-font-lock*" looks like this: >> >> >> 1 + len('123') + 99 + len('aa') >> >> >> >> 1 + len( >> 1 + len('123' >> 1 + len('123') + 99 + len('aa') >> >> The behaviour seems rather inconsistent. I think to solve this properly >> we need some deterministic tests which reproduce the problem. > > > The state of your " *Python-font-lock*" buffer is exactly what I mean. > The duplications you see are caused by spurious newlines added when > empty output is passed to the filter. There are two bad things there: > i) empty strings are transformed into new lines and 2) empty strings > are an undesirable side effect of company being triggered in a hidden > buffer (this is analogous to the problem with org mode hidden buffer > and yasnippet that I recently reported). Try disabling company mode in > python font lock buffer; even though, this is not necessary if (i) > above is fixed, which IMO should be done independently of the nasty > company interaction. > > Besides, remember that patch 2 is fixing two different issues. This is > somewhat undesirable but there are a lot of overlapping between them. > Nevertheless, I provided patch 1 in case you are unwilling to apply > one of them. The above state happens after I've applied your patch #2. So I can't tell if it fixes anything. That's why I think we need some deterministic tests to show what is fixed and what is broken.