From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#33037: 27.0.50; [PATCH] Support program switches in 'comint-run' command Date: Thu, 11 Jul 2019 17:33:40 +0200 Message-ID: <87pnmg37sb.fsf@mouse.gnus.org> References: <4c421a8c-9b14-7981-f4bf-f4e6b33d2876@orcon.net.nz> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="36343"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 33037@debbugs.gnu.org To: Phil Sainty Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Jul 11 17:39:04 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hlb9u-00094H-O9 for geb-bug-gnu-emacs@m.gmane.org; Thu, 11 Jul 2019 17:38:58 +0200 Original-Received: from localhost ([::1]:42868 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hlb5E-0002q9-VV for geb-bug-gnu-emacs@m.gmane.org; Thu, 11 Jul 2019 11:34:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54269) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hlb5B-0002pk-Vi for bug-gnu-emacs@gnu.org; Thu, 11 Jul 2019 11:34:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hlb59-0002mb-UQ for bug-gnu-emacs@gnu.org; Thu, 11 Jul 2019 11:34:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:57824) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hlb58-0002lg-KV for bug-gnu-emacs@gnu.org; Thu, 11 Jul 2019 11:34:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hlb58-00048y-HQ for bug-gnu-emacs@gnu.org; Thu, 11 Jul 2019 11:34:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 11 Jul 2019 15:34:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33037 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 33037-submit@debbugs.gnu.org id=B33037.156285922715892 (code B ref 33037); Thu, 11 Jul 2019 15:34:02 +0000 Original-Received: (at 33037) by debbugs.gnu.org; 11 Jul 2019 15:33:47 +0000 Original-Received: from localhost ([127.0.0.1]:38409 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hlb4s-00048G-VY for submit@debbugs.gnu.org; Thu, 11 Jul 2019 11:33:47 -0400 Original-Received: from quimby.gnus.org ([80.91.231.51]:56772) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hlb4q-000484-SM for 33037@debbugs.gnu.org; Thu, 11 Jul 2019 11:33:45 -0400 Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hlb4m-0004uI-LU; Thu, 11 Jul 2019 17:33:43 +0200 In-Reply-To: <4c421a8c-9b14-7981-f4bf-f4e6b33d2876@orcon.net.nz> (Phil Sainty's message of "Sun, 14 Oct 2018 17:42:36 +1300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:162712 Archived-At: Phil Sainty writes: > This patch enables arguments to be passed to the specified program when > invoking `comint-run'. > > Interactively, a prefix argument C-u will make the command prompt for > the switches (as a string) after prompting for the program. The > switches are processed with `split-string-and-unquote'. > > I think this is a sensible enhancement, but not necessarily the best > user interface. Other possibilities which occur are: > > 1. Do not require a prefix arg, and simply make this the default > prompting behaviour. > > 2. Do not require a separate prompt, and instead parse the program > and its switches out of a single string. I think your patch makes sense as it is, so I've applied it to the Emacs trunk now. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no