From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#37174: 26.2; Stabilize tabulated-list reversed sort Date: Sat, 21 Sep 2019 00:09:27 +0200 Message-ID: <87pnju62nc.fsf@gnus.org> References: <871rxaiqpz.fsf@bredband.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="197214"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 37174@debbugs.gnu.org To: Johan Claesson Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Sep 21 00:10:20 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iBR6X-000p7s-Gk for geb-bug-gnu-emacs@m.gmane.org; Sat, 21 Sep 2019 00:10:17 +0200 Original-Received: from localhost ([::1]:35746 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iBR6W-00079A-75 for geb-bug-gnu-emacs@m.gmane.org; Fri, 20 Sep 2019 18:10:16 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57300) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iBR6J-000766-Vz for bug-gnu-emacs@gnu.org; Fri, 20 Sep 2019 18:10:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iBR6I-0005uY-TL for bug-gnu-emacs@gnu.org; Fri, 20 Sep 2019 18:10:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:49883) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iBR6I-0005uU-Pu for bug-gnu-emacs@gnu.org; Fri, 20 Sep 2019 18:10:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iBR6I-0004F4-KL for bug-gnu-emacs@gnu.org; Fri, 20 Sep 2019 18:10:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 20 Sep 2019 22:10:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37174 X-GNU-PR-Package: emacs Original-Received: via spool by 37174-submit@debbugs.gnu.org id=B37174.156901737516224 (code B ref 37174); Fri, 20 Sep 2019 22:10:02 +0000 Original-Received: (at 37174) by debbugs.gnu.org; 20 Sep 2019 22:09:35 +0000 Original-Received: from localhost ([127.0.0.1]:58697 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iBR5q-0004Dc-T9 for submit@debbugs.gnu.org; Fri, 20 Sep 2019 18:09:35 -0400 Original-Received: from quimby.gnus.org ([80.91.231.51]:37552) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iBR5o-0004DP-Q0 for 37174@debbugs.gnu.org; Fri, 20 Sep 2019 18:09:33 -0400 Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iBR5k-00075i-0j; Sat, 21 Sep 2019 00:09:30 +0200 In-Reply-To: <871rxaiqpz.fsf@bredband.net> (Johan Claesson's message of "Sat, 24 Aug 2019 16:27:04 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:166811 Archived-At: Johan Claesson writes: > Sorting with S multiple times in a tabulated-list buffer should be > stable but will sometimes reorder entries with the same value. When the > sort order is reversed the function tabulated-list--get-sorter will > transform the sort function to sort the other way around by negating. I > think this is what cause the needless reordering and that it should be > changed something like the following: [...] > (if (cdr tabulated-list-sort-key) > - (lambda (a b) (not (funcall sorter a b))) > + (lambda (a b) (funcall sorter b a)) That looks like the correct solution, so I've applied it to the trunk. If I read the logs correctly, I think that cumulatively you've now had the number of lines committed to Emacs that's allowed without signing copyright assignment papers. For future patches, would you be willing to sign such paperwork? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no