bug#28413: 26.0.50; enable frame filters for gdb-mi

bug#28413: 26.0.50; enable frame filters for gdb-mi

[Tom Tromey]

[-- Attachment #1: Type: text/plain, Size: 142 bytes --]


I noticed that gdb-mi doesn't enable frame filters.

I think it shouldn't hurt to simply always enable them, as in the
attached patch.

Tom


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: the patch --]
[-- Type: text/x-patch, Size: 691 bytes --]

commit 331aa85eaee7da4547e49a5200153526190bc95f
Author: Tom Tromey <tom@tromey.com>
Date:   Mon Mar 6 15:10:05 2017 -0700

    Send -enable-frame-filters to gdb
    
    * lisp/progmodes/gdb-mi.el (gdb-init-1): Send -enable-frame-filters to
    gdb.

diff --git a/lisp/progmodes/gdb-mi.el b/lisp/progmodes/gdb-mi.el
index a30669d..34ca437 100644
--- a/lisp/progmodes/gdb-mi.el
+++ b/lisp/progmodes/gdb-mi.el
@@ -947,6 +947,7 @@ gdb-init-1
     (gdb-input "-gdb-set non-stop 1" 'gdb-non-stop-handler))
 
   (gdb-input "-enable-pretty-printing" 'ignore)
+  (gdb-input "-enable-frame-filters" 'ignore)
 
   ;; Find source file and compilation directory here.
   (if gdb-create-source-file-list

[-- Attachment #3: Type: text/plain, Size: 5940 bytes --]





In GNU Emacs 26.0.50 (build 18, x86_64-pc-linux-gnu, GTK+ Version 3.22.17)
 of 2017-09-09 built on bapiya
Repository revision: 4131f9785e30f2a31745125c714e922892113c62
Windowing system distributor 'Fedora Project', version 11.0.11903000
System Description:	Fedora release 25 (Twenty Five)

Recent messages:
Making completion list... [2 times]
funcall-interactively: End of buffer
Quit [2 times]
When done with a buffer, type C-x #
Auto-saving...done
Auto-saving...done
Auto-saving...done
Saving file /home/tromey/gdb/binutils-gdb/.git/.gitsendemail.msg.TbtaV7...
Wrote /home/tromey/gdb/binutils-gdb/.git/.gitsendemail.msg.TbtaV7
C-x C-g is undefined

Configured using:
 'configure --prefix=/home/tromey/Emacs/install'

Configured features:
XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND GPM DBUS GSETTINGS NOTIFY
LIBSELINUX GNUTLS LIBXML2 FREETYPE M17N_FLT LIBOTF XFT ZLIB
TOOLKIT_SCROLL_BARS GTK3 X11

Important settings:
  value of $LANG: en_US.utf8
  value of $XMODIFIERS: @im=ibus
  locale-coding-system: utf-8-unix

Major mode: C/*l

Minor modes in effect:
  shell-dirtrack-mode: t
  bug-reference-prog-mode: t
  diff-auto-refine-mode: t
  flyspell-mode: t
  which-function-mode: t
  erc-services-mode: t
  erc-list-mode: t
  erc-menu-mode: t
  erc-autojoin-mode: t
  erc-ring-mode: t
  erc-networks-mode: t
  erc-pcomplete-mode: t
  erc-track-mode: t
  erc-match-mode: t
  erc-netsplit-mode: t
  erc-hl-nicks-mode: t
  erc-button-mode: t
  erc-fill-mode: t
  erc-stamp-mode: t
  erc-irccontrols-mode: t
  erc-noncommands-mode: t
  erc-move-to-prompt-mode: t
  erc-readonly-mode: t
  savehist-mode: t
  tooltip-mode: t
  global-eldoc-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  column-number-mode: t
  line-number-mode: t
  auto-fill-function: tromey-c++-do-auto-fill
  transient-mark-mode: t
  abbrev-mode: t

Load-path shadows:
/home/tromey/.emacs.d/elpa/bubbles-0.5/bubbles hides /home/tromey/Emacs/install/share/emacs/26.0.50/lisp/play/bubbles

Features:
(shadow emacsbug noutline outline tcl supercite regi mail-hist nnir
texinfo gnus-draft jka-compr make-mode find-file term/xterm xterm
goto-addr log-edit shell find-dired pulse vc-mtn vc-hg etags xref
project log-view pcvs-util smerge-mode bug-reference cc-mode cc-fonts
cc-guess cc-menus cc-cmds vc-bzr vc-src vc-sccs vc-svn vc-cvs vc-rcs
copyright vc-git diff-mode easy-mmode map shr-color shr svg dom
flow-fill mm-archive gnus-html url-queue browse-url xml url-cache mm-url
url url-proxy url-privacy url-expand url-methods url-history url-cookie
url-domsuf url-util misearch multi-isearch mailalias sort smiley
gnus-cite gnus-async gnus-bcklg mail-extr gnus-ml disp-table gnus-topic
nndraft nnmh nnfolder utf-7 network-stream nsm starttls gnus-agent
gnus-srvr gnus-score score-mode nnvirtual gnus-msg nntp gnus-cache
gnus-registry registry ebdb-gnus gnus-art mm-uu mml2015 mm-view
mml-smime smime dig mailcap gnus-sum gnus-group gnus-undo smtpmail
gnus-start gnus-cloud nnimap nnmail mail-source tls gnutls utf7 netrc
nnoo parse-time gnus-spec gnus-int gnus-range gnus-win gnus add-log
nnheader profiler cl-print debug dabbrev help-fns radix-tree elec-pair
flyspell ispell diminish edmacro kmacro projectile grep compile ibuf-ext
ibuffer ibuffer-loaddefs dash appt diary-lib diary-loaddefs which-func
imenu minimap autorevert filenotify cus-start cus-load status
erc-services erc-list erc-menu erc-join erc-ring erc-networks
erc-pcomplete pcomplete erc-track erc-match erc-netsplit erc-hl-nicks
color erc-button erc-fill erc-stamp wid-edit erc-goodies erc erc-backend
erc-compat thingatpt pp warnings advice vc-dir ewoc vc vc-dispatcher
cc-styles cc-align cc-engine cc-vars cc-defs ebdb-complete ebdb-message
sendmail message puny dired dired-loaddefs format-spec rfc822 mml
mml-sec epa derived epg gnus-util rmail rmail-loaddefs mm-decode
mm-bodies mm-encode mail-parse rfc2231 rfc2047 rfc2045 mm-util
ietf-drums mail-prsvr mail-utils gmm-utils mailheader ebdb-mua ebdb-com
crm mailabbrev ebdb-format qp ebdb cl-extra help-mode eieio-opt speedbar
sb-image ezimage dframe find-func eieio-base pcase subr-x cal-menu
calendar cal-loaddefs timezone ange-ftp comint ansi-color ring server
savehist finder-inf dwarf-mode-autoloads gdb-shell-autoloads
lisppaste-autoloads pydoc-info-autoloads info-look cl
weblogger-autoloads info package easymenu epg-config url-handlers
url-parse auth-source cl-seq eieio eieio-core cl-macs eieio-loaddefs
password-cache url-vars seq byte-opt gv bytecomp byte-compile cconv
cl-loaddefs cl-lib time-date mule-util tooltip eldoc electric uniquify
ediff-hook vc-hooks lisp-float-type mwheel term/x-win x-win
term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe
tabulated-list replace newcomment text-mode elisp-mode lisp-mode
prog-mode register page menu-bar rfn-eshadow isearch timer select
scroll-bar mouse jit-lock font-lock syntax facemenu font-core
term/tty-colors frame cl-generic cham georgian utf-8-lang misc-lang
vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932
hebrew greek romanian slovak czech european ethiopic indian cyrillic
chinese composite charscript charprop case-table epa-hook jka-cmpr-hook
help simple abbrev obarray minibuffer cl-preloaded nadvice loaddefs
button faces cus-face macroexp files text-properties overlay sha1 md5
base64 format env code-pages mule custom widget hashtable-print-readable
backquote dbusbind inotify dynamic-setting system-font-setting
font-render-setting move-toolbar gtk x-toolkit x multi-tty
make-network-process emacs)

Memory information:
((conses 16 1393195 721365)
 (symbols 48 51459 81)
 (miscs 40 16109 1526)
 (strings 32 507292 69060)
 (string-bytes 1 13719589)
 (vectors 16 244763)
 (vector-slots 8 3668114 248015)
 (floats 8 474 1253)
 (intervals 56 29271 2181)
 (buffers 992 94))

bug#28413: 26.0.50; enable frame filters for gdb-mi

[Eli Zaretskii]

> From: Tom Tromey <tom@tromey.com>
> Date: Sun, 10 Sep 2017 18:37:52 -0600
> 
> I noticed that gdb-mi doesn't enable frame filters.
> 
> I think it shouldn't hurt to simply always enable them, as in the
> attached patch.

Looks reasonable, thanks.

bug#28413: 26.0.50; enable frame filters for gdb-mi

[Stefan Kangas]

tags 28413 + patch
quit

Eli Zaretskii <eliz@gnu.org> writes:

>> From: Tom Tromey <tom@tromey.com>
>> Date: Sun, 10 Sep 2017 18:37:52 -0600
>>
>> I noticed that gdb-mi doesn't enable frame filters.
>>
>> I think it shouldn't hurt to simply always enable them, as in the
>> attached patch.
>
> Looks reasonable, thanks.

This patch was never installed at the time.  Should it be installed?

Best regards,
Stefan Kangas

bug#28413: 26.0.50; enable frame filters for gdb-mi

[Eli Zaretskii]

> From: Stefan Kangas <stefan@marxist.se>
> Date: Sun, 29 Sep 2019 03:17:38 +0200
> Cc: Tom Tromey <tom@tromey.com>, 28413@debbugs.gnu.org
> 
> >> I noticed that gdb-mi doesn't enable frame filters.
> >>
> >> I think it shouldn't hurt to simply always enable them, as in the
> >> attached patch.
> >
> > Looks reasonable, thanks.
> 
> This patch was never installed at the time.  Should it be installed?

Yes.  I believe I expected Tom to install it.

bug#28413: 26.0.50; enable frame filters for gdb-mi

[Stefan Kangas]

close 28413 27.1
thanks

Eli Zaretskii <eliz@gnu.org> writes:

>> From: Stefan Kangas <stefan@marxist.se>
>> Date: Sun, 29 Sep 2019 03:17:38 +0200
>> Cc: Tom Tromey <tom@tromey.com>, 28413@debbugs.gnu.org
>> 
>> >> I noticed that gdb-mi doesn't enable frame filters.
>> >>
>> >> I think it shouldn't hurt to simply always enable them, as in the
>> >> attached patch.
>> >
>> > Looks reasonable, thanks.
>> 
>> This patch was never installed at the time.  Should it be installed?
>
> Yes.  I believe I expected Tom to install it.

OK, I've now pushed it as commit 772f1c4189.  Closing.

Best regards,
Stefan Kangas