From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#16374: password not hidden in shell when mounting cifs partition Date: Thu, 07 Nov 2019 01:39:40 +0100 Message-ID: <87pni4wmcz.fsf@marxist.se> References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="40783"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 16374-done@debbugs.gnu.org To: Tyler Smith Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Nov 07 01:40:22 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iSVqU-000ATu-My for geb-bug-gnu-emacs@m.gmane.org; Thu, 07 Nov 2019 01:40:19 +0100 Original-Received: from localhost ([::1]:38032 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iSVqT-0001TQ-Cz for geb-bug-gnu-emacs@m.gmane.org; Wed, 06 Nov 2019 19:40:17 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57448) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iSVqJ-0001T0-0B for bug-gnu-emacs@gnu.org; Wed, 06 Nov 2019 19:40:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iSVqH-0007JY-U2 for bug-gnu-emacs@gnu.org; Wed, 06 Nov 2019 19:40:06 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:60868) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iSVqH-0007JI-Nd for bug-gnu-emacs@gnu.org; Wed, 06 Nov 2019 19:40:05 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iSVqH-00081i-IM for bug-gnu-emacs@gnu.org; Wed, 06 Nov 2019 19:40:05 -0500 Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Thu, 07 Nov 2019 00:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 16374 X-GNU-PR-Package: emacs Mail-Followup-To: 16374@debbugs.gnu.org, stefan@marxist.se, tyler@plantarum.ca Original-Received: via spool by 16374-done@debbugs.gnu.org id=D16374.157308719330822 (code D ref 16374); Thu, 07 Nov 2019 00:40:02 +0000 Original-Received: (at 16374-done) by debbugs.gnu.org; 7 Nov 2019 00:39:53 +0000 Original-Received: from localhost ([127.0.0.1]:41454 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iSVq5-000814-Cy for submit@debbugs.gnu.org; Wed, 06 Nov 2019 19:39:53 -0500 Original-Received: from host.gofardesign.uk ([208.79.239.190]:37477) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iSVq3-00080o-3n for 16374-done@debbugs.gnu.org; Wed, 06 Nov 2019 19:39:51 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=marxist.se; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=D16GdYoJJS467qoy0KW0fFKl1ChXKa9aqBIW3h5+XUo=; b=Wjoz+XcRFCyT3Km4Q6C+RULrLM rwELuSCW05udRgQ7B2LsbHd2koGkclQKWxC2zB3tZcZQqUJcsOVNo2tibQWRtHjytFxhaqrDJaYX6 6RFgyz6s1vP6QCYIYYjgHCojoi90i+OJ2HHXJpZeqBYVpUKvyOHT3A9nEx/GrwV/BecQ=; Original-Received: from h-70-69.a785.priv.bahnhof.se ([155.4.70.69]:59478 helo=localhost) by host.gofardesign.uk with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1iSVpt-0005dF-Pj; Wed, 06 Nov 2019 18:39:42 -0600 In-Reply-To: (Stefan Kangas's message of "Sun, 6 Oct 2019 03:40:21 +0200") X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - host.gofardesign.uk X-AntiAbuse: Original Domain - debbugs.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - marxist.se X-Get-Message-Sender-Via: host.gofardesign.uk: authenticated_id: stefan@marxist.se X-Authenticated-Sender: host.gofardesign.uk: stefan@marxist.se X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:171058 Archived-At: Stefan Kangas writes: > Tyler Smith writes: > >> I'm not sure if this is really an Emacs bug, or just a limitation of *shell* >> >> Starting from emacs -Q: >> M-x shell >> mount ./network-drive >> ;; (fstab for this drive is: >> ///$/ /home/user/network-drive cifs >> noauto,users,user=,uid=> username>,rw 0 0 >> ;; ) >> >> ;; I am now prompted for my network password. When I enter it and press >> ;; return I see this: >> Password for @///$/: > plain text> >> ******** >> >> The point is, the asterisks should be appearing in place of my actual >> password. Instead, they appear in addition to my password. >> >> Thanks for your time, >> >> Tyler >> >> In GNU Emacs 24.3.50.1 (i686-pc-linux-gnu, GTK+ Version 3.8.6) >> of 2013-12-31 on ONOTTAR654746 > > Hi Tyler, > > Thanks for the bug report. Sorry that it went unanswered for so long. > > When I try the following on Emacs 26.1, I get no error: > > (progn > (require 'comint) > (string-match comint-password-prompt-regexp > "Password for foo@//example.org/foo/bar$/: ")) > > This suggests to me that a prompt such as the above should work under > M-x shell, since that is built on top of comint. > > Could you verify that this works for you on Emacs 26.1? > > Could you also please tell me if: > > "Password for foo@//example.org/foo/bar$/: " > > is a good example of the kind of prompt you get when mounting a cifs > partition? (I'm trying to find a good example to add to the test > suite for comint-password-prompt-regexp.) The original issue seems to be solved here. More information was requested on how to write a test case for this, but none was given within 4 weeks. I'm therefore closing this bug. If someone could provide an example of what a CIFS prompt realistically looks like, please report back so we can add it to the test suite. Finally, if anyone is still seeing this on Emacs 27 despite the above, please reopen the bug report. Best regards, Stefan Kangas