From: Lars Ingebrigtsen <larsi@gnus.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 24560@debbugs.gnu.org, thecybershadow@gmail.com
Subject: bug#24560: 25.1; With `--font 7x13', wrong font is used for Unicode characters
Date: Sun, 17 Nov 2019 19:33:46 +0100 [thread overview]
Message-ID: <87pnhq4ak5.fsf@gnus.org> (raw)
In-Reply-To: <831ru65pik.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 17 Nov 2019 20:25:23 +0200")
Eli Zaretskii <eliz@gnu.org> writes:
>> From: Lars Ingebrigtsen <larsi@gnus.org>
>> Cc: thecybershadow@gmail.com, 24560@debbugs.gnu.org
>> Date: Sun, 17 Nov 2019 18:58:26 +0100
>>
>> So if somebody says explicitly --without-xft, then HAVE_XFT won't be
>> "yes", and we set HAVE_FREETYPE to "no" without checking. And harfbuzz
>> depends on HAVE_FREETYPE being "yes", so harfbuzz depends on xft being
>> available, too.
>>
>> Is this correct behaviour?
>
> Maybe I'm simply misremembering, and HarfBuzz does need xft.
I hacked the configure script to just say
diff --git a/configure.ac b/configure.ac
index 0976b665e6..d42f530407 100644
--- a/configure.ac
+++ b/configure.ac
@@ -3399,6 +3399,9 @@ AC_DEFUN
fi
fi # $HAVE_CAIRO != yes
+ EMACS_CHECK_MODULES([FREETYPE], [freetype2])
+ test "$HAVE_FREETYPE" = "no" && AC_MSG_ERROR(libxft requires libfreetype)
+
HAVE_LIBOTF=no
if test "${HAVE_FREETYPE}" = "yes"; then
AC_DEFINE(HAVE_FREETYPE, 1,
to force
Does Emacs use HarfBuzz? yes
Does Emacs use -lm17n-flt? yes
Does Emacs use -lotf? yes
Does Emacs use -lxft? no
and compilation does indeed fail:
In file included from ftfont.c:46:
ftfont.h:77:3: error: unknown type name ‘XftFont’
XftFont *xftfont;
^~~~~~~
>> In addition, I think the configure script should fail if you say
>> --with-harfbuzz and harfbuzz isn't available.
>
> Probably.
I've now added that, at least.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2019-11-17 18:33 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-28 16:34 bug#24560: 25.1; With `--font 7x13', wrong font is used for Unicode characters Vladimir Panteleev
2016-09-28 20:16 ` Eli Zaretskii
2016-09-28 21:58 ` Vladimir Panteleev
2016-09-29 15:30 ` Eli Zaretskii
2016-09-29 16:33 ` Vladimir Panteleev
2016-10-08 13:07 ` Eli Zaretskii
2016-10-15 14:10 ` Eli Zaretskii
2016-11-18 8:48 ` Eli Zaretskii
2019-11-17 7:21 ` Lars Ingebrigtsen
2019-11-17 13:10 ` Vladimir Panteleev
2019-11-17 16:10 ` Eli Zaretskii
2019-11-17 16:26 ` Lars Ingebrigtsen
2019-11-17 17:07 ` Eli Zaretskii
2019-11-17 17:09 ` Lars Ingebrigtsen
2019-11-17 17:58 ` Lars Ingebrigtsen
2019-11-17 18:25 ` Eli Zaretskii
2019-11-17 18:33 ` Lars Ingebrigtsen [this message]
2019-11-17 21:05 ` Robert Pluim
2019-11-18 9:19 ` Lars Ingebrigtsen
2022-04-23 14:02 ` Lars Ingebrigtsen
2022-04-23 15:17 ` Vladimir Panteleev
2019-11-17 19:05 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pnhq4ak5.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=24560@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=thecybershadow@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).