From: Lars Ingebrigtsen <larsi@gnus.org>
To: Federico Tedin <federicotedin@gmail.com>
Cc: 38282@debbugs.gnu.org, Robert Pluim <rpluim@gmail.com>,
Michael Albinus <michael.albinus@gmx.de>
Subject: bug#38282: 26.3; goto-line should not share input history with other commands
Date: Fri, 22 Nov 2019 13:09:06 +0100 [thread overview]
Message-ID: <87pnhkt8nx.fsf@gnus.org> (raw)
In-Reply-To: <87a78olwa1.fsf@gmail.com> (Federico Tedin's message of "Thu, 21 Nov 2019 23:06:14 +0100")
Federico Tedin <federicotedin@gmail.com> writes:
> + ;; It would be better to use `goto-line-history' as a HIST
> + ;; parameter to `read-from-minibuffer' (through
> + ;; `read-number'), but using buffer-local variables
> + ;; doesn't work for that purpose. (Bug#38317)
> + (minibuffer-history
> + (buffer-local-value 'goto-line-history (or buffer
> + (current-buffer)))))
I think a per-buffer history for goto-line makes sense, but I was also
wondering whether read-number should have its own separate history, too.
This would, I think, not interoperate well with that (that is, if
`read-number' passes a different variable to read-from-minibuffer than
nil).
So I think a better solution would be to fix the problem with
buffer-local variables not working in read-from-minibuffer first, and
then we could extend read-number with a history parameter instead of
hacking around the problem this way.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2019-11-22 12:09 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-19 21:48 bug#38282: 26.3; goto-line should not share input history with other commands Federico Tedin
2019-11-21 13:51 ` Lars Ingebrigtsen
2019-11-21 14:41 ` Robert Pluim
2019-11-21 15:20 ` Michael Albinus
2019-11-21 17:51 ` Lars Ingebrigtsen
2019-11-21 18:43 ` Federico Tedin
2019-11-21 22:06 ` Federico Tedin
2019-11-22 7:35 ` Eli Zaretskii
2019-11-22 12:09 ` Lars Ingebrigtsen [this message]
2019-11-23 17:05 ` Federico Tedin
2019-11-27 11:48 ` Lars Ingebrigtsen
2019-12-06 22:14 ` Federico Tedin
2019-12-14 11:44 ` Eli Zaretskii
2019-12-17 21:19 ` Federico Tedin
2019-12-24 16:39 ` Lars Ingebrigtsen
2019-12-24 23:21 ` Federico Tedin
2019-11-22 7:57 ` Michael Albinus
2019-11-22 8:40 ` Robert Pluim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pnhkt8nx.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=38282@debbugs.gnu.org \
--cc=federicotedin@gmail.com \
--cc=michael.albinus@gmx.de \
--cc=rpluim@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).