From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#38044: 27.0.50; There should be an easier way to look at a specific vc commit Date: Fri, 22 Nov 2019 01:08:17 +0200 Organization: LINKOV.NET Message-ID: <87pnhkern2.fsf@mail.linkov.net> References: <87ftj5at1q.fsf@gnus.org> <87r22phsoj.fsf@gmx.net> <87bltslnpo.fsf@mail.linkov.net> <87d0dvmqu8.fsf@mail.linkov.net> <590e595e-8220-1c7e-bd4a-b2eb0968e289@yandex.ru> <87r226xl8m.fsf@mail.linkov.net> <24c56bca-8d7d-3a20-aeef-5d11f8a075e6@yandex.ru> <87pnhquo4k.fsf@mail.linkov.net> <6087186e-a444-0aac-e87d-596d2e36f0ce@yandex.ru> <877e3wub09.fsf@mail.linkov.net> <5ce7d4f0-3884-fd27-09dc-c38f01a19958@yandex.ru> <83zhgr26c3.fsf@gnu.org> <87blt7qxhz.fsf@mail.linkov.net> <837e3v1aae.fsf@gnu.org> <87y2warzv3.fsf@mail.linkov.net> <29e2e877-6dc3-b03b-7463-01cff35e05d1@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="268429"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) Cc: stephen.berman@gmx.net, 38044@debbugs.gnu.org, larsi@gnus.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Nov 22 00:57:28 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iXwKE-0017dr-VA for geb-bug-gnu-emacs@m.gmane.org; Fri, 22 Nov 2019 00:57:27 +0100 Original-Received: from localhost ([::1]:46654 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iXwKD-00026v-5O for geb-bug-gnu-emacs@m.gmane.org; Thu, 21 Nov 2019 18:57:25 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37431) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iXwJr-00026X-P1 for bug-gnu-emacs@gnu.org; Thu, 21 Nov 2019 18:57:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iXwJq-0008K0-OJ for bug-gnu-emacs@gnu.org; Thu, 21 Nov 2019 18:57:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:44742) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iXwJq-0008JI-Ka for bug-gnu-emacs@gnu.org; Thu, 21 Nov 2019 18:57:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iXwJq-0002bL-ET for bug-gnu-emacs@gnu.org; Thu, 21 Nov 2019 18:57:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 21 Nov 2019 23:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38044 X-GNU-PR-Package: emacs Original-Received: via spool by 38044-submit@debbugs.gnu.org id=B38044.15743805909944 (code B ref 38044); Thu, 21 Nov 2019 23:57:02 +0000 Original-Received: (at 38044) by debbugs.gnu.org; 21 Nov 2019 23:56:30 +0000 Original-Received: from localhost ([127.0.0.1]:53560 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iXwJK-0002aK-3z for submit@debbugs.gnu.org; Thu, 21 Nov 2019 18:56:30 -0500 Original-Received: from bird.elm.relay.mailchannels.net ([23.83.212.17]:22064) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iXwJG-0002a9-Cm for 38044@debbugs.gnu.org; Thu, 21 Nov 2019 18:56:28 -0500 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Original-Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 0E7825A092D; Thu, 21 Nov 2019 23:56:25 +0000 (UTC) Original-Received: from pdx1-sub0-mail-a23.g.dreamhost.com (100-96-15-77.trex.outbound.svc.cluster.local [100.96.15.77]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 86BC45A07EE; Thu, 21 Nov 2019 23:56:24 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Original-Received: from pdx1-sub0-mail-a23.g.dreamhost.com ([TEMPUNAVAIL]. [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.18.5); Thu, 21 Nov 2019 23:56:24 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Fearful-Ski: 5b2e0f3871cfb6e1_1574380584809_3040190497 X-MC-Loop-Signature: 1574380584809:1619877265 X-MC-Ingress-Time: 1574380584809 Original-Received: from pdx1-sub0-mail-a23.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a23.g.dreamhost.com (Postfix) with ESMTP id 33502AA00E; Thu, 21 Nov 2019 15:56:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=linkov.net; bh=QgOHhA2Zs67yLqAjB/i7S61MHio=; b= xv0m4pz86fllhDNIp0191IxohLr4+W0jqsJW/ezfv+84H896yJNAgSWeUe2UyTZU h22niZmQcgmkLAEXWf0MCL9wGAt5I8Yjc1eaPSA5QELK1mUARXw+Ett4QY0qyK6x eOPNpyceEVTq92PGYDiKU03N64mWopybm5jOPo1da3c= Original-Received: from mail.jurta.org (m91-129-102-1.cust.tele2.ee [91.129.102.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a23.g.dreamhost.com (Postfix) with ESMTPSA id 408ABAA010; Thu, 21 Nov 2019 15:56:15 -0800 (PST) X-DH-BACKEND: pdx1-sub0-mail-a23 In-Reply-To: <29e2e877-6dc3-b03b-7463-01cff35e05d1@yandex.ru> (Dmitry Gutov's message of "Thu, 21 Nov 2019 01:37:13 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:172187 Archived-At: > The approach LGTM. I'd have used "describe" or "show", but it's not > important. The name vc-print-revision was modeled after vc-print-log, vc-print-root-log, vc-print-branch-log that are not the best names but at least consistent for their prefix. >> (setq default-directory rootdir) > > This probably needs a saving (let ((default-directory default-directory)) > ...) above it. This is intentional because on testing I discovered that RET on the diff part of the buffer can't visit source files when default-directory is not root. >> + (read-shell-command >> + "Show revision with command: " >> + (format "%s %s" vc-git-program >> + (mapconcat 'identity args " ")) >> + 'vc-git-history) >> + " " t)))) > > If wonder if some user someday is going to try and input there something > that doesn't start with 'git '. Someone might want to use a wrapper script.