From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eric Abrahamsen Newsgroups: gmane.emacs.bugs Subject: bug#33005: 27.0.50; Data loss with Gnus registry Date: Tue, 26 Nov 2019 10:45:03 -0800 Message-ID: <87pnhev5n4.fsf@ericabrahamsen.net> References: <871s8yvsrq.fsf@web.de> <87k17nwkxi.fsf@web.de> <8736ebxxwa.fsf@ericabrahamsen.net> <87k17m1tv0.fsf@web.de> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="103393"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 33005@debbugs.gnu.org To: Michael Heerdegen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Nov 26 19:46:25 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iZfqy-000QlJ-B3 for geb-bug-gnu-emacs@m.gmane.org; Tue, 26 Nov 2019 19:46:24 +0100 Original-Received: from localhost ([::1]:58046 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iZfqx-0002Gt-5v for geb-bug-gnu-emacs@m.gmane.org; Tue, 26 Nov 2019 13:46:23 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57660) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iZfqe-0002Gn-D0 for bug-gnu-emacs@gnu.org; Tue, 26 Nov 2019 13:46:05 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iZfqc-00050G-Gw for bug-gnu-emacs@gnu.org; Tue, 26 Nov 2019 13:46:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:46972) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iZfqb-0004ye-Sa for bug-gnu-emacs@gnu.org; Tue, 26 Nov 2019 13:46:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iZfqb-0007cn-Qe for bug-gnu-emacs@gnu.org; Tue, 26 Nov 2019 13:46:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eric Abrahamsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 26 Nov 2019 18:46:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33005 X-GNU-PR-Package: emacs Original-Received: via spool by 33005-submit@debbugs.gnu.org id=B33005.157479391429248 (code B ref 33005); Tue, 26 Nov 2019 18:46:01 +0000 Original-Received: (at 33005) by debbugs.gnu.org; 26 Nov 2019 18:45:14 +0000 Original-Received: from localhost ([127.0.0.1]:52945 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iZfpp-0007bg-VL for submit@debbugs.gnu.org; Tue, 26 Nov 2019 13:45:14 -0500 Original-Received: from ericabrahamsen.net ([52.70.2.18]:54824 helo=mail.ericabrahamsen.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iZfpo-0007bP-6G for 33005@debbugs.gnu.org; Tue, 26 Nov 2019 13:45:12 -0500 Original-Received: from localhost (c-73-254-86-141.hsd1.wa.comcast.net [73.254.86.141]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id BBBDBFA086; Tue, 26 Nov 2019 18:45:04 +0000 (UTC) In-Reply-To: <87k17m1tv0.fsf@web.de> (Michael Heerdegen's message of "Tue, 26 Nov 2019 17:32:19 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:172469 Archived-At: On 11/26/19 17:32 PM, Michael Heerdegen wrote: > Eric Abrahamsen writes: > >> Well damn. And we're coming up on Emacs 27.1, too... I've never seen >> this before -- would you mind sending all your registry-related config >> (off-list, if necessary), and anything else you might think is relevant, >> and I'll try to reproduce? > > Ok, I debugged it. FWIW I recently learned that "I'll try to reproduce" > has a meaning that I didn't expect: you need to say "I'll try to > reproduce it" or else Stallman might show up and laugh at you (it > happened to me). Who knew such dangers lurked on this list?! > Ok: I have only (gnus-registry-initialize) in my init file. And this is > already broken: > > "gnus-registry.el" initializes gnus-registry-db like this: > > (defvar gnus-registry-db (gnus-registry-make-db) > "The article registry by Message ID. See `registry-db'.") > > and in `gnus-registry-load' the > > (null (eieio-object-p gnus-registry-db)) > > always fails so unless you call `gnus-registry-load' with the force arg > you always start with an empty db. Oh I see, when the file is loaded the variable is already initialized to an (unloaded) registry object, so it never actually loads/reads its persistence file. Except that it certainly seems to! I've never seen this cause a problem, and no one calls `gnus-registry-load' with the FORCE argument, so if this was an issue, it seems like it would fail for everyone immediately... In fact, I don't know the defvar is initialized to anything at all. For eieio-persistent objects, you're not supposed to make-instance yourself, you're supposed to use `eieio-persistent-read' (which is what loading is supposed to do). Dunno why it works, though...