From: Juri Linkov <juri@linkov.net>
To: martin rudalics <rudalics@gmx.at>
Cc: 38354@debbugs.gnu.org
Subject: bug#38354: 27.0.50; Implement display action display-buffer-in-tab
Date: Wed, 04 Dec 2019 01:36:31 +0200 [thread overview]
Message-ID: <87pnh5m16o.fsf@mail.linkov.net> (raw)
In-Reply-To: <d671cb62-27cd-a3fd-caac-2c38ccab5432@gmx.at> (martin rudalics's message of "Tue, 3 Dec 2019 10:18:02 +0100")
>>> There is one thing I apparently do not understand yet: When you enable
>>> 'tab-bar-mode' it is global
>>
>> Do you think we should have 'global-tab-bar-mode' for all frames,
>> and 'tab-bar-mode' to enable/disable the tab-bar in every frame
>> separately?
>
> In the sense that we can enable menu or tool bars for frames
> individually? I think so, yes.
Oh, this also means redesigning tool-bar-mode and menu-bar-mode?
Then I'm not sure. But generally sounds like the right thing to do
sometime.
>>> - that is any window ever shown on any frame is also in at least one
>>> of that frame's tabs. Is that right? So what would 'use-tabs' mean
>>> here when every window is in a tab already?
>>
>> These windows in tabs are in window-configurations and window-states.
>> Now I installed tab-bar-get-buffer-tab
>
> "Return a tab whose window contains BUFFER-OR-NAME, or nil if none."
>
> is a bit misleading, maybe
>
> "Return a tab with a|owning a window whose buffer is BUFFER-OR-NAME."
Done.
> is better. Also the 'lambda's following the 'seq-some' should be
> moved to a new line to keep line lengths within their limits.
Done.
> In either case, do I read the code correctly that it can prefer a
> window in a non-current tab to a window in a current tab on another
> frame. If so, do we want that?
Do you think it should return a list of all tabs owning a window
with the buffer?
> An aside: Are you sure that 'tab-bar-tabs' should always work on the
> selected frame and not take a frame as argument?
Thanks for the idea, implemented.
>> that can be used
>> in display-buffer-reuse-window to search the buffer
>> in window-states of tabs when use-tabs is non-nil.
>
> Given my observation above, this can make a tab current in frame A
> although the current tab of frame B already shows the buffer. Right?
Why not? Does display-buffer-reuse-window currently prefers
a window on the same frame even when a window on another frame
also shows the same buffer?
>> If t, start a new tab with the current buffer, i.e. the buffer
>> that was current before calling the command that adds a new tab
>> (this is the same what `make-frame' does by default).
>
> OK. Then my next nitpick is that the doc-string of
> 'tab-bar-new-tab-choice' says
>
> If the value is a string, use it as a buffer name switch to a buffer
>
> which apparently should have "... name. Switch ..." instead.
Fixed.
Additional question: using quit-window on the buffer displayed
by display-buffer-in-tab should close its tab. Could you recommend
how to implement this? Maybe to add an additional argument CLOSE-TAB
to quit-restore-window? e.g.
(defun quit-restore-window (&optional window bury-or-kill close-tab)
...
For testing I tried to call '(tab-bar-close-tab)' at the end of
'quit-restore-window' unconditionally, but sometimes it does wrong thing:
when quitting the last window of the frame closes the frame,
'(tab-bar-close-tab)' closes the tab on another frame that
is selected after closing the original frame.
next prev parent reply other threads:[~2019-12-03 23:36 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-23 23:09 bug#38354: 27.0.50; Implement display action display-buffer-in-tab Juri Linkov
2019-11-26 9:32 ` martin rudalics
2019-11-26 22:30 ` Juri Linkov
2019-11-26 22:43 ` Juri Linkov
2019-11-27 9:49 ` martin rudalics
2019-11-27 21:37 ` Juri Linkov
2019-11-28 9:20 ` martin rudalics
2019-11-28 23:02 ` Juri Linkov
2019-11-29 9:24 ` martin rudalics
2019-12-01 22:29 ` Juri Linkov
2019-12-02 9:40 ` martin rudalics
2019-12-02 23:43 ` Juri Linkov
2019-12-03 9:18 ` martin rudalics
2019-12-03 23:36 ` Juri Linkov [this message]
2019-12-04 9:22 ` martin rudalics
2019-12-04 22:51 ` Juri Linkov
2019-12-05 9:05 ` martin rudalics
2019-12-05 23:54 ` Juri Linkov
2019-12-06 7:37 ` martin rudalics
2022-12-06 17:40 ` Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pnh5m16o.fsf@mail.linkov.net \
--to=juri@linkov.net \
--cc=38354@debbugs.gnu.org \
--cc=rudalics@gmx.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).