From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Alexis Newsgroups: gmane.emacs.bugs Subject: bug#38602: 26.3; gnutls-negotiate fails to handle :verify-error being set to t Date: Thu, 26 Dec 2019 15:19:45 +1100 Message-ID: <87pngbpvku.fsf@ada> References: <875zijbq2z.fsf@ada> Mime-Version: 1.0 Content-Type: text/plain; format=flowed Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="13224"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: mu4e 1.3.5; emacs 26.3 Cc: 38602@debbugs.gnu.org To: Robert Pluim Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Dec 26 05:21:14 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1ikKe7-0003KW-Aq for geb-bug-gnu-emacs@m.gmane.org; Thu, 26 Dec 2019 05:21:11 +0100 Original-Received: from localhost ([::1]:51052 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ikKe5-0006yn-Fv for geb-bug-gnu-emacs@m.gmane.org; Wed, 25 Dec 2019 23:21:09 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47890) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ikKdz-0006xH-BE for bug-gnu-emacs@gnu.org; Wed, 25 Dec 2019 23:21:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ikKdy-0004RU-C6 for bug-gnu-emacs@gnu.org; Wed, 25 Dec 2019 23:21:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:48881) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ikKdy-0004RO-5r for bug-gnu-emacs@gnu.org; Wed, 25 Dec 2019 23:21:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ikKdy-0001Ku-0r for bug-gnu-emacs@gnu.org; Wed, 25 Dec 2019 23:21:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Alexis Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 26 Dec 2019 04:21:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38602 X-GNU-PR-Package: emacs Original-Received: via spool by 38602-submit@debbugs.gnu.org id=B38602.15773340465083 (code B ref 38602); Thu, 26 Dec 2019 04:21:01 +0000 Original-Received: (at 38602) by debbugs.gnu.org; 26 Dec 2019 04:20:46 +0000 Original-Received: from localhost ([127.0.0.1]:54854 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ikKdh-0001Jv-Mz for submit@debbugs.gnu.org; Wed, 25 Dec 2019 23:20:45 -0500 Original-Received: from mail-pj1-f66.google.com ([209.85.216.66]:36807) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ikKdf-0001Jf-8j for 38602@debbugs.gnu.org; Wed, 25 Dec 2019 23:20:44 -0500 Original-Received: by mail-pj1-f66.google.com with SMTP id n59so2933084pjb.1 for <38602@debbugs.gnu.org>; Wed, 25 Dec 2019 20:20:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version; bh=unbid1fwsDwdma5TzR51YgrN1uZOI2kRFGIxXcqC37s=; b=EdhRvojI01qVa/utwOnJiWYLMiQJFtzc5XNEwExO4mPEAwk9TSIuTCCX9Be7/aC4kA TKe5poE1AqyUtRyF6GrGtyoTUFCgMnEgMM7fQi+GVCUeqfDcp4PQDKQRCxnUQq4VZZBD hW5dippkSTUMfD1bRPxzevWhPC49NGbubcrudbFngdgKa4q8obFdSKTudkVSxt6b6wPh ZkPW0GOk4AaFomPcbLVFfEnTGTqvCB2W2/r0umXZDt/z3sX5ndhn3NeNXWbUllLPsJBy KldR8/gZnmZ0t03K7PCyGd4i5tVO0Y0ZXMf/aV/b4OjDXSg4jTxkK4SPyVlta/ZRf/YH IsuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:date:message-id:mime-version; bh=unbid1fwsDwdma5TzR51YgrN1uZOI2kRFGIxXcqC37s=; b=PZBgJy5Rfz5t44Ypk8Hhnd1nYrekjr62vBfRj2EwNZOCeLyQwQEvk8EOotBlSGto3o e1D7R7Q0nmWdZ9aXWYZVSXUk639Xz7XTO7gqhC40XHKfTaYVkgzdqdQaetdTY6M4/7GF sFgKdIhyuQ1ynOgBPykmWJiobSyVzKZa2D0h0JN8/8ApsFAB/sgvTureOoRm7nJKYHqJ fn+VHRMKLiojJVqPsiEIumFekLXeIhcSSjHJOWDd+6aWcsyqqN3Su5WJJ3+Z4S27JJsF 2pETPgxm6+1kU3jAD78SUzwaoSRx/bb/DsHvHVJyMcs4sfYCAQFYrbHbriuIht5wPhbc yFtg== X-Gm-Message-State: APjAAAVSCwBzBA/Vxk8t640N5GHSojDqSWcymLzAYDkU7Bv9Vq/4h6N8 2Hj8iIQmTXaIy5iJBxB4yjw= X-Google-Smtp-Source: APXvYqxpYyw4h54cbSslBGOmjrHHsSYREcr6+t+cAd03IrPI+lGl8aey3jN6iUOZ4wU/v3sDltvfDw== X-Received: by 2002:a17:902:8649:: with SMTP id y9mr44913341plt.67.1577334037428; Wed, 25 Dec 2019 20:20:37 -0800 (PST) Original-Received: from localhost ([60.224.133.205]) by smtp.gmail.com with ESMTPSA id k190sm31437405pga.73.2019.12.25.20.20.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Dec 2019 20:20:36 -0800 (PST) In-reply-to: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:173773 Archived-At: Robert Pluim writes: > How about this? Producing a list (:hostname t) is not what you > want, > since that removes the 'check everything' feature of specifying > just > 't'. > > diff --git a/lisp/net/gnutls.el b/lisp/net/gnutls.el > index 9b13adaefe..14368bc298 100644 > --- a/lisp/net/gnutls.el > +++ b/lisp/net/gnutls.el > @@ -345,8 +345,11 @@ gnutls-boot-parameters > (t nil)))) > (min-prime-bits (or min-prime-bits > gnutls-min-prime-bits))) > > - (when verify-hostname-error > - (push :hostname verify-error)) > + ;; Only add :hostname if `verify-error' is not t, since t > + ;; means "include :hostname" Bug#38602. > + (and verify-hostname-error > + (not (eq verify-error t)) > + (push :hostname verify-error)) > > `(:priority ,priority-string > :hostname ,hostname Thank you for your prompt response - sorry to have taken so long to get back to you. Unfortunately, this diff didn't work for me - it results in the error: STARTTLS negotation failed: GnuTLS error: #, nil Alexis.