From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#39274: Warn when using obsolete command interactively Date: Sat, 25 Jan 2020 20:22:52 +0100 Message-ID: <87pnf78ho3.fsf@marxist.se> References: <878slw8mj4.fsf@marxist.se> <837e1gq8pt.fsf@gnu.org> <87sgk38hw6.fsf@marxist.se> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="84347"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 39274@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jan 25 20:23:12 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ivR1T-000Ltf-No for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 25 Jan 2020 20:23:11 +0100 Original-Received: from localhost ([::1]:56832 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ivR1S-0005Z6-Oq for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 25 Jan 2020 14:23:10 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40058) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ivR1L-0005Yo-Q4 for bug-gnu-emacs@gnu.org; Sat, 25 Jan 2020 14:23:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ivR1K-000328-N9 for bug-gnu-emacs@gnu.org; Sat, 25 Jan 2020 14:23:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:50363) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ivR1K-00031V-Jl for bug-gnu-emacs@gnu.org; Sat, 25 Jan 2020 14:23:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ivR1K-0002mV-Et for bug-gnu-emacs@gnu.org; Sat, 25 Jan 2020 14:23:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 25 Jan 2020 19:23:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39274 X-GNU-PR-Package: emacs Original-Received: via spool by 39274-submit@debbugs.gnu.org id=B39274.157998018110669 (code B ref 39274); Sat, 25 Jan 2020 19:23:02 +0000 Original-Received: (at 39274) by debbugs.gnu.org; 25 Jan 2020 19:23:01 +0000 Original-Received: from localhost ([127.0.0.1]:56336 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ivR1J-0002m1-3F for submit@debbugs.gnu.org; Sat, 25 Jan 2020 14:23:01 -0500 Original-Received: from ted.gofardesign.uk ([67.225.143.91]:54026) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ivR1H-0002ln-Nv for 39274@debbugs.gnu.org; Sat, 25 Jan 2020 14:23:00 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=marxist.se; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=LHXJupoVdsmK/mcIQ4jXE/c/pKNdvYqkvNCxKZIPQPM=; b=BIEPXSlVx7s8tBY7CHKKn7F1C0 xrgq3FcR/TnkoXB7nAlkf8/Mv94EM61F7S+4KpK9u8BucLQBpf+DcpBaeasYfJ7tDOxwLWkLLKltT IQ6VYPjQ9v1FUCNyrzXNpdEQ084RxLpv+/wlsJZ2nX2bpAiG58fY+5/YV3zq6eAJ9pbeLGbl1nNlk 2TrStu0SX1ksBzhQ3zAMhr6ENMLwOCs0lcIoKcFwL+DZ/K7DiDInuM1SQ7IkA3zArh1WcsZj9EOSP /VCTrb7OrHqfYNIMc8S5YsxsQ0J+XVyBsQIofob7s+rwFOOWVfDNSkJqvACtYJmDDrZLwi1d+NZRJ ly/XfUfA==; Original-Received: from h-70-69.a785.priv.bahnhof.se ([155.4.70.69]:48812 helo=localhost) by ted.gofardesign.uk with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1ivR1C-0017VV-6y; Sat, 25 Jan 2020 14:22:54 -0500 In-Reply-To: <87sgk38hw6.fsf@marxist.se> (Stefan Kangas's message of "Sat, 25 Jan 2020 20:18:01 +0100") X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - ted.gofardesign.uk X-AntiAbuse: Original Domain - debbugs.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - marxist.se X-Get-Message-Sender-Via: ted.gofardesign.uk: authenticated_id: stefan@marxist.se X-Authenticated-Sender: ted.gofardesign.uk: stefan@marxist.se X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:175279 Archived-At: --=-=-= Content-Type: text/plain Stefan Kangas writes: >>> Please add a warning along these lines: >>> >>> (message "The `%s' command is obsolete since version %s, use `%s' instead" >>> obsolete-name version current-name) >> >> Where and when will this warning be displayed? > > I was thinking of something along the lines of the below patch. Sorry, that had a typo. See attached instead. Best regards, Stefan Kangas --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=obsolete2.diff diff --git a/lisp/simple.el b/lisp/simple.el index 8be27745b1..f1f0da1fed 100644 --- a/lisp/simple.el +++ b/lisp/simple.el @@ -1914,6 +1914,12 @@ execute-extended-command (while-no-input (setq binding (execute-extended-command--shorter (symbol-name function) typed)))) + (when-let (obsolete (with-temp-buffer + (when (help-fns--obsolete function) + (buffer-string) + (goto-char (point-max)) + (delete-indentation 2)))) + (message obsolete)) (when binding (with-temp-message (format-message "You can run the command `%s' with %s" --=-=-=--