From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Andreas Schwab Newsgroups: gmane.emacs.bugs Subject: bug#41347: 28.0.50; calculator.el: Cannot input negative exponents Date: Sun, 17 May 2020 13:57:50 +0200 Message-ID: <87pnb2wz7l.fsf@igel.home> References: <20200517055312.jtwughazs453lbzt@Kael> <60FECFFF-BF00-4D6A-9297-105B1E1B69C8@acm.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="129770"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.91 (gnu/linux) Cc: 41347@debbugs.gnu.org, Chris Zheng , Eli Barzilay To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun May 17 13:58:12 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jaHvo-000XgW-IF for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 17 May 2020 13:58:12 +0200 Original-Received: from localhost ([::1]:51430 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jaHvn-0003YL-HO for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 17 May 2020 07:58:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51096) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jaHvh-0003YE-1n for bug-gnu-emacs@gnu.org; Sun, 17 May 2020 07:58:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:59155) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jaHve-0004Gc-JS for bug-gnu-emacs@gnu.org; Sun, 17 May 2020 07:58:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jaHve-0005O5-Ht for bug-gnu-emacs@gnu.org; Sun, 17 May 2020 07:58:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Andreas Schwab Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 17 May 2020 11:58:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41347 X-GNU-PR-Package: emacs Original-Received: via spool by 41347-submit@debbugs.gnu.org id=B41347.158971667620698 (code B ref 41347); Sun, 17 May 2020 11:58:02 +0000 Original-Received: (at 41347) by debbugs.gnu.org; 17 May 2020 11:57:56 +0000 Original-Received: from localhost ([127.0.0.1]:42468 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jaHvY-0005Nm-LA for submit@debbugs.gnu.org; Sun, 17 May 2020 07:57:56 -0400 Original-Received: from mail-out.m-online.net ([212.18.0.10]:49145) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jaHvW-0005Nc-PA for 41347@debbugs.gnu.org; Sun, 17 May 2020 07:57:55 -0400 Original-Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 49Q0yT0mddz1rsXX; Sun, 17 May 2020 13:57:52 +0200 (CEST) Original-Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 49Q0yS5MKQz1qqkG; Sun, 17 May 2020 13:57:52 +0200 (CEST) X-Virus-Scanned: amavisd-new at mnet-online.de Original-Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id heV_4hmrN85v; Sun, 17 May 2020 13:57:51 +0200 (CEST) X-Auth-Info: 2jvUywQaQ4ouX1RebT67O1nzdZTaPdeRFn9uCDfxkLhfE5gZAm93FvaFWFLCl/1D Original-Received: from igel.home (ppp-46-244-186-105.dynamic.mnet-online.de [46.244.186.105]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Sun, 17 May 2020 13:57:51 +0200 (CEST) Original-Received: by igel.home (Postfix, from userid 1000) id 1AB3E2C0B37; Sun, 17 May 2020 13:57:51 +0200 (CEST) X-Yow: What I need is a MATURE RELATIONSHIP with a FLOPPY DISK... In-Reply-To: <60FECFFF-BF00-4D6A-9297-105B1E1B69C8@acm.org> ("Mattias =?UTF-8?Q?Engdeg=C3=A5rd?="'s message of "Sun, 17 May 2020 13:08:30 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:180449 Archived-At: On Mai 17 2020, Mattias Engdegård wrote: >> @@ -863,7 +863,7 @@ calculator-string-to-number >> (let* ((str (replace-regexp-in-string >> "\\.\\([^0-9].*\\)?$" ".0\\1" str)) >> (str (replace-regexp-in-string >> - "[eE][+-]?\\([^0-9].*\\)?$" "e0\\1" str))) >> + "[eE]\\([+-]?\\)?$" "e\\10" str))) >> (float (string-to-number str))))) > > Thanks for the report and the suggested patch! However, I'm not sure what either of these replace-regexp-in-string calls are good for. The first one possibly to accept 1.e23 instead of 1e23; the second one is less clear. Frankly, I think we can drop both. In commit f248292ede, there was - ((string-match-p "[eE][+-]?$" str) (concat str "0")) so the bug is that the part matching "[+-]?" is now dropped. Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."