From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#39354: enhancement request: hideshow should handle derived modes Date: Fri, 21 Aug 2020 14:42:48 +0200 Message-ID: <87pn7k5fw7.fsf@gnus.org> References: <1405743405.6348.1580376275497@email.ionos.de> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34097"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 39354@debbugs.gnu.org To: Tobias Zawada Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Aug 21 14:44:10 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k96Ow-0008le-8G for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 21 Aug 2020 14:44:10 +0200 Original-Received: from localhost ([::1]:51050 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k96Ov-0004AW-7i for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 21 Aug 2020 08:44:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36004) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k96Oo-0004A1-Pb for bug-gnu-emacs@gnu.org; Fri, 21 Aug 2020 08:44:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:33793) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1k96Oo-0002ss-GG for bug-gnu-emacs@gnu.org; Fri, 21 Aug 2020 08:44:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1k96Oo-00086Q-Dl for bug-gnu-emacs@gnu.org; Fri, 21 Aug 2020 08:44:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 21 Aug 2020 12:44:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39354 X-GNU-PR-Package: emacs Original-Received: via spool by 39354-submit@debbugs.gnu.org id=B39354.159801378531041 (code B ref 39354); Fri, 21 Aug 2020 12:44:02 +0000 Original-Received: (at 39354) by debbugs.gnu.org; 21 Aug 2020 12:43:05 +0000 Original-Received: from localhost ([127.0.0.1]:45336 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k96Nq-00084L-3h for submit@debbugs.gnu.org; Fri, 21 Aug 2020 08:43:05 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:42074) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k96Nn-00083w-Q6 for 39354@debbugs.gnu.org; Fri, 21 Aug 2020 08:43:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Lt1o4MAI/JT0jVPFlpj/m+J+3qqsu5htwwg7sv8k0p4=; b=our+XsNHFV48GBLeYWrYW/N1LR n7XCFHYoJZKorPJj05De/Ib0uKkXBLZjcE2rZq8/ylsG3y2xyjDwhenZ294vKzs3YvjgHLjRQNxfv s6eO03Xgad/mtEL6RH7/n+MTyH//2LP5VM7NAWVYvxMheXvwLaTn9jt8nJUxcurqM0ok=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k96Nd-0003kJ-Pv; Fri, 21 Aug 2020 14:42:53 +0200 X-Now-Playing: The Raincoats's _The Raincoats_: "Black and White" In-Reply-To: <1405743405.6348.1580376275497@email.ionos.de> (Tobias Zawada's message of "Thu, 30 Jan 2020 10:24:35 +0100 (CET)") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:185851 Archived-At: Tobias Zawada writes: > hideshow.el should handle derived modes. > See discussion on emacs.SE about hideshow in sage-shell-mode (link: https://emacs.stackexchange.com/questions/55129/hs-minor-mode-and-sage-shell-mode-derived-from-python-mode#comment86297_55129). > > I propose following change on `hs-grok-mode-type` (perma-link: > https://github.com/jwiegley/emacs-release/blob/adfd5933358fdf6715423dee8169eb3cd7d982db/lisp/progmodes/hideshow.el#L666): [...] > - (let* ((lookup (assoc major-mode hs-special-modes-alist)) > + (let* ((lookup (cl-assoc-if (lambda (mode) > + (derived-mode-p major-mode mode)) > + hs-special-modes-alist)) Makes sense to me, so I've applied your patch to Emacs 28. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no