From: Lars Ingebrigtsen <larsi@gnus.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: Stephen Berman <stephen.berman@gmx.net>, 13648@debbugs.gnu.org
Subject: bug#13648: 24.3.50; remove-overlays bugs
Date: Tue, 25 Aug 2020 16:23:26 +0200 [thread overview]
Message-ID: <87pn7e7qjl.fsf@gnus.org> (raw)
In-Reply-To: <jwvh7sqltwh.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Tue, 25 Aug 2020 09:55:43 -0400")
Stefan Monnier <monnier@iro.umontreal.ca> writes:
>> The case here is (remove-overlay beg end 'foo), which will remove all
>> overlays that don't have foo (as well as the ones that have foo, but
>> it's set to nil)?
>
> I think the case you describe is indeed never useful, but it *is*
> implemented, AFAIK.
>
> The more useful interpretation I think would be for
> (remove-overlay beg end 'foo) to remove all overlays that have a non-nil
> value of `foo`. But I haven't implemented it because (despite my
> impression that it would be more useful) I haven't actually found any
> need for it.
Yeah, and perhaps that'll break something... In any case, it's
probably not worth mentioning in the doc string. :/
>> (defun remove-overlays (&optional beg end name val)
>> "Clear BEG and END of overlays whose property NAME has value VAL.
>
> As Eli points out, I wasn't very inspired when I wrote this first line.
> We should at very least replace "BEG and END" with "BEG...END" or
> something like that.
Yup. I've added more text there.
>> +BEG and END default respectively to the beginning and end of buffer.
>> +Values are compared with `eq'.
>> +If either NAME or VAL are specified, both should be specified."
>
> LGTM,
Pushed to the trunk.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
prev parent reply other threads:[~2020-08-25 14:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-07 15:09 bug#13648: 24.3.50; remove-overlays bugs Stephen Berman
2013-02-07 16:42 ` Stefan Monnier
2013-02-07 19:16 ` Stephen Berman
2013-02-08 1:45 ` Stefan Monnier
2013-02-08 14:50 ` Stephen Berman
2020-08-25 11:44 ` Lars Ingebrigtsen
2020-08-25 13:02 ` Eli Zaretskii
2020-08-25 13:55 ` Stefan Monnier
2020-08-25 14:23 ` Lars Ingebrigtsen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pn7e7qjl.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=13648@debbugs.gnu.org \
--cc=monnier@iro.umontreal.ca \
--cc=stephen.berman@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).