From: Lars Ingebrigtsen <larsi@gnus.org>
To: "Håkon Hægland" <hakon.hagland@gmail.com>, 32266@debbugs.gnu.org
Subject: bug#32266: Cannot add directory names ending in .el with normal-top-level-add-subdirs-to-load-path
Date: Wed, 26 Aug 2020 14:50:13 +0200 [thread overview]
Message-ID: <87pn7dzi4a.fsf@gnus.org> (raw)
In-Reply-To: <87o9dj3on5.fsf@gmail.com> (Robert Pluim's message of "Thu, 30 Aug 2018 16:38:54 +0200")
Robert Pluim <rpluim@gmail.com> writes:
> The comment just above says
>
> ;; Avoid doing a `stat' when it isn't necessary because
> ;; that can cause trouble when an NFS server is down.
>
> which has been there for a long time. If an NFS server *is* down, then
> that will manifest itself with other files anyway, so I don't see why
> we'd need special handling here. I propose:
Yeah, that's just odd. And having directories called .el isn't that
strange, anyway, so I've applied your patch to Emacs 28:
> - ;; Avoid doing a `stat' when it isn't necessary because
> - ;; that can cause trouble when an NFS server is down.
> - (not (string-match "\\.elc?\\'" file))
I did a "make" and "make bootstrap" and I can't see any adverse effects.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
prev parent reply other threads:[~2020-08-26 12:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-25 7:12 bug#32266: Cannot add directory names ending in .el with normal-top-level-add-subdirs-to-load-path Håkon Hægland
2018-08-30 14:38 ` Robert Pluim
2020-08-26 12:50 ` Lars Ingebrigtsen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pn7dzi4a.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=32266@debbugs.gnu.org \
--cc=hakon.hagland@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).