From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#43202: patch Date: Fri, 04 Sep 2020 15:29:56 +0200 Message-ID: <87pn71acvf.fsf@gnus.org> References: <87tuwdr90r.fsf@dick> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33115"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 43202@debbugs.gnu.org To: dick.r.chiang@gmail.com Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Sep 04 15:31:30 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kEBoQ-0008VL-EG for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 04 Sep 2020 15:31:30 +0200 Original-Received: from localhost ([::1]:46970 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kEBoP-0002Nl-DR for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 04 Sep 2020 09:31:29 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48628) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kEBny-0002B0-Mj for bug-gnu-emacs@gnu.org; Fri, 04 Sep 2020 09:31:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:54705) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kEBny-0004XN-DP for bug-gnu-emacs@gnu.org; Fri, 04 Sep 2020 09:31:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kEBny-0004KK-93 for bug-gnu-emacs@gnu.org; Fri, 04 Sep 2020 09:31:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 04 Sep 2020 13:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43202 X-GNU-PR-Package: emacs Original-Received: via spool by 43202-submit@debbugs.gnu.org id=B43202.159922621413677 (code B ref 43202); Fri, 04 Sep 2020 13:31:02 +0000 Original-Received: (at 43202) by debbugs.gnu.org; 4 Sep 2020 13:30:14 +0000 Original-Received: from localhost ([127.0.0.1]:38014 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kEBnC-0003YD-Ja for submit@debbugs.gnu.org; Fri, 04 Sep 2020 09:30:14 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:48716) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kEBnA-0003Q5-Nf for 43202@debbugs.gnu.org; Fri, 04 Sep 2020 09:30:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=TKmH2vgUMQ2nroBjepxaaML6erBhZ9RFAb8T2mEvdLY=; b=NGqtEVvG6ExA8/5Tlf44RfEmat QerPdA1OEXb2RjS5+yazX2DR5KNqQeIwMiaQC9ddJBVoBaeFDwuo7/SePG8SSgwi15LWw8oQegDok VfIyyk+yjcTXBGQ6vcYSSlBTYPFzZOq8f+lFkGNfHUIUZr/c2RumJHs2TaJ8BKmOHM4Q=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kEBmw-00086E-7m; Fri, 04 Sep 2020 15:30:06 +0200 X-Now-Playing: The Pentangle's _Cruel Sister_: "Jack Orion" In-Reply-To: <87tuwdr90r.fsf@dick> (dick r. chiang's message of "Fri, 04 Sep 2020 09:01:08 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:187133 Archived-At: dick.r.chiang@gmail.com writes: Looks good. Some comments: > * lisp/simple.el (list-processes--refresh): network, serial, *or pipe*. > * test/src/process-tests.el (process-test-stopped-pipe): add a test. These aren't really descriptive (and each sentence should start with a capital letter). > +(ert-deftest process-test-stopped-pipe () > + (skip-unless (executable-find "cat")) > + (with-temp-buffer > + (let ((proc (make-pipe-process :name "pipe" :buffer (current-buffer) > + :command '("cat") :stop t))) > + (unwind-protect > + (should (list-processes--refresh)) > + (delete-process proc))))) I don't think this test is correct -- you're really checking that list-processes--refresh doesn't bug out; not that it returns non-nil (it doesn't have a well-defined return value). So if this is to be checked for (I'm not sure it adds much value as a test), then it should check whether it errors out or not (and the value should be disregarded). -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no