From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#9409: bug#14531: 24.3.50; `log-view-file-prev' doesn't move to the beginning of the log buffer Date: Fri, 25 Sep 2020 13:01:43 +0200 Message-ID: <87pn6aqfvs.fsf@gnus.org> References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23218"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 9409@debbugs.gnu.org, 14531@debbugs.gnu.org To: Xue Fuqiao Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Sep 25 13:02:35 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kLlUp-0005ue-88 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 25 Sep 2020 13:02:35 +0200 Original-Received: from localhost ([::1]:46340 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kLlUo-0003hE-8b for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 25 Sep 2020 07:02:34 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52864) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kLlUJ-0003fr-8q for bug-gnu-emacs@gnu.org; Fri, 25 Sep 2020 07:02:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:59511) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kLlUI-0004d5-Vb for bug-gnu-emacs@gnu.org; Fri, 25 Sep 2020 07:02:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kLlUI-0000PZ-Tj for bug-gnu-emacs@gnu.org; Fri, 25 Sep 2020 07:02:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 25 Sep 2020 11:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 9409 X-GNU-PR-Package: emacs Original-Received: via spool by 9409-submit@debbugs.gnu.org id=B9409.16010317161203 (code B ref 9409); Fri, 25 Sep 2020 11:02:02 +0000 Original-Received: (at 9409) by debbugs.gnu.org; 25 Sep 2020 11:01:56 +0000 Original-Received: from localhost ([127.0.0.1]:42821 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kLlUC-0000J1-9E for submit@debbugs.gnu.org; Fri, 25 Sep 2020 07:01:56 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:38706) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kLlUA-0000DK-6d; Fri, 25 Sep 2020 07:01:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=yPoS/mbvqA0gCYdkvJ9UMk6ihmU2txNaO6gTeKnoq5E=; b=FcRi2fxGv7cA3BUj5CnFja7a4/ oBuAc4AvAumFsIP3mVX7ix51ca6ghoAu5ucnW1BvPDrFAVoBX79z6SxOgeG2AyOp5/WitXUU4Bvni BD9RwiMuwbltSwENSoi6q8ZoEuIRArIWBB9KNmBPFDVp1vECrMypMBjzn0KjgE3iSpWw=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kLlU1-0001Rw-0Z; Fri, 25 Sep 2020 13:01:47 +0200 X-Now-Playing: Thievery Corporation's _The Mirror Conspiracy_: "The Mirror Conspiracy" In-Reply-To: (Xue Fuqiao's message of "Sun, 2 Jun 2013 10:53:34 +0800") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:188948 Archived-At: Xue Fuqiao writes: > In (info "(emacs) VC Change Log"): > `P' > Move to the log of the previous file, if showing logs for a > multi-file VC fileset. Otherwise, just move to the beginning of > the log. A numeric prefix argument is a repeat count. > > I tried visiting a random Emacs Lisp file (calc.el) in the bzr repo, and > then execute `vc-print-log'. It isn't a multi-file fileset, but > pressing `P' does not move to the beginning of the log buffer. Instead, > an error message "No previous file" occurs. I'm not sure what that command is meant to do, even after reading the documentation and reading the code (and even reading the code doesn't help that much, because these are easy-mmode-define-navigation incantation). It searches for the prev instance of: log-view-file-re "^\\(?:Working file: \\(?1:.+\\)\\|\\(?:SCCS/s\\.\\|Changes to \\)\\(?1:.+\\):\\) " in the *vc-change-log* buffer? But ... there's nothing like that in a git buffer? So `P'/`N' always fails for me. Is this just code that has bitrotted, or is the use case just not... explained well? This bug was merged with: Eduard Wiebe writes: > it bothers me that in some situation i cannot reach the head information > of the `vc-print-log' via `log-view-msg-prev'. > > I fixed the issue by following simple patch. [...] > - (error "No previous %s" ,name))) > + (goto-char (point-min)) > + (error "No previous %s" ,name))) I don't understand what's meant by "the head information", but the `n'/`p' commands in *vc-change-log* buffers seems to work well for me? Test case: C-x C-f calc.el C-x v l n p p So these seem to be different bugs and the second bug has been fixed in the intervening years? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no