From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#44156: 26.3; ERC: Fix ERC's IBuffer format "crash" on killed server buffer Date: Fri, 23 Oct 2020 14:40:54 +0200 Message-ID: <87pn59f73d.fsf@gnus.org> References: <1823357.Ei5Gdb227I@ravel> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27726"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 44156@debbugs.gnu.org To: Olivier Certner Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Oct 23 14:45:51 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kVwS6-00074P-NH for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 23 Oct 2020 14:45:50 +0200 Original-Received: from localhost ([::1]:50084 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kVwS5-00057N-Ha for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 23 Oct 2020 08:45:49 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44154) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kVwOQ-0000TL-89 for bug-gnu-emacs@gnu.org; Fri, 23 Oct 2020 08:42:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:44727) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kVwOP-0004KP-TI for bug-gnu-emacs@gnu.org; Fri, 23 Oct 2020 08:42:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kVwOP-0000o5-Qv for bug-gnu-emacs@gnu.org; Fri, 23 Oct 2020 08:42:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 23 Oct 2020 12:42:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44156 X-GNU-PR-Package: emacs Original-Received: via spool by 44156-submit@debbugs.gnu.org id=B44156.16034568733016 (code B ref 44156); Fri, 23 Oct 2020 12:42:01 +0000 Original-Received: (at 44156) by debbugs.gnu.org; 23 Oct 2020 12:41:13 +0000 Original-Received: from localhost ([127.0.0.1]:56267 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kVwNb-0000mY-C4 for submit@debbugs.gnu.org; Fri, 23 Oct 2020 08:41:13 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:55024) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kVwNW-0000lq-Ut for 44156@debbugs.gnu.org; Fri, 23 Oct 2020 08:41:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=blXa/SQkp3RVmzCxIxaEPhzsBDSxUiic3uUNFd+YDy0=; b=ix/C7cap6o5l1MY6QFWvdwyccO B03OQuTNdbm5TdxuykjPP8IH2fE7RKTl1UCnWgqM6PirSCANpStZexqSf69tg0owtre8U3gtlzjox IBo8hRU1StF2ULFqM7c9FGCgWaI46f6zQx/c/LNCCYbuwCn6B644d5yWYFY0f0payvBQ=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kVwNM-0000t0-DU; Fri, 23 Oct 2020 14:41:00 +0200 X-Now-Playing: Laraaji & Lyghte's _Celestial Realms_: "Equinox" In-Reply-To: <1823357.Ei5Gdb227I@ravel> (Olivier Certner's message of "Thu, 22 Oct 2020 23:50:27 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:191369 Archived-At: Olivier Certner writes: > Root cause: > The erc-ibuffer's server column code will return nil in this case, since > the buffer associated to its process has been killed, making the server > information inacessible, and this is not tested properly. > > Patch: > Attached. Thanks; looks good to me, so I've applied it to Emacs 28. It was small enough to apply without getting copyright assignment papers for the FSF, but any subsequent patches (that aren't very small) can't be applied without such paperwork. Would you be willing to sign such paperwork? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no