bug#39938: 28.0.50; icalendar.el does not understand "first friday of every month"

bug#39938: 28.0.50; icalendar.el does not understand "first friday of every month"

[Mark A. Hershberger]

Version info:
    In GNU Emacs 28.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.5, cairo version 1.16.0)
     of 2020-03-04 built on silk
    Repository revision: cf45e8022ee182529668c0d50d27b4e168331e97
    Repository branch: master

Entry in my notes.org file contains the following note indicating the
event is the first friday of every month:

    ** Monthly meeting
    :PROPERTIES:
    … elided …
    :RRULE:    FREQ=MONTHLY;INTERVAL=1;BYDAY=1FR
    … elided …
    :END:

      <2019-07-05 11:30-12:30 +1m>


This matches the RRULE line I see when I “View source” on the event in
Zimbra.

Zimbra shows the date correctly as happening on Friday, 2020-03-06.

When I got my agenda for today (Thursday, 2020-03-05) from org-agenda,
it showed the event happening today.

If I use org-agenda-goto-date to find the the days that emacs thinks
this is on in other months, it always picks the 5th.

For example in May, the meeting is on 2020-05-05 (Tuesday) instead of
2020-05-01 (Friday).

This bug is similar to #39782 in that it deals with icalendar and
repeating days.

bug#39938: 28.0.50; icalendar.el does not understand "first friday of every month"

[Lars Ingebrigtsen]

"Mark A. Hershberger" <mah@everybody.org> writes:

> Entry in my notes.org file contains the following note indicating the
> event is the first friday of every month:
>
>     ** Monthly meeting
>     :PROPERTIES:
>     … elided …
>     :RRULE:    FREQ=MONTHLY;INTERVAL=1;BYDAY=1FR
>     … elided …
>     :END:
>
>       <2019-07-05 11:30-12:30 +1m>
>
> This matches the RRULE line I see when I “View source” on the event in
> Zimbra.
>
> Zimbra shows the date correctly as happening on Friday, 2020-03-06.
>
> When I got my agenda for today (Thursday, 2020-03-05) from org-agenda,
> it showed the event happening today.

Looking at the code (and the tests), it should understand these BYDAY
clauses.  Do you have a complete .ical file that icalendar doesn't parse
correctly?  That'd help with debugging.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#39938: 28.0.50; icalendar.el does not understand "first friday of every month"

[Mark A. Hershberger]

[-- Attachment #1: Type: text/plain, Size: 234 bytes --]

Lars Ingebrigtsen <larsi@gnus.org> writes:

> Looking at the code (and the tests), it should understand these BYDAY
> clauses.  Do you have a complete .ical file that icalendar doesn't parse
> correctly?  That'd help with debugging.


[-- Attachment #2: sample --]
[-- Type: application/octet-stream, Size: 1044 bytes --]

BEGIN:VCALENDAR
PRODID:Zimbra-Calendar-Provider
VERSION:2.0
METHOD:PUBLISH
BEGIN:VTIMEZONE
TZID:America/New_York
BEGIN:STANDARD
DTSTART:16010101T020000
TZOFFSETTO:-0500
TZOFFSETFROM:-0400
RRULE:FREQ=YEARLY;WKST=MO;INTERVAL=1;BYMONTH=11;BYDAY=1SU
TZNAME:EST
END:STANDARD
BEGIN:DAYLIGHT
DTSTART:16010101T020000
TZOFFSETTO:-0400
TZOFFSETFROM:-0500
RRULE:FREQ=YEARLY;WKST=MO;INTERVAL=1;BYMONTH=3;BYDAY=2SU
TZNAME:EDT
END:DAYLIGHT
END:VTIMEZONE
BEGIN:VEVENT
UID:0fcbc166-847e-46c7-8466-9661b2656bd4
RRULE:FREQ=MONTHLY;INTERVAL=1;BYDAY=1FR
SUMMARY:Monthly meeting
DESCRIPTION:description
X-MOZ-LASTACK:20201014T003944Z
X-MOZ-GENERATION:2
ORGANIZER;CN=Mark A. Hershberger:mailto:mah@nichework.com
DTSTART;TZID="America/New_York":20190705T113000
DTEND;TZID="America/New_York":20190705T123000
STATUS:CONFIRMED
CLASS:PUBLIC
X-MICROSOFT-CDO-INTENDEDSTATUS:BUSY
TRANSP:OPAQUE
LAST-MODIFIED:20201027T115519Z
DTSTAMP:20201027T115519Z
SEQUENCE:0
BEGIN:VALARM
ACTION:DISPLAY
TRIGGER;RELATED=START:-PT5M
DESCRIPTION:Reminder
END:VALARM
END:VEVENT
END:VCALENDAR

[-- Attachment #3: Type: text/plain, Size: 180 bytes --]

See attached.

-- 
http://hexmode.com/


I cannot remember the books I've read any more than the meals I have eaten;
even so, they have made me.
            -- Ralph Waldo Emerson

bug#39938: 28.0.50; icalendar.el does not understand "first friday of every month"

[Lars Ingebrigtsen]

"Mark A. Hershberger" <mah@everybody.org> writes:

> Lars Ingebrigtsen <larsi@gnus.org> writes:
>
>> Looking at the code (and the tests), it should understand these BYDAY
>> clauses.  Do you have a complete .ical file that icalendar doesn't parse
>> correctly?  That'd help with debugging.

[...]

> RRULE:FREQ=MONTHLY;INTERVAL=1;BYDAY=1FR

Thanks; perhaps Ulf sees what's wrong with how icalendar handles this
(Cc'd).

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#39938: 28.0.50; icalendar.el does not understand "first friday of every month"

[Ulf Jasper]

Am 27.10.2020 um 18:33 (+0100) schrieb Lars Ingebrigtsen:
> Thanks; perhaps Ulf sees what's wrong with how icalendar handles this
> (Cc'd).

I'll try.

bug#39938: 28.0.50; icalendar.el does not understand "first friday of every month"

[Ulf Jasper]

I tried.  But I couldn't reproduce the problem.  After simply
'icalendar-import-file'-ing the ical file the calendar shows the
appointment on the first friday of each month.  Just as expected.

However, the bug report was mentioning org-agenda.  What do I have to do
to make the ical appointment appear in my org agenda?  Is there an
'emacs -Q'-ish recipe for reproducing the behaviour?

bug#39938: 28.0.50; icalendar.el does not understand "first friday of every month"

[Lars Ingebrigtsen]

Ulf Jasper <ulf.jasper@web.de> writes:

> I tried.  But I couldn't reproduce the problem.  After simply
> 'icalendar-import-file'-ing the ical file the calendar shows the
> appointment on the first friday of each month.  Just as expected.
>
> However, the bug report was mentioning org-agenda.  What do I have to do
> to make the ical appointment appear in my org agenda?  Is there an
> 'emacs -Q'-ish recipe for reproducing the behaviour?

More information was requested, but no response was given within a a
month, so I'm closing this bug report.  If the problem still exists,
please respond to this email and we'll reopen the bug report.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no