From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#42708: Let users copy "*Char Help*" buffer Date: Tue, 03 Nov 2020 20:57:37 +0200 Message-ID: <87pn4u1fxq.fsf@mail.linkov.net> References: <87r1smy1du.5.fsf@jidanni.org> <877duerlw2.fsf@mail.linkov.net> <87h7the985.fsf@gnus.org> <87a6z8pr7f.fsf@mail.linkov.net> <87bljogscr.fsf@gnus.org> <87r1q27rvz.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34520"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: 42708@debbugs.gnu.org, rms@gnu.org, =?UTF-8?Q?=E7=A9=8D=E4=B8=B9=E5=B0=BC?= Dan Jacobson To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Nov 03 20:11:41 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ka1iW-0008uR-QE for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 03 Nov 2020 20:11:40 +0100 Original-Received: from localhost ([::1]:46624 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ka1iV-00078o-T3 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 03 Nov 2020 14:11:39 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53678) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ka1hu-0006hO-P1 for bug-gnu-emacs@gnu.org; Tue, 03 Nov 2020 14:11:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:34892) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ka1ht-0004Fy-Va for bug-gnu-emacs@gnu.org; Tue, 03 Nov 2020 14:11:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ka1ht-0000sR-Qa for bug-gnu-emacs@gnu.org; Tue, 03 Nov 2020 14:11:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 03 Nov 2020 19:11:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42708 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed Original-Received: via spool by 42708-submit@debbugs.gnu.org id=B42708.16044306073282 (code B ref 42708); Tue, 03 Nov 2020 19:11:01 +0000 Original-Received: (at 42708) by debbugs.gnu.org; 3 Nov 2020 19:10:07 +0000 Original-Received: from localhost ([127.0.0.1]:46435 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ka1h1-0000qr-Eo for submit@debbugs.gnu.org; Tue, 03 Nov 2020 14:10:07 -0500 Original-Received: from relay12.mail.gandi.net ([217.70.178.232]:38559) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ka1h0-0000pv-1q for 42708@debbugs.gnu.org; Tue, 03 Nov 2020 14:10:06 -0500 Original-Received: from mail.gandi.net (m91-129-102-160.cust.tele2.ee [91.129.102.160]) (Authenticated sender: juri@linkov.net) by relay12.mail.gandi.net (Postfix) with ESMTPSA id 7D7D8200003; Tue, 3 Nov 2020 19:09:57 +0000 (UTC) In-Reply-To: <87r1q27rvz.fsf@gnus.org> (Lars Ingebrigtsen's message of "Tue, 13 Oct 2020 04:59:28 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:192641 Archived-At: >>> Oh, I noticed it doesn't support 'C-h' that should pop up the buffer " >>> *Char Help*" from the dynamic variable 'help-form'. >>> >>> Then maybe we should rewrite read-char-choice to use >>> read-char-from-minibuffer? >> >> Yes, that's even better -- then all the callers to read-char-choice >> would no longer be as modal as they are now. > > I've now done this on the trunk. I tried to reproduce the original test case. i.e. to type 'C' (dired-do-copy) and select the "*Char Help*" buffer with C-x o. The result is weird: the cursor in displayed in the minibuffer, but the selected window is "*Char Help*". Here's a patch to fix this: diff --git a/lisp/subr.el b/lisp/subr.el index 286851dfc8..606ce004d5 100644 --- a/lisp/subr.el +++ b/lisp/subr.el @@ -2610,8 +2610,7 @@ read-char-choice (unless (consp chars) (error "Called `read-char-choice' without valid char choices")) (let (char done show-help (helpbuf " *Char Help*")) - (let ((cursor-in-echo-area t) - (executing-kbd-macro executing-kbd-macro) + (let ((executing-kbd-macro executing-kbd-macro) (esc-flag nil)) (save-window-excursion ; in case we call help-form-show (while (not done) After looking more at 'read-char-choice', it seems that special handling of 'inhibit-keyboard-quit' and 'executing-kbd-macro' is not needed anymore? And maybe also adding the 'minibuffer-prompt' face is not needed too. Then what remains to do in 'read-char-choice' is to call 'read-char-from-minibuffer' and to show 'help-form-show' for 'help-char' key?