From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Protesilaos Stavrou Newsgroups: gmane.emacs.bugs Subject: bug#46358: 28.0.50; [PATCH] Add vc-dir faces; also apply them to vc-git Date: Wed, 10 Feb 2021 06:06:28 +0200 Message-ID: <87pn18h8hn.fsf@protesilaos.com> References: <87czxc5cku.fsf@protesilaos.com> <83tuqnnc3s.fsf@gnu.org> <87pn1b4zxp.fsf@protesilaos.com> <87im73m4ki.fsf@gnus.org> <87im72o6r6.fsf@mail.linkov.net> <87czx9u4h9.fsf@protesilaos.com> <8735y538wi.fsf@mail.linkov.net> <875z31td8p.fsf@protesilaos.com> <871rdpt9q6.fsf@protesilaos.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31523"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 46358@debbugs.gnu.org, Lars Ingebrigtsen , Juri Linkov To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Feb 10 05:07:15 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l9gmY-00082z-BB for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 10 Feb 2021 05:07:14 +0100 Original-Received: from localhost ([::1]:41440 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l9gmX-0001sW-9g for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 09 Feb 2021 23:07:13 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54462) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l9gmM-0001qt-SG for bug-gnu-emacs@gnu.org; Tue, 09 Feb 2021 23:07:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:43743) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l9gmM-0007Ky-LN for bug-gnu-emacs@gnu.org; Tue, 09 Feb 2021 23:07:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1l9gmM-00070H-4W for bug-gnu-emacs@gnu.org; Tue, 09 Feb 2021 23:07:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Protesilaos Stavrou Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 10 Feb 2021 04:07:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46358 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed patch Original-Received: via spool by 46358-submit@debbugs.gnu.org id=B46358.161293000126894 (code B ref 46358); Wed, 10 Feb 2021 04:07:02 +0000 Original-Received: (at 46358) by debbugs.gnu.org; 10 Feb 2021 04:06:41 +0000 Original-Received: from localhost ([127.0.0.1]:55288 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l9gm1-0006zh-8a for submit@debbugs.gnu.org; Tue, 09 Feb 2021 23:06:41 -0500 Original-Received: from relay3-d.mail.gandi.net ([217.70.183.195]:53383) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l9gly-0006zR-Ow for 46358@debbugs.gnu.org; Tue, 09 Feb 2021 23:06:40 -0500 X-Originating-IP: 94.46.225.161 Original-Received: from kronos (unknown [94.46.225.161]) (Authenticated sender: public@protesilaos.com) by relay3-d.mail.gandi.net (Postfix) with ESMTPSA id 8716960002; Wed, 10 Feb 2021 04:06:30 +0000 (UTC) In-Reply-To: (Dmitry Gutov's message of "Wed, 10 Feb 2021 03:48:28 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:199755 Archived-At: --=-=-= Content-Type: text/plain On 2021-02-10, 03:48 +0200, Dmitry Gutov wrote: > Hello! > > On 09.02.2021 19:46, Protesilaos Stavrou wrote: > >> I have prepared a new patch. >> 1. Incorporate the feedback received thus far: >> + Do not apply special treatment to the Git stash header. It now >> looks the same as all other headers. >> + Rename 'vc-dir-ignored' to 'vc-dir-status-ignored'. >> + Apply 'vc-dir-status-ignored' to gitignored files. >> 2. Implement the new faces in all backends, while ensuring that every >> value documented for 'vc-state' is taken into account. > > Thanks! > > Looking good, I've applied and pushed this patch. Except for one thing: I just realised that I forgot to update the NEWS entry. Patch attached. Sorry about that! -- Protesilaos Stavrou protesilaos.com --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Update-NEWS-entry-for-vc-dir-faces.patch >From 5314791cc3a85bf5786487f4740d30f20e941e01 Mon Sep 17 00:00:00 2001 Message-Id: <5314791cc3a85bf5786487f4740d30f20e941e01.1612929824.git.info@protesilaos.com> From: Protesilaos Stavrou Date: Wed, 10 Feb 2021 06:03:33 +0200 Subject: [PATCH] Update NEWS entry for vc-dir faces * NEWS: Remove reference to specific backend, as it now applies to all of them. Update name of 'vc-dir-status-ignored'. This follows from the discussion in bug#46358. --- etc/NEWS | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/etc/NEWS b/etc/NEWS index bd209de18e..3cbf2a0fe7 100644 --- a/etc/NEWS +++ b/etc/NEWS @@ -602,10 +602,11 @@ This is used when expanding commit messages from 'vc-print-root-log' and similar commands. --- -*** New faces for 'vc-dir' buffers and their Git VC backend. +*** New faces for 'vc-dir' buffers. Those are: 'vc-dir-header', 'vc-dir-header-value', 'vc-dir-directory', 'vc-dir-file', 'vc-dir-mark-indicator', 'vc-dir-status-warning', -'vc-dir-status-edited', 'vc-dir-status-up-to-date', 'vc-dir-ignored'. +'vc-dir-status-edited', 'vc-dir-status-up-to-date', +'vc-dir-status-ignored'. --- *** The responsible VC backend is now the most specific one. -- 2.30.0 --=-=-=--