From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#47566: 28.0.50; diff-hl should use `repeat-mode' ... and not `smartrep' Date: Mon, 05 Apr 2021 23:43:32 +0300 Organization: LINKOV.NET Message-ID: <87pmz8lc17.fsf@mail.linkov.net> References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4428"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: Ramesh Nedunchezian , 47566@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Apr 05 22:47:29 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lTW89-00012i-L2 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 05 Apr 2021 22:47:29 +0200 Original-Received: from localhost ([::1]:43106 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lTW88-00055Q-Mw for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 05 Apr 2021 16:47:28 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41710) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lTW7i-00053l-D1 for bug-gnu-emacs@gnu.org; Mon, 05 Apr 2021 16:47:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:55413) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lTW7i-0001BH-6T for bug-gnu-emacs@gnu.org; Mon, 05 Apr 2021 16:47:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lTW7i-0004rh-3D for bug-gnu-emacs@gnu.org; Mon, 05 Apr 2021 16:47:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 05 Apr 2021 20:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47566 X-GNU-PR-Package: emacs Original-Received: via spool by 47566-submit@debbugs.gnu.org id=B47566.161765557818649 (code B ref 47566); Mon, 05 Apr 2021 20:47:02 +0000 Original-Received: (at 47566) by debbugs.gnu.org; 5 Apr 2021 20:46:18 +0000 Original-Received: from localhost ([127.0.0.1]:38726 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lTW6z-0004qj-NT for submit@debbugs.gnu.org; Mon, 05 Apr 2021 16:46:17 -0400 Original-Received: from relay12.mail.gandi.net ([217.70.178.232]:45547) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lTW6y-0004qT-Km for 47566@debbugs.gnu.org; Mon, 05 Apr 2021 16:46:17 -0400 Original-Received: from mail.gandi.net (m91-129-107-223.cust.tele2.ee [91.129.107.223]) (Authenticated sender: juri@linkov.net) by relay12.mail.gandi.net (Postfix) with ESMTPSA id A9B5D200007; Mon, 5 Apr 2021 20:46:08 +0000 (UTC) In-Reply-To: (Dmitry Gutov's message of "Sun, 4 Apr 2021 01:08:55 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:203614 Archived-At: >> (cl-loop for >> (cmd . key) >> in >> '((diff-hl-diff-goto-hunk . "=") >> (diff-hl-revert-hunk . "n") >> (diff-hl-previous-hunk . "[") >> (diff-hl-next-hunk . "]")) >> do >> (define-key diff-hl--repeat-map key cmd) >> (put cmd 'repeat-map 'diff-hl--repeat-map))) > > Try this alternative too, seems shorter: > > (map-keymap > (lambda (_key cmd) > (put cmd 'repeat-map 'diff-hl-command-map)) > diff-hl-command-map) > > But either version (together with enabling repeat-mode) seems to break > diff-hl-revert-hunk: as soon as it reaches the the y-or-n prompt, and I try > to answer 'n', it enters the repeat loop again, instead of sending the > result to the command. Could you provide a minimal test case? I tried with: #+begin_src emacs-lisp (defun hl-test () (interactive) (message "OK") (y-or-n-p "Yes? ")) (defvar hl-repeat-map (let ((map (make-sparse-keymap))) (define-key map (kbd "r") 'hl-test) map) "Keymap to repeat hl-test.") (put 'hl-test 'repeat-map 'hl-repeat-map) #+end_src Then typing `M-x hl-test RET', and `y r y r y r ...' keeps the loop.