From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#47552: 27.1; cl-defstruct field names matching read-only variables -> bad code Date: Sun, 11 Apr 2021 18:31:20 +0200 Message-ID: <87pmz0236v.fsf@gnus.org> References: <87wntlyhn9.fsf@rfc20.org> <87y2dxerd8.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32378"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Matt Armstrong , 47552@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Apr 11 18:33:27 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lVd1b-0008K8-Cw for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 11 Apr 2021 18:33:27 +0200 Original-Received: from localhost ([::1]:40242 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lVd1a-0004p1-2z for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 11 Apr 2021 12:33:26 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33912) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lVd0E-00040t-TV for bug-gnu-emacs@gnu.org; Sun, 11 Apr 2021 12:32:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:44240) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lVd0E-0001e5-LQ for bug-gnu-emacs@gnu.org; Sun, 11 Apr 2021 12:32:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lVd0E-0000r3-IG for bug-gnu-emacs@gnu.org; Sun, 11 Apr 2021 12:32:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 11 Apr 2021 16:32:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47552 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed Original-Received: via spool by 47552-submit@debbugs.gnu.org id=B47552.16181587003255 (code B ref 47552); Sun, 11 Apr 2021 16:32:02 +0000 Original-Received: (at 47552) by debbugs.gnu.org; 11 Apr 2021 16:31:40 +0000 Original-Received: from localhost ([127.0.0.1]:55786 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lVczs-0000qR-CA for submit@debbugs.gnu.org; Sun, 11 Apr 2021 12:31:40 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:41652) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lVczq-0000qE-TO for 47552@debbugs.gnu.org; Sun, 11 Apr 2021 12:31:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=6XRHyCQiqskSxq6dxaEQHDYJorEE1R62aKlCbvGoD9c=; b=mEETHgpuEqIGNjTyRwGQBA2BAU b1L56DCzmOMNnqlr4BHmJrEOkvZnjeIn+MG4wxjeWsAprbFyRhwAjjv4W1IA9bHcQkCTMl0nAVusA MsSm6i6FsH0YcKOC7R2mJvTjZvxwTRHUsczM8hSlHgQsWf8d6W26I4cZGmchx8fiaXZk=; Original-Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lVczZ-0001vj-RA; Sun, 11 Apr 2021 18:31:31 +0200 X-Now-Playing: Anthony Shake Shakir's _Frictionalism 1994-2009_: "The Fake Left. Go Right Plan" In-Reply-To: (Stefan Monnier's message of "Sun, 04 Apr 2021 18:59:36 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:203848 Archived-At: Stefan Monnier writes: > I'm pretty sure that's the right solution, *but* I don't think it's > obvious how to get there: `cl-defstruct` defines the constructor > using `cl-defsubst` and its `&key` arguments, so the `:gcs-gone` keyword > argument inevitably maps to a `gcs-done` variable by definition of how > `&key` is supposed to work. I'm having a hard time following the code in cl-defstruct -- even where things are actually defined. But... Indeed doing this "doesn't work": (cl-defsubst foo4 (&key gcs-done) gcs-done) (foo4 :foo 1) -> Debugger entered--Lisp error: (wrong-type-argument numberp nil) But: (foo4 :gcs-done 1) => 1 Hm... -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no