From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Protesilaos Stavrou Newsgroups: gmane.emacs.bugs Subject: bug#47810: 28.0.50; pulse no longer accepts a face argument Date: Thu, 15 Apr 2021 22:35:35 +0300 Message-ID: <87pmyvxrw8.fsf@protesilaos.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8287"; mail-complaints-to="usenet@ciao.gmane.io" To: 47810@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Apr 15 21:36:14 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lX7mg-00022t-CG for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 15 Apr 2021 21:36:14 +0200 Original-Received: from localhost ([::1]:35320 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lX7mf-0008Dh-Cq for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 15 Apr 2021 15:36:13 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40246) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lX7mV-0008BZ-9P for bug-gnu-emacs@gnu.org; Thu, 15 Apr 2021 15:36:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:55963) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lX7mU-0008RK-5Q for bug-gnu-emacs@gnu.org; Thu, 15 Apr 2021 15:36:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lX7mU-00023m-20 for bug-gnu-emacs@gnu.org; Thu, 15 Apr 2021 15:36:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Protesilaos Stavrou Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 15 Apr 2021 19:36:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 47810 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.16185153547895 (code B ref -1); Thu, 15 Apr 2021 19:36:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 15 Apr 2021 19:35:54 +0000 Original-Received: from localhost ([127.0.0.1]:39273 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lX7mM-00023H-IV for submit@debbugs.gnu.org; Thu, 15 Apr 2021 15:35:54 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:36860) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lX7mJ-000233-Jv for submit@debbugs.gnu.org; Thu, 15 Apr 2021 15:35:53 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40220) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lX7mH-00085h-NW for bug-gnu-emacs@gnu.org; Thu, 15 Apr 2021 15:35:51 -0400 Original-Received: from relay1-d.mail.gandi.net ([217.70.183.193]:31727) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lX7mC-00089v-DY for bug-gnu-emacs@gnu.org; Thu, 15 Apr 2021 15:35:49 -0400 X-Originating-IP: 94.46.225.161 Original-Received: from kronos (unknown [94.46.225.161]) (Authenticated sender: public@protesilaos.com) by relay1-d.mail.gandi.net (Postfix) with ESMTPSA id 6C5C7240004 for ; Thu, 15 Apr 2021 19:35:37 +0000 (UTC) Received-SPF: none client-ip=217.70.183.193; envelope-from=info@protesilaos.com; helo=relay1-d.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:204095 Archived-At: Dear maintainers, I would expect the following two expressions to produce pulse effects that differ in colour (tried with emacs -Q): (pulse-momentary-highlight-region (point-at-bol) (point-at-eol) 'highlight) (pulse-momentary-highlight-region (point-at-bol) (point-at-eol) 'region) Instead they use the background of pulse-highlight-start-face. This test confirms as much: (set-face-background 'pulse-highlight-start-face "red") (pulse-momentary-highlight-region (point-at-bol) (point-at-eol) 'highlight) (set-face-background 'pulse-highlight-start-face "blue") (pulse-momentary-highlight-region (point-at-bol) (point-at-eol) 'region) The following diff addresses the problem with the FACE argument, but introduces a noticeable delay to the pulse effect: lisp/cedet/pulse.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/cedet/pulse.el b/lisp/cedet/pulse.el index 1e4506713a..e4733ca007 100644 --- a/lisp/cedet/pulse.el +++ b/lisp/cedet/pulse.el @@ -147,7 +147,7 @@ (defun pulse-momentary-highlight-overlay (o &optional face) (add-hook 'pre-command-hook #'pulse-momentary-unhighlight)) ;; Pulse it. - (overlay-put o 'face 'pulse-highlight-face) + (overlay-put o 'face (or face 'pulse-highlight-start-face)) ;; The pulse function puts FACE onto 'pulse-highlight-face. ;; Thus above we put our face on the overlay, but pulse ;; with a reference face needed for the color. I am not sure what may be causing that delay. Thank you for your attention! -- Protesilaos Stavrou protesilaos.com