From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Bastien Newsgroups: gmane.emacs.bugs Subject: bug#48179: bookmark-fontify [PATCH] Date: Wed, 05 May 2021 17:39:43 +0200 Organization: GNU Message-ID: <87pmy5io91.fsf@bzg.fr> References: <20210503001358.mjafsjlumdamrlvh@E15-2016.optimum.net> <87zgxcdzh3.fsf@gnus.org> <20210503091204.qhc2tda76wh6345w@E15-2016.optimum.net> <87im40cgxz.fsf@gnus.org> <20210503095828.66mcqkxyznb2vdja@E15-2016.optimum.net> <87v97yan85.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2797"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Boruch Baum , 48179@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed May 05 17:44:39 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1leJhX-0000cV-Ha for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 05 May 2021 17:44:39 +0200 Original-Received: from localhost ([::1]:40594 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1leJhW-0000C2-KJ for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 05 May 2021 11:44:38 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44900) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1leJd4-0003Gs-OD for bug-gnu-emacs@gnu.org; Wed, 05 May 2021 11:40:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:49511) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1leJd4-0002JV-9c for bug-gnu-emacs@gnu.org; Wed, 05 May 2021 11:40:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1leJd4-00019x-6I for bug-gnu-emacs@gnu.org; Wed, 05 May 2021 11:40:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Bastien Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 05 May 2021 15:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48179 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch fixed Original-Received: via spool by 48179-submit@debbugs.gnu.org id=B48179.16202291934447 (code B ref 48179); Wed, 05 May 2021 15:40:02 +0000 Original-Received: (at 48179) by debbugs.gnu.org; 5 May 2021 15:39:53 +0000 Original-Received: from localhost ([127.0.0.1]:32824 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1leJcv-00019f-6i for submit@debbugs.gnu.org; Wed, 05 May 2021 11:39:53 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:36452) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1leJct-00019Z-QK for 48179@debbugs.gnu.org; Wed, 05 May 2021 11:39:52 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:46914) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1leJcn-00028j-K3; Wed, 05 May 2021 11:39:46 -0400 Original-Received: from [2a01:e34:ec2b:7150:9cd4:6735:fc93:ecf2] (port=33498 helo=guerry) by fencepost.gnu.org with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.82) (envelope-from ) id 1leJcn-0000W5-1g; Wed, 05 May 2021 11:39:45 -0400 Original-Received: by guerry (Postfix, from userid 1000) id 0A1751A60ECC; Wed, 5 May 2021 17:39:43 +0200 (CEST) In-Reply-To: <87v97yan85.fsf@gnus.org> (Lars Ingebrigtsen's message of "Tue, 04 May 2021 10:59:22 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:205716 Archived-At: Lars Ingebrigtsen writes: > Boruch Baum writes: > >> It's not *my* emacs. I only have access to debian emacs locally; the >> data I gave you was from the URL I had for the on-line cgit repository >> for emacs, at gnu.org. Here's a second patch, based upon hopefully the >> most current URL, and with the additional jump code. > > Thanks; applied to Emacs 28 without any problems. Just a quick warning: Org contains two features called "capture" and "refile". "Capturing" adds notes or tasks to an Org buffer from other Emacs buffers. "Refiling" moves a Org headline under another one, either in the current Org buffer or in another (declared) Org file. With this change, the Org refiled/captured headlines get fontified and it might surprise many users until they find out that fontification is related to this bookmark feature. There is also dired and, of course, normal bookmarked files: I guess some users may be really confused--at least those who don't know to M-x customize-face RET at point to guess what this is all about. What do you think? Shall we turn bookmark-fontify off by default? I for one do like the feature and customized bookmark-face to suit my needs, but I wonder about others. -- Bastien