unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Michael Heerdegen <michael_heerdegen@web.de>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: stefan@marxist.se, michael.albinus@gmx.de, 21440@debbugs.gnu.org
Subject: bug#21440: 25.0.50; Manual: FEATURE-unload-hook in (info "(elisp) Coding Conventions")
Date: Sat, 17 Jul 2021 03:21:51 +0200	[thread overview]
Message-ID: <87pmvhybtc.fsf@web.de> (raw)
In-Reply-To: <87o8b2d43s.fsf@gnus.org> (Lars Ingebrigtsen's message of "Fri, 16 Jul 2021 11:01:43 +0200")

Lars Ingebrigtsen <larsi@gnus.org> writes:

> I've now clarified that section...

Thanks, Lars.

> > (should we add advices to that list btw?).
>
> Hm...  does unload-feature remove advices?  Let's see..
>
> Well, there's this:
>
> (defun loadhist--unload-function (x)
>   (let ((fun (cdr x)))
>     (when (fboundp fun)
>       (when (fboundp 'ad-unadvise)
> 	(ad-unadvise fun))
>
> Hm...  but is that what it does?

I don't think so.  AFAIU this does not even effect nadvice advices, and
treats only advises of functions defined by the feature.

Michael.





  reply	other threads:[~2021-07-17  1:21 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-09 11:43 bug#21440: 25.0.50; Manual: FEATURE-unload-hook in (info "(elisp) Coding Conventions") Michael Heerdegen
2020-08-15 13:53 ` Stefan Kangas
2020-08-17 11:15   ` Michael Albinus
2021-07-08 13:55     ` Lars Ingebrigtsen
2021-07-12  3:56       ` Michael Heerdegen
2021-07-12 11:59         ` Eli Zaretskii
2021-07-12 12:05           ` Lars Ingebrigtsen
2021-07-16  1:23             ` Michael Heerdegen
2021-07-16  9:01               ` Lars Ingebrigtsen
2021-07-17  1:21                 ` Michael Heerdegen [this message]
2021-07-17  1:35                   ` Michael Heerdegen
2021-07-17 14:08                     ` Lars Ingebrigtsen
2021-07-21  2:45                       ` Michael Heerdegen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87pmvhybtc.fsf@web.de \
    --to=michael_heerdegen@web.de \
    --cc=21440@debbugs.gnu.org \
    --cc=larsi@gnus.org \
    --cc=michael.albinus@gmx.de \
    --cc=stefan@marxist.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).