From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#49848: 27.2.50; map-merge plist return alist Date: Wed, 04 Aug 2021 09:47:50 +0200 Message-ID: <87pmutejmh.fsf@gnus.org> References: <87o8ae71yv.fsf@hm.sivalik.com> <877dh2qjf1.fsf@web.de> <877dh282io.fsf@tcd.ie> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14416"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Michael Heerdegen , rajeev.jnk@sivalik.com, 49848@debbugs.gnu.org To: "Basil L. Contovounesios" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Aug 04 09:49:30 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mBBeb-0003af-Kg for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 04 Aug 2021 09:49:29 +0200 Original-Received: from localhost ([::1]:58602 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mBBea-0001xX-Js for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 04 Aug 2021 03:49:28 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53846) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mBBeE-0001vz-9d for bug-gnu-emacs@gnu.org; Wed, 04 Aug 2021 03:49:07 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:59238) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mBBeA-0007by-IZ for bug-gnu-emacs@gnu.org; Wed, 04 Aug 2021 03:49:06 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mBBeA-00087R-Gm for bug-gnu-emacs@gnu.org; Wed, 04 Aug 2021 03:49:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 04 Aug 2021 07:49:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49848 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 49848-submit@debbugs.gnu.org id=B49848.162806328431130 (code B ref 49848); Wed, 04 Aug 2021 07:49:02 +0000 Original-Received: (at 49848) by debbugs.gnu.org; 4 Aug 2021 07:48:04 +0000 Original-Received: from localhost ([127.0.0.1]:42551 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mBBdD-000861-Q1 for submit@debbugs.gnu.org; Wed, 04 Aug 2021 03:48:04 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:37482) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mBBdB-00085V-Qs for 49848@debbugs.gnu.org; Wed, 04 Aug 2021 03:48:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=i1X9lT7uOVdIz5kaA1hny6aenAH6PBzOH2qzj0fRIqA=; b=kYCQ6FhLSFGen3/1Nw5ZNcnLQb VLlLHPkFjWKHoDXEvfXLqb/SUM7YjgIcQsTIQKpM5ybz8LRuYn/YV7p9y+O708rLiBLnvTVaNgBb9 60fW+qVlcSXDfIzzCA4im/rDEvAs7bxjRIYsnxcDJd9GTlxegcau0A+mpnv+7mvmy3jo=; Original-Received: from [84.212.220.105] (helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mBBd1-0005Hy-Er; Wed, 04 Aug 2021 09:47:55 +0200 In-Reply-To: <877dh282io.fsf@tcd.ie> (Basil L. Contovounesios's message of "Wed, 04 Aug 2021 01:41:35 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:211138 Archived-At: "Basil L. Contovounesios" writes: > In the specific case of merging maps into a desired type, we can simply > be more careful in such ambiguous cases. The attached patch does that, > while also avoiding the quadratic lookup behaviour for lists. I think that's the correct (and indeed only) solution here when dealing with alist/plist ambiguities (if we don't want to say explicitly for every map* call what the type actually is meant to be). > (progn > (require 'map) > (map-merge-with 'list (lambda (a b) (message ">>> %s %s" a b) b) > `((,(string ?a) . 1)) > `((,(string ?a) . 2)))) > > In Emacs 26, it returns (("a" . 2) ("a" . 1)) without printing. > In Emacs 27 and 28, it returns (("a" . 2)) without printing. > > Do we consider this a regression in Emacs 27 and try to fix it in 28 > (keeping in mind that map.el is also a GNU ELPA package)? I think the current result value is the one that makes sense... > Or do we drop the eql guarantee in the docstring, and call the function > argument whenever two keys are merged, as in the attached patch? I think that makes sense. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no