From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#49944: parse-partial-sexp fails to signal an error when (> START LIMIT). Date: Sun, 22 Aug 2021 17:02:11 +0200 Message-ID: <87pmu5y13g.fsf@gnus.org> References: <87o89r2anv.fsf@gnus.org> <87sfz2o3bo.fsf@tcd.ie> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26328"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Alan Mackenzie , Stefan Monnier , 49944@debbugs.gnu.org To: "Basil L. Contovounesios" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Aug 22 17:03:10 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mHp0A-0006XM-JI for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 22 Aug 2021 17:03:10 +0200 Original-Received: from localhost ([::1]:38190 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mHp08-0008Sm-UY for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 22 Aug 2021 11:03:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56334) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mHp02-0008R9-6F for bug-gnu-emacs@gnu.org; Sun, 22 Aug 2021 11:03:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:56398) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mHp01-0005ou-Vf for bug-gnu-emacs@gnu.org; Sun, 22 Aug 2021 11:03:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mHp01-0008CP-Si for bug-gnu-emacs@gnu.org; Sun, 22 Aug 2021 11:03:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 22 Aug 2021 15:03:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49944 X-GNU-PR-Package: emacs Original-Received: via spool by 49944-submit@debbugs.gnu.org id=B49944.162964455431143 (code B ref 49944); Sun, 22 Aug 2021 15:03:01 +0000 Original-Received: (at 49944) by debbugs.gnu.org; 22 Aug 2021 15:02:34 +0000 Original-Received: from localhost ([127.0.0.1]:39711 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mHozV-00082P-Sk for submit@debbugs.gnu.org; Sun, 22 Aug 2021 11:02:34 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:34704) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mHozP-0007ts-Pb for 49944@debbugs.gnu.org; Sun, 22 Aug 2021 11:02:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=r1rfeKVn/YUprMRGUhLqJU13ZzgKVHb/RNVfNZYk4dw=; b=IZbenmQH6ILpu4jiaRmkDDrddC sqYYKqwg20yDQONz/HiVEnwKZv7mrOnBnjypNy1F5IGQ7bzW0rQGsrtuSnwMiwS2vTuaEoLP9vc8D 9BgibkDU9MERy6ieshaKyzI27BkeRXcGQAt70mWdImuwXF5j6SqCq7TdZnIlfDtnCU8A=; Original-Received: from [84.212.220.105] (helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mHozE-00083t-94; Sun, 22 Aug 2021 17:02:16 +0200 In-Reply-To: <87sfz2o3bo.fsf@tcd.ie> (Basil L. Contovounesios's message of "Sat, 21 Aug 2021 23:11:55 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:212423 Archived-At: "Basil L. Contovounesios" writes: > - if (XFIXNUM (to) < XFIXNUM (from)) > - error ("End position should be larger than start position."); > + if (fix_position (to) < fix_position (from)) > + error ("End position is smaller than start position"); Looks good to me. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no