From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#50220: 27.2; follow.el: follow-recenter does not work correctly if invoked in a follow window before the middle follow window. Date: Fri, 27 Aug 2021 03:43:33 +0200 Message-ID: <87pmtzslve.fsf@gnus.org> References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13387"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 50220@debbugs.gnu.org To: Noah Evans Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Aug 27 03:44:22 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mJQuq-0003GL-Ob for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 27 Aug 2021 03:44:20 +0200 Original-Received: from localhost ([::1]:46322 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mJQup-0006pP-0i for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 26 Aug 2021 21:44:19 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37742) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mJQuY-0006p9-3v for bug-gnu-emacs@gnu.org; Thu, 26 Aug 2021 21:44:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39285) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mJQuX-0003Oh-Sh for bug-gnu-emacs@gnu.org; Thu, 26 Aug 2021 21:44:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mJQuX-0000z8-Nv for bug-gnu-emacs@gnu.org; Thu, 26 Aug 2021 21:44:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 27 Aug 2021 01:44:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50220 X-GNU-PR-Package: emacs Original-Received: via spool by 50220-submit@debbugs.gnu.org id=B50220.16300286343759 (code B ref 50220); Fri, 27 Aug 2021 01:44:01 +0000 Original-Received: (at 50220) by debbugs.gnu.org; 27 Aug 2021 01:43:54 +0000 Original-Received: from localhost ([127.0.0.1]:50829 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mJQuM-0000yP-4T for submit@debbugs.gnu.org; Thu, 26 Aug 2021 21:43:54 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:53748) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mJQuG-0000y4-Kk for 50220@debbugs.gnu.org; Thu, 26 Aug 2021 21:43:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Ij3z/kr0fy0Le0N+vAmmMs3BXJoUyRrFtDeSM8vgJRY=; b=JCPpigLh1rPbrX9Jsk4DiOoGgR F0xcq9K2Okp1J4OdzWf23tWlzQPrEZsZbqmohPwv6LS0pV7v0lW8BG09HExsdaA+EXxMtrtjX4eQt riFPRzFRbpLqpLrxxhX9JBl0kMS08OxftgLeTHBmt+JQ0Kx1khq472BAvEjhcTlBlaFg=; Original-Received: from [84.212.220.105] (helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mJQu5-0000JL-JL; Fri, 27 Aug 2021 03:43:37 +0200 In-Reply-To: (Noah Evans's message of "Fri, 27 Aug 2021 00:39:26 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:212777 Archived-At: Noah Evans writes: > In follow mode, 'follow-mode-recenter` with no argument should center > the middle window around point. It works fine if it is used in the > middle window or a window after it, but if it is used in a window before > middle the post-command-hook moves the window back. > > Reproduce: > Find a long file. > Split the window vertically two or more times. > M-x follow-mode > Go to the leftmost window and do C-c . C-l Thanks; applied to Emacs 28. (I've never used follow-mode before, but your patch does indeed seem to fix the problem with `C-c . C-l'.) This change was small enough to apply without assigning copyright to the FSF, but for future patches you want to submit, it might make sense to get the paperwork started now, so that subsequent patches can be applied speedily. Would you be willing to sign such paperwork? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no