From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.bugs Subject: bug#49723: 28.0.50; Test in coding.c for NUL bytes in filenames is not reliable Date: Thu, 16 Sep 2021 20:44:32 +0200 Message-ID: <87pmt8l5rj.fsf@gmx.de> References: <83o8ary5kl.fsf@gnu.org> <87pmtbj81v.fsf@gmail.com> <8335q7c655.fsf@gnu.org> <87pmta6buq.fsf@gmail.com> <837dfgaerv.fsf@gnu.org> <8735q4zcdh.fsf@gmail.com> <87tuikl79i.fsf@gmx.de> <83v9308jb9.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26252"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: phst@google.com, 49723@debbugs.gnu.org, federicotedin@gmail.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Sep 16 20:45:22 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mQwNu-0006bu-0w for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 16 Sep 2021 20:45:22 +0200 Original-Received: from localhost ([::1]:47610 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mQwNs-0005fk-6x for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 16 Sep 2021 14:45:20 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54960) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mQwNb-0005fZ-E1 for bug-gnu-emacs@gnu.org; Thu, 16 Sep 2021 14:45:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:45008) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mQwNb-00076a-4Z for bug-gnu-emacs@gnu.org; Thu, 16 Sep 2021 14:45:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mQwNa-00036O-LR for bug-gnu-emacs@gnu.org; Thu, 16 Sep 2021 14:45:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 16 Sep 2021 18:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49723 X-GNU-PR-Package: emacs Original-Received: via spool by 49723-submit@debbugs.gnu.org id=B49723.163181788911886 (code B ref 49723); Thu, 16 Sep 2021 18:45:02 +0000 Original-Received: (at 49723) by debbugs.gnu.org; 16 Sep 2021 18:44:49 +0000 Original-Received: from localhost ([127.0.0.1]:56554 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mQwNN-00035e-Gi for submit@debbugs.gnu.org; Thu, 16 Sep 2021 14:44:49 -0400 Original-Received: from mout.gmx.net ([212.227.17.21]:51415) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mQwNH-00035J-WC for 49723@debbugs.gnu.org; Thu, 16 Sep 2021 14:44:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1631817873; bh=IG4LaR30rG4tVX+hnQ6lkf41YkfRLT9mzls/DpvCT/8=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=MYXxIOO8RD96MdGhiy121vSfnva/tAok9pI5Y8kNqEf6i0S0KcAfmGrSa8euQSikU 1dYrRAM4q69xDxssW/imoHRpOn9Frx2QpzSy8hshxCgQRsu1DE1QxFIHmrm2t5QKe5 png3Wxn41MxYHWsrTrSTVLXl3Dxpl4bbT+eprV+g= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from gandalf.gmx.de ([213.220.158.132]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1M6ll8-1mY5Vf1VB0-008HlK; Thu, 16 Sep 2021 20:44:33 +0200 In-Reply-To: <83v9308jb9.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 16 Sep 2021 21:30:18 +0300") X-Provags-ID: V03:K1:RSUTWh8K5mHFMWqLilFHAydF757HYZnC/P1qPDJw7+6hSsJ8R+q DvMB/fa4U/qcrrMGyQ4+7U5kJFkGEdorzckr0eQw9YFJbc/PnQAgpqRZ3zvjkbDN47PXzM1 Zo+KQz6lEhYrFDENQaxw4AfToKYoRiwAPjYlaZoXQ6mkP0+ZIAEXhsBpMwgBxqz2HLzzuIq P2ReW8WXRB/hlBI1zjYpw== X-UI-Out-Filterresults: notjunk:1;V03:K0:rJr2ZaapUy4=:CxgxZ9Ba6OzpRdwIajm9vj nTTuahel+p5vZyaM6QlUKdxjgrr5gIpDaRrMVEa/2RTqkc7vGCc7cL2A27aX77/5zqLe7T1Zb FbDhPHtOm5Hy67i3e8fP87x2WWm9bMVvIuKsJ96sZhcB9TJiixZjZnNkZudtIjTWr9aiQQk9q yxJlD64SMELIRY4gCbGjkv01/BKg1Sr5P0C4ZzzlDAkpjRSbzY8z5+wM7nRChgT6bY5Wkjl0W ZIj47HeUCSd5EnmCe6s06UUce2w/qy+WnyGx4CEdx74aOy94a50JjMzi4tTOruX3PSzO9n8qc gymKEhkF+q94UvlLWWAIyELp1UUtALnAUjoo0y22gu37Rn0u3la20B2yzs3ZJyqkOLMaJn7cv oxMvROZFqYSC7mdF6kdAt56pYV8WHnhUtoPFWzueoHzq0T1s0oXjUVms00h5pr1BLUA6Uiecy /cCL2FpWUdBpByxLKayXNkoguhBHqV6tfe/lZN30YE07Ec6EugHajjhRdhsB7r2FNfaBjzR7c sWMgMfrsn2W9xk28d/d2gnU5xvLiZYpv0SxMtp2nxnT26yU21EFIwz1PBpBCD7Jat9tKx/1Ny 7wSCmrnVbEMTy5OzgJGaZ3uDFbz5A1xE/N+Nqo/1ZJgv7bxCyrPWH97zGc+nzBmB+mndMQt7n uns/kAUL/RCKXATRcPX9otjKPVODA4dB9qqMLSJ77dlyklCXs2mcFKPxDzAsPYk3jFsiplUbG 2Td9RoKTW+UDEdjLvuHWdhPdBD+a9Z9ufiZHkUEL3SsIz2BGcYZJ9bvHwzwIfAU5eCTSHx1k X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:214499 Archived-At: Eli Zaretskii writes: Hi Eli, >> > +** 'expand-file-name' now checks for null bytes in filenames. >> > +The function will now check for null bytes in both NAME and >> > +DEFAULT-DIRECTORY arguments, as well as in the 'default-directory' >> > +buffer-local variable, assuming its value is used. If null bytes ar= e >> > +found, 'expand-file-name' will signal an error. >> >> Should this be implemented also in remote file names? > > Are we sure remote file names cannot include null bytes? Likely not. I have added "foo\0bar" as file name in tramp-test.el, and then I get =2D-8<---------------cut here---------------start------------->8--- Test tramp-test41-special-characters condition: (ert-test-failed ((should (file-exists-p file1)) :form (file-exists-p "/mock:gandalf:/tmp/tramp-testkLeKOx/foo\0bar") :value nil)) FAILED 1/1 tramp-test41-special-characters (0.484141 sec) =2D-8<---------------cut here---------------end--------------->8--- Well, perhaps Tramp can be improved to handle null bytes on (remote) shell level, but do we need this? Best regards, Michael.