From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "Basil L. Contovounesios" via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#50690: Avoid double argument evaluation in vc-call Date: Mon, 20 Sep 2021 00:48:21 +0100 Message-ID: <87pmt49lfe.fsf@tcd.ie> Reply-To: "Basil L. Contovounesios" Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29977"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) To: 50690@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Sep 20 01:49:11 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mS6YZ-0007a4-Hi for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 20 Sep 2021 01:49:11 +0200 Original-Received: from localhost ([::1]:42146 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mS6YX-0004Mb-9f for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 19 Sep 2021 19:49:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43840) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mS6YQ-0004ME-J5 for bug-gnu-emacs@gnu.org; Sun, 19 Sep 2021 19:49:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:56986) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mS6YQ-00080c-8D for bug-gnu-emacs@gnu.org; Sun, 19 Sep 2021 19:49:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mS6YQ-0005YU-6t for bug-gnu-emacs@gnu.org; Sun, 19 Sep 2021 19:49:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "Basil L. Contovounesios" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 19 Sep 2021 23:49:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 50690 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.163209530921314 (code B ref -1); Sun, 19 Sep 2021 23:49:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 19 Sep 2021 23:48:29 +0000 Original-Received: from localhost ([127.0.0.1]:40299 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mS6Xt-0005Xi-G4 for submit@debbugs.gnu.org; Sun, 19 Sep 2021 19:48:29 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:45550) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mS6Xs-0005Xa-00 for submit@debbugs.gnu.org; Sun, 19 Sep 2021 19:48:28 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43808) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mS6Xr-0004Lp-OW for bug-gnu-emacs@gnu.org; Sun, 19 Sep 2021 19:48:27 -0400 Original-Received: from mail-wr1-x42e.google.com ([2a00:1450:4864:20::42e]:43581) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mS6Xp-0007dI-Jg for bug-gnu-emacs@gnu.org; Sun, 19 Sep 2021 19:48:27 -0400 Original-Received: by mail-wr1-x42e.google.com with SMTP id w17so17398707wrv.10 for ; Sun, 19 Sep 2021 16:48:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd.ie; s=google21; h=from:to:subject:date:message-id:user-agent:mime-version; bh=nBE4MJZnP3gt8a6Y7Azhzd+OLE9bpBjycM9E9A88XDA=; b=WIifcq9HjGUD/rUh7nMAYk6JKjNX0dhshZ+AxMqI1qUC+QJzCl3+CbxhDvU3+8roDj V7NmW+kZgi0+mvjxfzsFW3Vc+H7oAfFyUFIJDGbho0MPPa7da1JpRoaeZ+YPGxhni41C l79HZlPgI6NR48HsNQIn97qVB9GPD7KGa2ImZCcprXlowO0PMf6g++f3Oklcm2+o4kOn jqXJxLPMjPN3f4KLC6VLFEGuVV8pr/TFX0YEdtIimlMY7RP+Iy755QovO2NuIATFb5kF ohmOGoZ9h/ASji9BTFS1erJHK/22ww0eq7MsMlmIQs9qDEiCCprB/SK358mNjhDdYnGK n2iQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:date:message-id:user-agent :mime-version; bh=nBE4MJZnP3gt8a6Y7Azhzd+OLE9bpBjycM9E9A88XDA=; b=uyXQmyqsAxv/f7Am8QTk89KGanKv2G48tZyS91a63cFBq1iYcfk3aDY1CcQ+7x+P0K qnTOMh9M61PG7xD6qZmBF2pdwMvNdezYFlF31lKEeo9MWO5i0WaqsD5yzNPsHY06K+Zp juIgZ+uc3/OoKAQksAg/NEfehnRbpvfTgswD/uwpOjfAHDnm6Lu1l/Y7y7Gr+bqYdGFE suF9Lc8rmI53J+NIhBRRP0fqD3t1Qk08lzkqZl7ZN9wtKUQGvfZm02QaQFzfTxyk2COJ NxXHV46g3XD9GiJuK7SQ5N01MJFsXfwHjsJ9nSxQ+cDjoY85ureTl3bR8rRu2bUuzJt1 o4Pw== X-Gm-Message-State: AOAM5306bS6i1dmva4dQ6I05HurPEe/y9T3oC8b3/FRjp5FRiVEqd+am wUiNIbjse134phC3xbKLT6TNN0Ks2Vqp5w== X-Google-Smtp-Source: ABdhPJyt74ktYoZNIM01G0mCes5g2yYw6J4adQS3C6dxiplOJPJw6WJyNF0NGFjQ3H25/SBbfgmMiQ== X-Received: by 2002:adf:b7c5:: with SMTP id t5mr25060993wre.322.1632095303300; Sun, 19 Sep 2021 16:48:23 -0700 (PDT) Original-Received: from localhost ([2a02:8084:20e2:c380:d15:339e:aa10:60f1]) by smtp.gmail.com with ESMTPSA id t126sm17245308wma.4.2021.09.19.16.48.22 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Sep 2021 16:48:22 -0700 (PDT) Received-SPF: pass client-ip=2a00:1450:4864:20::42e; envelope-from=contovob@tcd.ie; helo=mail-wr1-x42e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:214802 Archived-At: --=-=-= Content-Type: text/plain Severity: wishlist Tags: patch Is there any reason why the macro vc-call should continue to evaluate its second argument twice? Both 'make bootstrap' and 'make check' pass with the attached patch: --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0002-lisp-vc-vc-hooks.el-vc-call-Eval-arg-once.patch >From 5cdd24e4eb3e1e79857d76c2b780fe7f245ad9f6 Mon Sep 17 00:00:00 2001 From: "Basil L. Contovounesios" Date: Sun, 19 Sep 2021 22:39:20 +0100 Subject: [PATCH 2/2] * lisp/vc/vc-hooks.el (vc-call): Eval arg once. --- lisp/vc/vc-hooks.el | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lisp/vc/vc-hooks.el b/lisp/vc/vc-hooks.el index 0612310640..b7760e3bba 100644 --- a/lisp/vc/vc-hooks.el +++ b/lisp/vc/vc-hooks.el @@ -256,9 +256,9 @@ vc-call-backend (defmacro vc-call (fun file &rest args) "A convenience macro for calling VC backend functions. Functions called by this macro must accept FILE as the first argument. -ARGS specifies any additional arguments. FUN should be unquoted. -BEWARE!! FILE is evaluated twice!!" - `(vc-call-backend (vc-backend ,file) ',fun ,file ,@args)) +ARGS specifies any additional arguments. FUN should be unquoted." + (macroexp-let2 nil file file + `(vc-call-backend (vc-backend ,file) ',fun ,file ,@args))) (defsubst vc-parse-buffer (pattern i) "Find PATTERN in the current buffer and return its Ith submatch." -- 2.33.0 --=-=-= Content-Type: text/plain Thanks, -- Basil In GNU Emacs 28.0.50 (build 2, x86_64-pc-linux-gnu, X toolkit, cairo version 1.16.0, Xaw3d scroll bars) of 2021-09-20 built on tia Repository revision: 3c513435369826e44a53dcb12ecc14657e03c73d Repository branch: HEAD Windowing system distributor 'The X.Org Foundation', version 11.0.12011000 System Description: Debian GNU/Linux bookworm/sid Configured using: 'configure 'CC=ccache gcc' 'CFLAGS=-Og -ggdb' --config-cache --prefix=/home/blc/.local --enable-checking=structs --with-x-toolkit=lucid --with-file-notification=yes --with-x' Configured features: ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG JSON LCMS2 LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2 M17N_FLT MODULES NOTIFY INOTIFY PDUMPER PNG RSVG SECCOMP SOUND THREADS TIFF TOOLKIT_SCROLL_BARS X11 XAW3D XDBE XIM XPM LUCID ZLIB Important settings: value of $LANG: en_IE.UTF-8 value of $XMODIFIERS: @im=ibus locale-coding-system: utf-8-unix --=-=-=--