unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Lars Ingebrigtsen <larsi@gnus.org>
To: Carlos Pita <carlosjosepita2@gmail.com>
Cc: 51858@debbugs.gnu.org
Subject: bug#51858: 29.0.50; pcomplete not ignoring case
Date: Fri, 19 Nov 2021 06:32:00 +0100	[thread overview]
Message-ID: <87pmqwyalr.fsf@gnus.org> (raw)
In-Reply-To: <CAEOO5TdMSd8U7OjMzu+L8VmZFLWWa3yTeWyf_ULsPzC0pvH2yQ@mail.gmail.com> (Carlos Pita's message of "Fri, 19 Nov 2021 02:06:43 -0300")

Carlos Pita <carlosjosepita2@gmail.com> writes:

> Thanks! Your fix works for me. I'm not sure if this is the best place to set
> completion-ignore-case though.

Yeah, me neither.  The completion machinery is hard to grok -- there's
so many magical wrappers and stuff that reasoning about it is a challenge.

> If you look at the code for comint--complete-file-name-data you will
> find that completion-ignore-case is set in the same way that you
> did. But perhaps too late because at that point
> comint-completion-file-name-table has already been called.

Yes, I think so.

> Perhaps the best fix is to bind completion-ignore-case
> earlier in comint--complete-file-name-data. But if
> comint-completion-file-name-table is intended to be called from other places,
> then it's better to set completion-ignore-case there as you did.

I think I tried doing that, and it didn't do the right thing, but I may
be mistaken.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





  reply	other threads:[~2021-11-19  5:32 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-15  5:47 bug#51858: 29.0.50; pcomplete not ignoring case Carlos Pita
2021-11-15  5:59 ` Lars Ingebrigtsen
2021-11-15  7:16   ` Carlos Pita
2021-11-15  8:00     ` Lars Ingebrigtsen
2021-11-19  5:06       ` Carlos Pita
2021-11-19  5:32         ` Lars Ingebrigtsen [this message]
2022-09-20 13:32           ` bug#51858: Completion in shell buffers " Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87pmqwyalr.fsf@gnus.org \
    --to=larsi@gnus.org \
    --cc=51858@debbugs.gnu.org \
    --cc=carlosjosepita2@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).