From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Sean Whitton Newsgroups: gmane.emacs.bugs Subject: bug#52888: 29.0.50; font_{delete_unmatched,score} do not handle nil FONT_WEIGHT_INDEX Date: Wed, 12 Jan 2022 14:41:33 -0700 Message-ID: <87pmow1vjm.fsf@athena.silentflame.com> References: <87czl55skc.fsf@melete.silentflame.com> <83a6g982tt.fsf@gnu.org> <87pmp4d9bv.fsf@melete.silentflame.com> <83k0f557f7.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16903"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Notmuch/0.31.4 (https://notmuchmail.org) Emacs/29.0.50 (x86_64-pc-linux-gnu) Cc: 52888@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jan 12 22:42:14 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n7lNl-0004AB-Be for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 12 Jan 2022 22:42:14 +0100 Original-Received: from localhost ([::1]:55004 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n7lNk-0000z9-7X for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 12 Jan 2022 16:42:12 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:56626) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n7lNd-0000z1-Sv for bug-gnu-emacs@gnu.org; Wed, 12 Jan 2022 16:42:05 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:38205) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n7lNa-0005fS-6O for bug-gnu-emacs@gnu.org; Wed, 12 Jan 2022 16:42:04 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1n7lNa-0001NH-2l for bug-gnu-emacs@gnu.org; Wed, 12 Jan 2022 16:42:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Sean Whitton Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 12 Jan 2022 21:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52888 X-GNU-PR-Package: emacs Original-Received: via spool by 52888-submit@debbugs.gnu.org id=B52888.16420237025256 (code B ref 52888); Wed, 12 Jan 2022 21:42:02 +0000 Original-Received: (at 52888) by debbugs.gnu.org; 12 Jan 2022 21:41:42 +0000 Original-Received: from localhost ([127.0.0.1]:59341 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n7lNG-0001Mi-E3 for submit@debbugs.gnu.org; Wed, 12 Jan 2022 16:41:42 -0500 Original-Received: from out5-smtp.messagingengine.com ([66.111.4.29]:35743) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n7lNF-0001MV-6E for 52888@debbugs.gnu.org; Wed, 12 Jan 2022 16:41:41 -0500 Original-Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 18E425C013A; Wed, 12 Jan 2022 16:41:36 -0500 (EST) Original-Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Wed, 12 Jan 2022 16:41:36 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spwhitton.name; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-type; s=fm2; bh=pd1MxD11k7v/ZIsZG1v2Lf2IgV kbMScYI5M7aKyS7cU=; b=R05vkPkAFTQguH16JzugNVWPLjGunheIOq2fL4Zsy6 bRFg08Es6rGRVuFYth8T7vAOxIk0MqiUur+sEcOnX5Km6JGenioXVZwUVyQVGIX4 oV5xFjb/jQUwommASLND65Fe9yagcc4wrSFHOuxOm9yUX+VP1wSy3V0quXwoo85l Y1JXiL4Rky+4rLZBJ++XtEJluYcq4cSJ6FM0edkD9w5WXoT+pgz/VEvtIxMYxmdT nrRBcPHXatdn0/ucjEyxNn+H9T8m8VpGPfX3BLy3Np1m5759vusELTYPuLmH9o8P A48apILZpAjQDVZICt5zdTbgIBee4JuhEbyGvOZiqkfQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=pd1MxD 11k7v/ZIsZG1v2Lf2IgVkbMScYI5M7aKyS7cU=; b=dGfaYtbNMFRf8EVPXNw09f AxWOU8Y37kLn2r9j3yVd4jEXgHb20ZpmIQdZlQvqR3fQkJsyKukKQ2eiUDbajEm6 2kXywENfeCIgq6wI4uEfN0hS0g0Qed6B1aG6Xs0+i4wcAeADt80Xcyl2lSNhXSwg p7Sv9HXMbBeJybDaiMzNPDzUvvAb83KIBO/JnBnXPiQOcNcIkPLNhq5ozzfdkuig ukkBSfEKiRDIxzshTYX9aHoX5vZFsDV6ZKB1IdwDuRR2iN1TisDWccUVKdXNNujp E1VcnXuwnwKRTuoZjqUfsTtsTX18n8z1LoGMLT7N8Yhb0wjJbrdJ4EXEk1p0B5TQ == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrtddugdduvdekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufgjfhgffffkgggtsehttddttddtredtnecuhfhrohhmpefuvggrnhcu hghhihhtthhonhcuoehsphifhhhithhtohhnsehsphifhhhithhtohhnrdhnrghmvgeqne cuggftrfgrthhtvghrnhepleeggefgvdeijedvhfdugfegtefgkeekueeileejjeehudeg geefteeghfeuffeknecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilh hfrhhomhepshhpfihhihhtthhonhesshhpfihhihhtthhonhdrnhgrmhgv X-ME-Proxy: Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 12 Jan 2022 16:41:35 -0500 (EST) Original-Received: by athena.silentflame.com (Postfix, from userid 1000) id E539C1B988A; Wed, 12 Jan 2022 21:41:33 +0000 (UTC) In-Reply-To: <83k0f557f7.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:224049 Archived-At: Hello, On Wed 12 Jan 2022 at 04:56pm +02, Eli Zaretskii wrote: >> From: Sean Whitton >> Cc: 52888@debbugs.gnu.org >> Date: Thu, 06 Jan 2022 11:10:12 -0700 >> >> > OK, but (a) we need a comment there explaining why FC_VARIABLE is used >> > as the condition, and (b) we'd also need to merge the temporary fix in >> > font.c to master. >> >> Here's an updated patch. I don't think I can help with (b) but let me >> know if there's something I can do. > > Thanks, I installed this, and also installed a followup change that is > the "temporary fix" from emacs-28 adapted to the code on master. Thank you for reviewing and installing. The temporary fix can't do any harm, I suppose, but it is not clear to me why it is necessary -- fontconfig doesn't generate the virtual/meta FcPatterns in versions older than 2.12.91. Sorry if I didn't make that clearer earlier, or if I am missing some other reason why it is necessary. -- Sean Whitton