From: Lars Ingebrigtsen <larsi@gnus.org>
To: 51308@debbugs.gnu.org
Cc: 52138@debbugs.gnu.org, Andrea Corallo <akrl@sdf.org>
Subject: bug#51308: bug#52138: 29.0.50; Some tests fail on emba when run with native compilation
Date: Sat, 12 Mar 2022 22:32:57 +0100 [thread overview]
Message-ID: <87pmmqyhyu.fsf_-_@gnus.org> (raw)
In-Reply-To: <87o87jgga3.fsf@gnus.org> (Lars Ingebrigtsen's message of "Thu, 21 Oct 2021 06:20:36 +0200")
Lars Ingebrigtsen <larsi@gnus.org> writes:
> This is a bug-ish. If dired isn't natively-compiled:
>
> (locate-file "dired" load-path (get-load-suffixes))
> => "/home/larsi/src/emacs/trunk/lisp/dired.elc"
>
> But if it is, then we return the .el file instead:
>
> (locate-file "dired" load-path (get-load-suffixes))
> => "/home/larsi/src/emacs/trunk/lisp/dired.el"
>
> But load-history has:
>
> ("/home/larsi/src/emacs/emacs-28/lisp/dired.elc"
>
> Which means that we can't find the .elc file by looking into
> load-history based on locate-file.
>
> Returning the .elc file would fix this, but I don't know what other
> repercussions there might be.
I've now done this change (which fixes this test failure), and I don't
see any other regressions, so I've pushed it to Emacs 29.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2022-03-12 21:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-20 18:20 bug#51308: 29.0.50; A number of tests fail with AOT Lars Ingebrigtsen
2021-10-20 18:28 ` Eli Zaretskii
2021-10-21 3:04 ` Lars Ingebrigtsen
2021-10-21 4:20 ` Lars Ingebrigtsen
2022-03-12 21:32 ` Lars Ingebrigtsen [this message]
2022-03-13 5:45 ` bug#51308: bug#52138: 29.0.50; Some tests fail on emba when run with native compilation Eli Zaretskii
2022-03-13 14:14 ` Lars Ingebrigtsen
2022-03-13 16:40 ` bug#52138: " Eli Zaretskii
2021-10-21 4:31 ` bug#51308: 29.0.50; A number of tests fail with AOT Lars Ingebrigtsen
2022-03-12 21:42 ` bug#51308: bug#52138: 29.0.50; Some tests fail on emba when run with native compilation Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pmmqyhyu.fsf_-_@gnus.org \
--to=larsi@gnus.org \
--cc=51308@debbugs.gnu.org \
--cc=52138@debbugs.gnu.org \
--cc=akrl@sdf.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).