From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#55579: 29.0.50; Abbrevs not saved on exit anymore Date: Mon, 23 May 2022 09:46:48 +0200 Message-ID: <87pmk4r8rb.fsf@gnus.org> References: <865ylxwqks.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6049"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 55579@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon May 23 09:54:32 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nt2tb-0001NF-Ta for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 23 May 2022 09:54:31 +0200 Original-Received: from localhost ([::1]:46264 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nt2ta-0007YF-3m for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 23 May 2022 03:54:30 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46100) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nt2nK-0002TC-RY for bug-gnu-emacs@gnu.org; Mon, 23 May 2022 03:48:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:53284) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nt2nK-0007Jq-Ek for bug-gnu-emacs@gnu.org; Mon, 23 May 2022 03:48:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nt2nK-0002TM-7r for bug-gnu-emacs@gnu.org; Mon, 23 May 2022 03:48:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 23 May 2022 07:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55579 X-GNU-PR-Package: emacs Original-Received: via spool by 55579-submit@debbugs.gnu.org id=B55579.16532920239276 (code B ref 55579); Mon, 23 May 2022 07:48:02 +0000 Original-Received: (at 55579) by debbugs.gnu.org; 23 May 2022 07:47:03 +0000 Original-Received: from localhost ([127.0.0.1]:47178 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nt2mM-0002PX-PS for submit@debbugs.gnu.org; Mon, 23 May 2022 03:47:02 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:48898) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nt2mK-0002Oy-HJ for 55579@debbugs.gnu.org; Mon, 23 May 2022 03:47:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=YklgszPZQT2PEFa80k//peRc3vKndAq/4XPQ5NhHrTU=; b=ZuUCs4+/4HWFJ3WlpXTWIRv/d7 XMYvDrtbb4wQ5zE83XuMiBaugzmd8VYYwRRgdpvkOnZxoSN47bVQFYUiP4/yI/e9VRQyrZhgHBvK6 sO+2EhZQSPpiI526lr6pVJz7WSEQfTdI/Gs8fUq+QQw1R/NMDnyRMOyVwk8Cd6HCGXvc=; Original-Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nt2mB-0007tz-5n; Mon, 23 May 2022 09:46:53 +0200 X-Now-Playing: Cabaret Voltaire's _Shadow Of Fear_: "Papa Nine Zero Delta United" In-Reply-To: <865ylxwqks.fsf@mail.linkov.net> (Juri Linkov's message of "Sun, 22 May 2022 20:10:43 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:232933 Archived-At: Juri Linkov writes: > After a recent change, 'C-x C-c' doesn't ask anymore to save abbrevs with: > > Save abbrevs in ~/.emacs.d/abbrev_defs? > > It looks like the regression was caused by ce220524fcf. > Before this change, save-buffers-kill-emacs unconditionally > called save-some-buffers that also saves the abbrev table. > But after the change, save-some-buffers that saves abbrevs > is called only when files--buffers-needing-to-be-saved > detects unsaved buffers. Wow -- I had no idea that save-some-buffers also randomly saved abbrevs. I've now separated that this out into a general mechanism that abbrev.el now hooks into, while also fixing this `C-x C-c' bug. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no