From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#55678: 29.0.50; C-c C-w and errors in major-mode-hook Date: Sat, 28 May 2022 12:52:58 +0200 Message-ID: <87pmjy3p4l.fsf@gnus.org> References: <87bkvjf2pf.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26150"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 55678@debbugs.gnu.org To: Visuwesh Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat May 28 12:54:33 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nuu5X-0006bM-Tm for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 28 May 2022 12:54:31 +0200 Original-Received: from localhost ([::1]:45466 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nuu5W-00083U-Nd for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 28 May 2022 06:54:30 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50194) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nuu54-00082U-F6 for bug-gnu-emacs@gnu.org; Sat, 28 May 2022 06:54:10 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:42581) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nuu54-0000zw-6Z for bug-gnu-emacs@gnu.org; Sat, 28 May 2022 06:54:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nuu54-0002Fh-4g for bug-gnu-emacs@gnu.org; Sat, 28 May 2022 06:54:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 28 May 2022 10:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55678 X-GNU-PR-Package: emacs Original-Received: via spool by 55678-submit@debbugs.gnu.org id=B55678.16537351928597 (code B ref 55678); Sat, 28 May 2022 10:54:02 +0000 Original-Received: (at 55678) by debbugs.gnu.org; 28 May 2022 10:53:12 +0000 Original-Received: from localhost ([127.0.0.1]:36478 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nuu4G-0002Eb-Hz for submit@debbugs.gnu.org; Sat, 28 May 2022 06:53:12 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:50450) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nuu4D-0002EK-1W for 55678@debbugs.gnu.org; Sat, 28 May 2022 06:53:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=ZDhAp5ey3lShS2VSozfvPDnisjkGEunTGaWyCNAxUvg=; b=BjtusRAReHM++R86HE9xS1mnvt tB2jsFv/IglEk9y2tXeC7Q17uK9Bd06dvfLNLD5cY4RVmqNWlF7ZZxALz+qz+oCHMbfALuMqHUhdk qcmifi7SFTj+kEDdGL4Y1ACl8ieOFpp4X0xgWPegbYb5/f8xTqOw9soutwWK2FFTSztE=; Original-Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nuu44-0002eB-OP; Sat, 28 May 2022 12:53:02 +0200 X-Now-Playing: Snapped Ankles's _Forest of Your Problems_: "Susurrations (In The Forest)" In-Reply-To: <87bkvjf2pf.fsf@gmail.com> (Visuwesh's message of "Fri, 27 May 2022 20:21:56 +0530") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:233251 Archived-At: Visuwesh writes: > I have paredit-mode in emacs-lisp-mode-hook, and when the buffer has > mismatched parens [(check-paren)=nil], it signals an error. This makes > `diff-add-log-current-entries' not add any of the entries. > > For a simple reproducer, > > 1. emacs -Q > > 2. M-: (add-hook 'emacs-lisp-mode-hook (defun test () (error "test error"))) > > 3. Create a temporary git repo, commit an initial change by adding > an elisp file. > > 4. Add some more text. C-x v v. > > 5. C-c C-w. Note "test error" in the echo-area. > > I narrowed down the problem to `diff-add-log-current-entries' and I > *think* the problem is in goto-otherbuf function but when I added an > ignore-error around (funcall (buffer-local-value 'major-mode buf)), I > noticed no change. :-/ Isn't the problem here that paredit-mode signals an error when being switched on? Modes aren't supposed to do that. For reference, here's the backtrace in the test case: Debugger entered--Lisp error: (error "test error") signal(error ("test error")) error("test error") test() run-hooks(change-major-mode-after-body-hook prog-mode-hook lisp-data-mode-hook emacs-lisp-mode-hook) apply(run-hooks (change-major-mode-after-body-hook prog-mode-hook lisp-data-mode-hook emacs-lisp-mode-hook)) run-mode-hooks(emacs-lisp-mode-hook) emacs-lisp-mode() #f(compiled-function () #)() #f(compiled-function (&optional get-current) #)() diff-add-log-current-defuns() log-edit-generate-changelog-from-diff() funcall-interactively(log-edit-generate-changelog-from-diff) call-interactively(log-edit-generate-changelog-from-diff nil nil) command-execute(log-edit-generate-changelog-from-diff) -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no